Page MenuHomePhabricator

List of more-doughy-than-desirable transaction icons
Closed, ResolvedPublic

Description

You're probably ahead of me on this, but here's what I'm catching:

  • Some icons are off-center (lock, pin). Maybe we need text-align: center (and width: ...?) or similar?
  • "Closed as a duplicate" doesn't have an icon.

{F146813}
{F146815}

Event Timeline

epriestley raised the priority of this task from to Needs Triage.
epriestley updated the task description. (Show Details)
epriestley added a project: Design.
epriestley added subscribers: epriestley, chad.

yeah, i just saw a mis-centered one, was working on a fix. another thing I couldn't solve I meant to ask you was assigning reviewers, i tried to set custom icons for it but couldnt find it

I honestly can't find where that maniphest closed as duplicate icon is.

Reviewers are probably funky, I can send you a diff for it. What icon?

Closed as duplicate is defined in PhabricatorManiphestConfigOptions, since statuses can have custom icons. Near line 105:

'duplicate' => array(
  'name' => pht('Duplicate'),
  'name.full' => pht('Closed, Duplicate'),
  'transaction.icon' => 'delete',
  'special' => ManiphestTaskStatus::SPECIAL_DUPLICATE,
  'closed' => true,
),
'spite' => array(
  'name' => pht('Spite'),
  'name.full' => pht('Closed, Spite'),
  'name.action' => pht('Spited'),
  'transaction.icon' => 'dislike',

Both of those transaction.icon entries probably need to be fa-somethingsomething now.

I will likely fix some of those by hand with Fontello once the dust settles (and build smaller font files)

epriestley edited this Maniphest Task.
epriestley claimed this task.

Sounds good. I'll yelp if I catch anything else, but I poked around a bit and nothing else jumped out at me.

welp, on my phone these icons are off in Mobile Chrome, but when scaled in Mac Chrome, they work as expected.