Page MenuHomePhabricator
Differential D8791

Add a "Create build step" transaction to Harbormaster
ClosedPublic
Actions

Authored by epriestley on Apr 16 2014, 5:53 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Apr 28, 8:36 PM
Unknown Object (File)
Sun, Apr 28, 12:16 PM
Unknown Object (File)
Sun, Apr 28, 12:16 PM
Unknown Object (File)
Sun, Apr 28, 12:15 PM
Unknown Object (File)
Sun, Apr 28, 12:15 PM
Unknown Object (File)
Wed, Apr 24, 10:30 PM
Unknown Object (File)
Tue, Apr 23, 5:05 AM
Unknown Object (File)
Fri, Apr 19, 9:07 AM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T1049: Implement Harbormaster
Commits
Restricted Diffusion Commit
rPafd04731ab1f: Add a "Create build step" transaction to Harbormaster
Summary

Without this, build steps that have no options (like "wait for previous commits") don't actually save, since the transaction array is empty.

This also generally nice and consistent.

Test Plan

Created a new "wait" step, viewed transaction log.

Diff Detail

Repository
rP Phabricator
Branch
wait3
Lint
Lint Passed
Unit
No Test Coverage

Event Timeline

epriestley updated this revision to Diff 20853.Apr 16 2014, 5:53 PM
epriestley retitled this revision from to Add a "Create build step" transaction to Harbormaster.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
Herald added a subscriber: epriestley.Apr 16 2014, 5:53 PM
btrahan accepted this revision.Apr 16 2014, 6:36 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Apr 16 2014, 6:36 PM
epriestley closed this revision.Apr 16 2014, 8:02 PM
epriestley updated this revision to Diff 20864.

Closed by commit rPafd04731ab1f (authored by @epriestley).

Revision Contents
Changeset List

PathSize
src/
applications/
harbormaster/
controller/
7 lines
editor/
56 lines
storage/
configuration/
46 lines

Diff 20853

View Options

src/applications/harbormaster/controller/HarbormasterStepEditController.php

Loading...
View Options

src/applications/harbormaster/editor/HarbormasterBuildStepEditor.php

Loading...
View Options

src/applications/harbormaster/storage/configuration/HarbormasterBuildStepTransaction.php

Loading...
Phabricator · Built by Phacility