HomePhabricator

Allow Harbormaster build targets to wait for messages

Description

Allow Harbormaster build targets to wait for messages

Summary:
This hooks up all the pieces of the build pipeline so harbormaster.sendmessage actually works. Particularly:

  • Candidate build steps (i.e., those which interact with external systems) can now "Wait for Message". This pauses them indefinitely when they complete, until something calls harbormaster.sendmessage.
  • After processing a target, we check if we should move it to PASSED or WAITING.
  • Before updating a build, we move WAITING targets with pending messages to either PASSED or FAILED.
  • I added an explicit "Building" state, which doesn't affect workflows but communicates more information to human users.

A big part of this is avoiding races. I believe we get the correct behavior no matter which order events occur in:

  • We update builds after targets complete and after we receive messages, so we're guaranteed to update once both these conditions are true. This means messages can't be lost (even if they arrive before a build completes).
  • The minor changes to the build engine logic mean that firing additional build updates is always safe, no matter what the current state of the build is.
  • The build itself is protected by a lock in the build engine.
  • The target is not covered by an explicit lock, but for all states only the engine (waiting) or the worker (all other states) can interact with it. All of the interactions also move the target state forward to the same destination and have no other side effects.
  • Messages are only consumed inside the engine lock, so they don't need an explicit lock.

Test Plan:

  • Made an HTTP request wait after completion, then ran a pile of builds through it using bin/harbormaster build and the web UI.
  • Passed and failed message-awaiting builds with harbormaster.sendmessage.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley, zeeg

Differential Revision: https://secure.phabricator.com/D8788

Details

Provenance
epriestleyAuthored on
epriestleyPushed on Apr 16 2014, 8:01 PM
Reviewer
btrahan
Differential Revision
D8788: Allow Harbormaster build targets to wait for messages
Parents
rP803c50c1e7b4: Allow Harbormaster HTTP steps to pass credentials
Branches
Unknown
Tags
Unknown

Event Timeline