I haven't been able to understand why this isn't set by default in production environments (since it is recommended to do so anyway).
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Commits
- Restricted Diffusion Commit
rPe7419d85f700: Set `celerity.minify` true in production environments.
N/A
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Lint
Lint Skipped - Unit
Tests Skipped
Event Timeline
Comment Actions
Nice catch!
This file is very rarely read now, so this isn't the best way to adjust the defaults (it will apply to only some installs). Instead:
- Adjust the global default in src/applications/config/option/PhabricatorDeveloperConfigOptions.php.
- Adjust the default from conf/default.conf.php, or remove it entirely (if removed, it will fall back to the global default).
- Override it in conf/development.conf.php.
I think this never got set to true by default because it used to rely on building complicated externals (notably, jsxmin). However, we now have reasonable builtin/fallback minifiers and setting it to true is sensible.
Comment Actions
- Adjust the global default in src/applications/config/option/PhabricatorDeveloperConfigOptions.php.
- Adjust the default from conf/default.conf.php.
- Override it in conf/development.conf.php.
Comment Actions
Closed by commit rPe7419d85f700 (authored by @joshuaspence, committed by @epriestley).