Page MenuHomePhabricator
Differential D8743

Set `celerity.minify` true in production environments.
ClosedPublic
Actions

Authored by joshuaspence on Apr 10 2014, 2:09 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 20, 6:46 PM
Unknown Object (File)
Tue, Apr 9, 10:09 AM
Unknown Object (File)
Sun, Apr 7, 9:47 AM
Unknown Object (File)
Sat, Apr 6, 10:26 AM
Unknown Object (File)
Tue, Apr 2, 2:41 AM
Unknown Object (File)
Fri, Mar 29, 2:02 AM
Unknown Object (File)
Fri, Mar 29, 1:14 AM
Unknown Object (File)
Mar 5 2024, 7:21 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
Restricted Diffusion Commit
rPe7419d85f700: Set `celerity.minify` true in production environments.
Summary

I haven't been able to understand why this isn't set by default in production environments (since it is recommended to do so anyway).

Test Plan

N/A

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

joshuaspence updated this revision to Diff 20734.Apr 10 2014, 2:09 PM
joshuaspence retitled this revision from to Set `celerity.minify` true in production environments..
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers.Apr 10 2014, 2:09 PM
Herald added subscribers: Korvin, epriestley.
epriestley requested changes to this revision.Apr 10 2014, 2:19 PM
epriestley edited edge metadata.

Nice catch!

This file is very rarely read now, so this isn't the best way to adjust the defaults (it will apply to only some installs). Instead:

  • Adjust the global default in src/applications/config/option/PhabricatorDeveloperConfigOptions.php.
  • Adjust the default from conf/default.conf.php, or remove it entirely (if removed, it will fall back to the global default).
  • Override it in conf/development.conf.php.

I think this never got set to true by default because it used to rely on building complicated externals (notably, jsxmin). However, we now have reasonable builtin/fallback minifiers and setting it to true is sensible.

This revision now requires changes to proceed.Apr 10 2014, 2:19 PM
joshuaspence updated this revision to Diff 20756.Apr 10 2014, 9:36 PM
joshuaspence edited edge metadata.
  • Adjust the global default in src/applications/config/option/PhabricatorDeveloperConfigOptions.php.
  • Adjust the default from conf/default.conf.php.
  • Override it in conf/development.conf.php.
epriestley accepted this revision.Apr 10 2014, 9:38 PM
epriestley edited edge metadata.

(Update libphutil/ to clear lint, first bullet point in the message.)

This revision is now accepted and ready to land.Apr 10 2014, 9:38 PM
epriestley closed this revision.Apr 10 2014, 9:39 PM
epriestley updated this revision to Diff 20757.

Closed by commit rPe7419d85f700 (authored by @joshuaspence, committed by @epriestley).

Revision Contents
Changeset List

PathSize
conf/
2 lines
1 line
src/
applications/
config/
option/
2 lines

Diff 20757

View Options

conf/default.conf.php

Loading...
View Options

conf/development.conf.php

Loading...
View Options

src/applications/config/option/PhabricatorDeveloperConfigOptions.php

Loading...
Phabricator · Built by Phacility