Set `celerity.minify` true in production environments.
ClosedPublic
Actions

Authored by joshuaspence on Apr 10 2014, 2:09 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

Restricted Diffusion Commit
rPe7419d85f700: Set `celerity.minify` true in production environments.

Summary

I haven't been able to understand why this isn't set by default in production environments (since it is recommended to do so anyway).

Test Plan

N/A

Diff Detail

Repository

rP Phabricator

Branch

production

Lint

Lint Errors

Severity	Location	Code	Message
Error	src/applications/auth/provider/PhabricatorAuthProviderLDAP.php:172	PHL1	Unknown Symbol

Unit

No Test Coverage

Event Timeline

joshuaspence updated this revision to Diff 20734.Apr 10 2014, 2:09 PM

joshuaspence retitled this revision from to Set `celerity.minify` true in production environments..

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers.Apr 10 2014, 2:09 PM

Herald added subscribers: Korvin, epriestley.

Nice catch!

This file is very rarely read now, so this isn't the best way to adjust the defaults (it will apply to only some installs). Instead:

Adjust the global default in src/applications/config/option/PhabricatorDeveloperConfigOptions.php.
Adjust the default from conf/default.conf.php, or remove it entirely (if removed, it will fall back to the global default).
Override it in conf/development.conf.php.

I think this never got set to true by default because it used to rely on building complicated externals (notably, jsxmin). However, we now have reasonable builtin/fallback minifiers and setting it to true is sensible.

This revision now requires changes to proceed.Apr 10 2014, 2:19 PM

Adjust the global default in src/applications/config/option/PhabricatorDeveloperConfigOptions.php.
Adjust the default from conf/default.conf.php.
Override it in conf/development.conf.php.