Page MenuHomePhabricator

Render default/current settings in the same format they'll be edited
ClosedPublic

Authored by epriestley on Apr 8 2014, 6:56 PM.
Tags
None
Referenced Files
F18784371: D8725.diff
Mon, Oct 13, 12:24 PM
F18734749: D8725.id.diff
Tue, Sep 30, 11:01 PM
F18726134: D8725.id20688.diff
Tue, Sep 30, 6:16 AM
F18640907: D8725.diff
Thu, Sep 18, 7:01 PM
F18618205: D8725.diff
Sep 14 2025, 11:26 PM
F18511445: D8725.id.diff
Sep 5 2025, 6:38 AM
F18107182: D8725.diff
Aug 10 2025, 11:44 PM
F18082906: D8725.id.diff
Aug 5 2025, 7:56 AM
Subscribers

Details

Summary

Fixes T4773. For config settings of type list<string>, set, or list<regex>, the "defaults" table and "examples" aren't always in the same format you should actually use when changing the setting.

This is pretty confusing. Instead, always show the settings in the desired format. For example, if the user should enter a newline-separated list, show them a newline separated list.

Test Plan
  • Grepped for list<string>, list<regex>, and 'set'; verified all the config had the right example format (most already did).
  • Viewed config settings of various kinds, including custom settings.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Render default/current settings in the same format they'll be edited.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.

New, copy-paste friendly version of this UI:

Screen_Shot_2014-04-08_at_11.56.37_AM.png (889×1 px, 147 KB)

btrahan edited edge metadata.
This revision is now accepted and ready to land.Apr 8 2014, 7:08 PM
epriestley updated this revision to Diff 20691.

Closed by commit rPf79320e64e8f (authored by @epriestley).