Differential D8719

Hide "Land to hosted git" button for now
ClosedPublic
Actions

Authored by epriestley on Apr 8 2014, 12:41 PM.

Tags

None

Referenced Files

	F18866704: D8719.diff
	Mon, Nov 3, 6:48 PM

	F18816364: D8719.id.diff
	Tue, Oct 21, 6:20 AM

	F18814969: D8719.diff
	Tue, Oct 21, 12:16 AM

	F18814216: D8719.diff
	Mon, Oct 20, 10:23 PM

	F18808902: D8719.diff
	Sun, Oct 19, 9:41 AM

	F18705125: D8719.id20678.diff
	Sep 28 2025, 10:14 AM

	F18646145: D8719.diff
	Sep 19 2025, 9:35 AM

	F18627123: D8719.id.diff
	Sep 16 2025, 3:15 AM

Subscribers

Details

Reviewers

btrahan
chad

Maniphest Tasks

T182: Commit into repository directly from differential

Commits

Restricted Diffusion Commit
rPe8e62f82ceae: Hide "Land to hosted git" button for now

Summary

Ref T182. This feature rarely/never works and is on the balance enormously confusing to users (see https://github.com/facebook/phabricator/issues/566). If installs have somehow made it sort of work, they can comment this line out for now until we have time to make this work more reasonably.

Test Plan

Looked at a revision in Differential.

Diff Detail

Repository

Branch

hideland

Lint

Lint Passed

Severity	Location	Code	Message
Advice	src/applications/differential/landing/DifferentialLandingToHostedGit.php:126	XHP16	TODO Comment

Unit

Tests Passed

Event Timeline

epriestley updated this revision to Diff 20674.Apr 8 2014, 12:41 PM

epriestley retitled this revision from to Hide "Land to hosted git" button for now.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T182: Commit into repository directly from differential.

Herald added a subscriber: epriestley.Apr 8 2014, 12:41 PM

chad accepted this revision.Apr 8 2014, 2:56 PM

chad added a reviewer: chad.

This revision is now accepted and ready to land.Apr 8 2014, 2:56 PM

Closed by commit rPe8e62f82ceae (authored by @epriestley).

btrahan added inline comments.Apr 8 2014, 5:20 PM

src/applications/differential/landing/DifferentialLandingToHostedGit.php
128	*eventually

epriestley mentioned this in D18150: Remove old "Landing Strategy" code.Jun 23 2017, 3:10 PM

epriestley mentioned this in rP219ae8b6c950: Remove old "Landing Strategy" code.Jun 23 2017, 3:14 PM

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

landing/

DifferentialLandingToHostedGit.php

5 lines

Diff 20674

src/applications/differential/landing/DifferentialLandingToHostedGit.php

Loading...