Paths

Table of Contentst

Make Cmd+Enter work to submit a form
ClosedPublic
Actions

Authored by sophiebits on Apr 4 2014, 1:59 AM.

Tags

None

Referenced Files

	F13188982: D8699.diff
	Sat, May 11, 5:39 AM

	Unknown Object (File)
	Tue, May 7, 8:27 AM

	Unknown Object (File)
	Mon, May 6, 10:47 AM

	Unknown Object (File)
	Sat, May 4, 7:49 PM

	Unknown Object (File)
	Fri, May 3, 9:04 AM

	Unknown Object (File)
	Thu, May 2, 10:10 AM

	Unknown Object (File)
	Sun, Apr 28, 12:11 PM

	Unknown Object (File)
	Sun, Apr 28, 12:11 PM

View All Files

Subscribers

epriestley

Korvin

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

Restricted Maniphest Task

Commits

Restricted Diffusion Commit
rP077f57f06dee: Make Cmd+Enter work to submit a form

Summary

Fixes T3010.

keydown is what you're supposed to use for special keys like Enter; keypress didn't work for me for Cmd+Enter on Chrome.

Test Plan

Submitted a Differential field with Cmd+Enter on Chrome Mac. Also made sure Ctrl+Enter still works and Opt+Enter does not.

Diff Detail

Repository

rP Phabricator

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

sophiebits updated this revision to Diff 20632.Apr 4 2014, 1:59 AM

sophiebits added a task: Restricted Maniphest Task.

sophiebits retitled this revision from to Make Cmd+Enter work to submit a form.

sophiebits updated this object.

sophiebits edited the test plan for this revision. (Show Details)

sophiebits added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers.Apr 4 2014, 1:59 AM

Herald added subscribers: Korvin, epriestley.

epriestley accepted this revision.Apr 4 2014, 2:00 AM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Apr 4 2014, 2:00 AM

Closed by commit rP077f57f06dee (authored by @spicyj, committed by @epriestley).

Revision Contents
Changeset List

Path

Size

webroot/

rsrc/

js/

core/

behavior-form.js

4 lines

Diff 20633

View Options

webroot/rsrc/js/core/behavior-form.js

Make Cmd+Enter work to submit a formClosedPublicActions