Page MenuHomePhabricator
Differential D8695

Support CustomField in Herald, mostly
ClosedPublic
Actions

Authored by epriestley on Apr 4 2014, 12:48 AM.
Tags
None
Referenced Files
F15713996: D8695.diff
Thu, May 29, 4:34 AM
F15713587: D8695.id20622.diff
Thu, May 29, 4:25 AM
F15711438: D8695.id20631.diff
Thu, May 29, 3:30 AM
F15701422: D8695.diff
Wed, May 28, 7:08 PM
F15701365: D8695.id20631.diff
Wed, May 28, 7:04 PM
Unknown Object (File)
Wed, May 28, 12:44 AM
Unknown Object (File)
Wed, May 28, 12:37 AM
Unknown Object (File)
Mon, May 5, 4:35 PM
View All Files
Subscribers
epriestley
Tokens
"Mountain of Wealth" token, awarded by btrahan.

Details

Reviewers
btrahan
Maniphest Tasks
T418: Integrate CustomField into more interfaces
T655: Integrate CustomField into Herald
Commits
Restricted Diffusion Commit
rPe3b5737d02fb: Support CustomField in Herald, mostly
Summary

Ref T655. Ref T418. This mostly supports CustomFields in Herald, for conditions only.

Test Plan

SafariScreenSnapz002.png (635×1 px, 97 KB)

Diff Detail

Repository
rP Phabricator
Branch
herald1
Lint
Lint Passed
Unit
Tests Passed

Event Timeline

epriestley updated this revision to Diff 20622.Apr 4 2014, 12:48 AM
epriestley retitled this revision from to Support CustomField in Herald, mostly.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added tasks: T655: Integrate CustomField into Herald, T418: Integrate CustomField into more interfaces.
Herald added a subscriber: epriestley.Apr 4 2014, 12:48 AM
btrahan accepted this revision.Apr 4 2014, 1:01 AM
btrahan edited edge metadata.

...and suddenly, they were all cooking with gasoline.

This revision is now accepted and ready to land.Apr 4 2014, 1:01 AM
epriestley closed this revision.Apr 4 2014, 1:43 AM
epriestley updated this revision to Diff 20631.

Closed by commit rPe3b5737d02fb (authored by @epriestley).

Revision Contents
Changeset List

Diff 20622

View Options

src/applications/herald/adapter/HeraldAdapter.php

Loading...
View Options

src/applications/herald/adapter/HeraldManiphestTaskAdapter.php

Loading...
View Options

src/applications/herald/controller/HeraldRuleController.php

Loading...
View Options

src/applications/herald/storage/HeraldRule.php

Loading...
View Options

src/infrastructure/customfield/field/PhabricatorCustomField.php

Loading...
View Options

src/infrastructure/customfield/standard/PhabricatorStandardCustomField.php

Loading...
View Options

src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldBool.php

Loading...
View Options

src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldPHIDs.php

Loading...
View Options

src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldRemarkup.php

Loading...
View Options

src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldText.php

Loading...
View Options

src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldUsers.php

Loading...
Phabricator · Built by Phacility