Page MenuHomePhabricator

Support CustomField in Herald, mostly
ClosedPublic

Authored by epriestley on Apr 4 2014, 12:48 AM.
Tags
None
Referenced Files
F15713996: D8695.diff
Thu, May 29, 4:34 AM
F15713587: D8695.id20622.diff
Thu, May 29, 4:25 AM
F15711438: D8695.id20631.diff
Thu, May 29, 3:30 AM
F15701422: D8695.diff
Wed, May 28, 7:08 PM
F15701365: D8695.id20631.diff
Wed, May 28, 7:04 PM
Unknown Object (File)
Wed, May 28, 12:44 AM
Unknown Object (File)
Wed, May 28, 12:37 AM
Unknown Object (File)
Mon, May 5, 4:35 PM
Subscribers
Tokens
"Mountain of Wealth" token, awarded by btrahan.

Details

Summary

Ref T655. Ref T418. This mostly supports CustomFields in Herald, for conditions only.

Test Plan

SafariScreenSnapz002.png (635×1 px, 97 KB)

Diff Detail

Repository
rP Phabricator
Branch
herald1
Lint
Lint Passed
Unit
Tests Passed

Event Timeline

epriestley retitled this revision from to Support CustomField in Herald, mostly.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.

...and suddenly, they were all cooking with gasoline.

This revision is now accepted and ready to land.Apr 4 2014, 1:01 AM
epriestley updated this revision to Diff 20631.

Closed by commit rPe3b5737d02fb (authored by @epriestley).