Page MenuHomePhabricator

Move "Delete User" action to user profiles
ClosedPublic

Authored by epriestley on Apr 1 2014, 9:45 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, May 3, 5:26 AM
Unknown Object (File)
Mon, Apr 29, 4:09 PM
Unknown Object (File)
Sun, Apr 28, 12:03 PM
Unknown Object (File)
Sun, Apr 28, 12:03 PM
Unknown Object (File)
Sun, Apr 28, 12:03 PM
Unknown Object (File)
Thu, Apr 25, 9:06 PM
Unknown Object (File)
Wed, Apr 24, 10:57 PM
Unknown Object (File)
Wed, Apr 17, 3:03 PM
Subscribers

Details

Summary

Ref T4065. The existence of two separate edit workflows for users is broadly confusing to administrators.

I want to unify user administration and improve administration of system agent accounts. Particularly, I plan to:

  • Give administrators limited access to profile editing of system agents (e.g., change profile picture).
  • Give administrators limited access to Settings for system agents.
  • Broadly, move all the weird old special editing into standard editing.
Test Plan
  • Hit all the errors (delete self, no username, wrong username).
  • Deleted a user.
  • Visited page as a non-admin, got 403'd.
  • Viewed old edit UI.

Diff Detail

Repository
rP Phabricator
Branch
user1
Lint
Lint Passed
Unit
No Test Coverage

Event Timeline

epriestley retitled this revision from to Move "Delete User" action to user profiles.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
btrahan added inline comments.
src/applications/people/controller/PhabricatorPeopleDeleteController.php
116–117

Play any good videogames lately? :D

This revision is now accepted and ready to land.Apr 1 2014, 10:05 PM
epriestley updated this revision to Diff 20575.

Closed by commit rPa6a19ac72179 (authored by @epriestley).