Differential D8654

Fix SVN translation of "add-file" protocol frames over SSH
ClosedPublic
Actions

Authored by epriestley on Mar 31 2014, 2:50 AM.

Details

Reviewers

btrahan

Maniphest Tasks

T4697: SVN file moves for hosted repositories aren't translating a protocol frame?

Commits

Restricted Diffusion Commit
rPa6b1fac1172c: Fix SVN translation of "add-file" protocol frames over SSH

Summary

Fixes T4697. When pushing moved/copied files, SVN sends an "add-file" protocol frame which has a URI in it that needs translation from external format ("/diffusion/X/") to internal format ("/path/to/svn").

Test Plan

Copied/moved files and committed them in SVN.
Added files (no copy/move) and committed them in SVN.

Diff Detail

Repository

rP Phabricator

Branch

sshmove

Lint

Lint Passed

Unit

Tests Passed

Event Timeline

epriestley updated this revision to Diff 20517.Mar 31 2014, 2:50 AM

epriestley retitled this revision from to Fix SVN translation of "add-file" protocol frames over SSH.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T4697: SVN file moves for hosted repositories aren't translating a protocol frame?.

Herald added a subscriber: epriestley.Mar 31 2014, 2:50 AM

Remove debugging code.

Remove more debugging code.

btrahan accepted this revision.Mar 31 2014, 9:42 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Mar 31 2014, 9:42 PM

Closed by commit rPa6b1fac1172c (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

ssh/

DiffusionSSHSubversionServeWorkflow.php

19 lines

Diff 20517

View Options

src/applications/diffusion/ssh/DiffusionSSHSubversionServeWorkflow.php

Fix SVN translation of "add-file" protocol frames over SSHClosedPublicActions