Paths

Table of Contentst

Differential D8653

Allow arc to parse `svnlook` diffs from moves/copies
ClosedPublic
Actions

Authored by epriestley on Mar 31 2014, 2:48 AM.

Details

Reviewers

btrahan

Maniphest Tasks

T4697: SVN file moves for hosted repositories aren't translating a protocol frame?

Commits

rARCa36969e58bb4: Allow arc to parse `svnlook` diffs from moves/copies

Summary

Ref T4697. This is similar to the existing stuff, but svnlook diff ... can also produce a "Copied" header. Currently, we choke on it in Herald when running pre-commit rules.

Test Plan

Added and ran tests. In the next diff, used this in a real system.

Diff Detail

Repository

rARC Arcanist

Branch

svnlookcopy

Lint

Lint Errors

Severity	Location	Code	Message
Error	src/parser/__tests__/diff/svnlook-copied.svndiff:3	TXT2	Tab Literal

Unit

Tests Passed

Event Timeline

epriestley updated this revision to Diff 20516.Mar 31 2014, 2:48 AM

epriestley retitled this revision from to Allow arc to parse `svnlook` diffs from moves/copies.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T4697: SVN file moves for hosted repositories aren't translating a protocol frame?.

Herald added a subscriber: epriestley.Mar 31 2014, 2:48 AM

btrahan accepted this revision.Mar 31 2014, 9:39 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Mar 31 2014, 9:39 PM

Closed by commit rARCa36969e58bb4 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

parser/

ArcanistDiffParser.php

3 lines

__tests__/

ArcanistDiffParserTestCase.php

1 line

diff/

svnlook-copied.svndiff

7 lines

Diff 20516

View Options

src/parser/ArcanistDiffParser.php

View Options

src/parser/tests/ArcanistDiffParserTestCase.php

View Options

src/parser/tests/diff/svnlook-copied.svndiff

Allow arc to parse `svnlook` diffs from moves/copiesClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 20516

src/parser/ArcanistDiffParser.php

src/parser/__tests__/ArcanistDiffParserTestCase.php

src/parser/__tests__/diff/svnlook-copied.svndiff

Allow arc to parse `svnlook` diffs from moves/copies
ClosedPublic
Actions

Revision Contents
Changeset List

src/parser/tests/ArcanistDiffParserTestCase.php

src/parser/tests/diff/svnlook-copied.svndiff