Silence a warning about unknown fields in 'getcommitmessage'
ClosedPublic
Actions

Authored by epriestley on Mar 13 2014, 12:05 AM.

Tags

None

Referenced Files

	F13106459: D8514.diff
	Sat, Apr 27, 8:12 PM

	Unknown Object (File)
	Tue, Apr 23, 6:33 PM

	Unknown Object (File)
	Sat, Apr 20, 6:38 PM

	Unknown Object (File)
	Fri, Apr 19, 8:52 PM

	Unknown Object (File)
	Fri, Apr 19, 8:52 PM

	Unknown Object (File)
	Fri, Apr 19, 7:32 PM

	Unknown Object (File)
	Fri, Apr 19, 5:58 PM

	Unknown Object (File)
	Tue, Apr 16, 4:23 PM

Subscribers

Details

Reviewers

zeeg
btrahan
dctrwatson

Commits

Restricted Diffusion Commit
rPe068b04b5c95: Silence a warning about unknown fields in 'getcommitmessage'

Summary

Similar to D8491, some of my new exceptions are a bit too aggressive. See IRC. This one's hitting an edit workflow with 'revisionID' onboard somehow.

Test Plan

Not entirely sure how to hit this, but it won't throw anymore.

Diff Detail

Repository

rP Phabricator

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

epriestley updated this revision to Diff 20195.Mar 13 2014, 12:05 AM

epriestley retitled this revision from to Silence a warning about unknown fields in 'getcommitmessage'.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: btrahan, dctrwatson.

Herald added subscribers: epriestley, aran.Mar 13 2014, 12:05 AM

can i haz accept? ;)

This revision is now accepted and ready to land.Mar 13 2014, 12:10 AM

Closed by commit rPe068b04b5c95 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

conduit/

ConduitAPI_differential_getcommitmessage_Method.php

8 lines

Diff 20196

View Options

src/applications/differential/conduit/ConduitAPI_differential_getcommitmessage_Method.php

Silence a warning about unknown fields in 'getcommitmessage'ClosedPublicActions