Fix a bug for updating diffs
ClosedPublic
Actions

Authored by btrahan on Mar 11 2014, 10:11 PM.

Details

Reviewers

epriestley

Commits

Restricted Diffusion Commit
rP46cf263e9d55: Fix a bug for updating diffs

Summary

Hit this issue in D8485. I think reviewedByPHID changes should appear in application transactions.

Test Plan

Would like to deploy this and try updating D8485 again.

Diff Detail

Repository

rP Phabricator

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

btrahan updated this revision to Diff 20143.Mar 11 2014, 10:11 PM

btrahan retitled this revision from to Fix a bug for updating diffs.

btrahan updated this object.

btrahan edited the test plan for this revision. (Show Details)

btrahan added a reviewer: epriestley.

Herald added subscribers: Korvin, epriestley, aran.Mar 11 2014, 10:11 PM

Let's just find the throw new Exception(...) part and replace it with continue;. There's a similar condition immediately above it.

We don't make a strong distinction between readable and writable fields, and I think this exception is too aggressive.

This revision now requires changes to proceed.Mar 11 2014, 10:23 PM

Specifically, "Reviewed By" should not appear in the transaction record; running arc diff should never adjust who a revision was reviewed by.

updated as suggested

epriestley accepted this revision.Mar 11 2014, 10:29 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Mar 11 2014, 10:29 PM

Closed by commit rP46cf263e9d55 (authored by @btrahan).

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

conduit/

ConduitAPI_differential_Method.php

6 lines

Diff 20149

View Options

src/applications/differential/conduit/ConduitAPI_differential_Method.php

Fix a bug for updating diffsClosedPublicActions