Page MenuHomePhabricator

Fix a bug for updating diffs
ClosedPublic

Authored by btrahan on Mar 11 2014, 10:11 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 25, 3:19 AM
Unknown Object (File)
Fri, Apr 12, 6:50 AM
Unknown Object (File)
Sat, Apr 6, 8:15 PM
Unknown Object (File)
Tue, Apr 2, 7:54 AM
Unknown Object (File)
Tue, Apr 2, 7:54 AM
Unknown Object (File)
Tue, Apr 2, 7:54 AM
Unknown Object (File)
Tue, Apr 2, 7:29 AM
Unknown Object (File)
Tue, Apr 2, 7:18 AM

Details

Reviewers
epriestley
Commits
Restricted Diffusion Commit
rP46cf263e9d55: Fix a bug for updating diffs
Summary

Hit this issue in D8485. I think reviewedByPHID changes should appear in application transactions.

Test Plan

Would like to deploy this and try updating D8485 again.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

btrahan retitled this revision from to Fix a bug for updating diffs.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
epriestley edited edge metadata.

Let's just find the throw new Exception(...) part and replace it with continue;. There's a similar condition immediately above it.

We don't make a strong distinction between readable and writable fields, and I think this exception is too aggressive.

This revision now requires changes to proceed.Mar 11 2014, 10:23 PM

Specifically, "Reviewed By" should not appear in the transaction record; running arc diff should never adjust who a revision was reviewed by.

btrahan edited edge metadata.

updated as suggested

epriestley edited edge metadata.
This revision is now accepted and ready to land.Mar 11 2014, 10:29 PM
btrahan updated this revision to Diff 20149.

Closed by commit rP46cf263e9d55 (authored by @btrahan).