Page MenuHomePhabricator

Silence a warning about unknown fields in 'getcommitmessage'
ClosedPublic

Authored by epriestley on Mar 13 2014, 12:05 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 25, 2:45 AM
Unknown Object (File)
Thu, Mar 21, 6:01 AM
Unknown Object (File)
Thu, Mar 14, 12:25 AM
Unknown Object (File)
Feb 24 2024, 4:22 PM
Unknown Object (File)
Feb 14 2024, 11:58 AM
Unknown Object (File)
Feb 4 2024, 3:06 AM
Unknown Object (File)
Jan 29 2024, 5:44 AM
Unknown Object (File)
Jan 7 2024, 2:49 PM

Details

Summary

Similar to D8491, some of my new exceptions are a bit too aggressive. See IRC. This one's hitting an edit workflow with 'revisionID' onboard somehow.

Test Plan

Not entirely sure how to hit this, but it won't throw anymore.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Silence a warning about unknown fields in 'getcommitmessage'.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: btrahan, dctrwatson.
zeeg added a reviewer: zeeg.
zeeg added a subscriber: zeeg.

can i haz accept? ;)

This revision is now accepted and ready to land.Mar 13 2014, 12:10 AM
epriestley updated this revision to Diff 20196.

Closed by commit rPe068b04b5c95 (authored by @epriestley).