Page MenuHomePhabricator

Silence a warning about unknown fields in 'getcommitmessage'
ClosedPublic

Authored by epriestley on Mar 13 2014, 12:05 AM.
Tags
None
Referenced Files
F18031284: D8514.id20196.diff
Sat, Aug 2, 11:57 PM
F17946457: D8514.id.diff
Thu, Jul 31, 2:33 PM
F17944857: D8514.id20195.diff
Thu, Jul 31, 11:00 AM
F17923611: D8514.diff
Wed, Jul 30, 8:27 AM
Unknown Object (File)
Jun 20 2025, 11:21 AM
Unknown Object (File)
Jun 19 2025, 8:15 AM
Unknown Object (File)
Jun 9 2025, 2:04 AM
Unknown Object (File)
May 7 2025, 7:33 AM

Details

Summary

Similar to D8491, some of my new exceptions are a bit too aggressive. See IRC. This one's hitting an edit workflow with 'revisionID' onboard somehow.

Test Plan

Not entirely sure how to hit this, but it won't throw anymore.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Silence a warning about unknown fields in 'getcommitmessage'.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: btrahan, dctrwatson.
zeeg added a reviewer: zeeg.
zeeg added a subscriber: zeeg.

can i haz accept? ;)

This revision is now accepted and ready to land.Mar 13 2014, 12:10 AM
epriestley updated this revision to Diff 20196.

Closed by commit rPe068b04b5c95 (authored by @epriestley).