Page MenuHomePhabricator
Differential D8502

Add a "tags" field to Diffusion commit
ClosedPublic
Actions

Authored by epriestley on Mar 12 2014, 4:53 PM.
Tags
None
Referenced Files
F14060344: D8502.diff
Mon, Nov 18, 12:46 AM
F14049230: D8502.diff
Thu, Nov 14, 11:50 AM
F14036784: D8502.diff
Sun, Nov 10, 12:06 PM
F14009666: D8502.id20170.diff
Wed, Oct 30, 10:35 PM
F13992232: D8502.id20178.diff
Tue, Oct 22, 3:21 PM
F13992050: D8502.id.diff
Tue, Oct 22, 2:08 PM
F13991829: D8502.id20178.diff
Tue, Oct 22, 12:58 PM
F13991644: D8502.id.diff
Tue, Oct 22, 11:58 AM
View All Files
Subscribers
aran
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T4588: Add "branches" / "tags" information in Diffusion commit emails
Commits
Restricted Diffusion Commit
rPa4a4322d7abf: Add a "tags" field to Diffusion commit
Summary
  • Fixes T4588.
  • See D8501.
  • Adds a "Tags" field for Herald commit emails.
  • Fixes a bug in tagsquery when filtering by commit name.
  • Make tagsquery just return nothing instead of fataling against Mercurial/Subversion.
Test Plan

Used bin/repository/reparse.php --herald to exercise this code.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley updated this revision to Diff 20170.Mar 12 2014, 4:53 PM
epriestley retitled this revision from to Add a "tags" field to Diffusion commit.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T4588: Add "branches" / "tags" information in Diffusion commit emails.
Herald added subscribers: epriestley, aran.Mar 12 2014, 4:53 PM
btrahan accepted this revision.Mar 12 2014, 6:16 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 12 2014, 6:16 PM
epriestley closed this revision.Mar 12 2014, 6:30 PM
epriestley updated this revision to Diff 20178.

Closed by commit rPa4a4322d7abf (authored by @epriestley).

Revision Contents
Changeset List

PathSize
src/
2 lines
applications/
diffusion/
conduit/
17 lines
repository/
customfield/
37 lines
worker/
11 lines

Diff 20178

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/diffusion/conduit/ConduitAPI_diffusion_tagsquery_Method.php

Loading...
View Options

src/applications/repository/customfield/PhabricatorCommitTagsField.php

Loading...
View Options

src/applications/repository/worker/PhabricatorRepositoryCommitHeraldWorker.php

Loading...
Phabricator · Built by Phacility