Page MenuHomePhabricator

Clean up various pieces of dead/obsolete Differential code
ClosedPublic

Authored by epriestley on Mar 9 2014, 8:49 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Dec 17, 8:47 AM
Unknown Object (File)
Thu, Dec 12, 12:52 AM
Unknown Object (File)
Sat, Dec 7, 8:38 AM
Unknown Object (File)
Wed, Dec 4, 3:49 PM
Unknown Object (File)
Tue, Nov 19, 11:27 PM
Unknown Object (File)
Nov 16 2024, 6:23 AM
Unknown Object (File)
Nov 12 2024, 8:50 AM
Unknown Object (File)
Nov 8 2024, 9:08 AM
Subscribers

Details

Summary

Ref T2222.

  • Removes DifferentialTasksAttacher, which has had no callsites for a very long time.
  • Moves differential.getrevisioncomments off DifferentialCommentQuery.
  • Moves Releeph churn field off DifferentialCommentQuery.
  • Removes dead code in DifferentialRevisionViewController.
  • Removes DifferentialException (no references).
  • Removes DifferentialRevision->loadComments() (no callsites).
  • Removes DifferentialRevision->loadReviewedBy() (all callsites updated).
  • Removes DifferentialCommentQuery (all callsites updated).
Test Plan

Mostly a lot of grep.

Diff Detail

Repository
rP Phabricator
Branch
dx28
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/infrastructure/storage/lisk/PhabricatorLiskDAO.php:191XHP16TODO Comment
Unit
Tests Passed

Event Timeline

btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 10 2014, 6:48 PM
epriestley updated this revision to Diff 20129.

Closed by commit rP592591e71538 (authored by @epriestley).