Page MenuHomePhabricator

Clean up various pieces of dead/obsolete Differential code
ClosedPublic

Authored by epriestley on Mar 9 2014, 8:49 PM.
Tags
None
Referenced Files
F15463124: D8476.id.diff
Tue, Apr 1, 8:31 PM
F15462982: D8476.id20088.diff
Tue, Apr 1, 7:29 PM
F15455215: D8476.id.diff
Sat, Mar 29, 10:54 PM
F15450765: D8476.id20129.diff
Fri, Mar 28, 6:08 PM
F15449310: D8476.id20088.diff
Fri, Mar 28, 9:25 AM
F15445790: D8476.diff
Thu, Mar 27, 4:02 PM
F15431672: D8476.id20129.diff
Mon, Mar 24, 1:51 PM
F15413966: D8476.diff
Wed, Mar 19, 10:14 PM
Subscribers

Details

Summary

Ref T2222.

  • Removes DifferentialTasksAttacher, which has had no callsites for a very long time.
  • Moves differential.getrevisioncomments off DifferentialCommentQuery.
  • Moves Releeph churn field off DifferentialCommentQuery.
  • Removes dead code in DifferentialRevisionViewController.
  • Removes DifferentialException (no references).
  • Removes DifferentialRevision->loadComments() (no callsites).
  • Removes DifferentialRevision->loadReviewedBy() (all callsites updated).
  • Removes DifferentialCommentQuery (all callsites updated).
Test Plan

Mostly a lot of grep.

Diff Detail

Repository
rP Phabricator
Branch
dx28
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/infrastructure/storage/lisk/PhabricatorLiskDAO.php:191XHP16TODO Comment
Unit
Tests Passed

Event Timeline

btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 10 2014, 6:48 PM
epriestley updated this revision to Diff 20129.

Closed by commit rP592591e71538 (authored by @epriestley).