Page MenuHomePhabricator

Clean up various pieces of dead/obsolete Differential code
ClosedPublic

Authored by epriestley on Mar 9 2014, 8:49 PM.
Tags
None
Referenced Files
F17868713: D8476.id20129.diff
Mon, Jul 28, 8:53 AM
F17845300: D8476.diff
Sun, Jul 27, 3:17 AM
Unknown Object (File)
Jul 4 2025, 3:52 PM
Unknown Object (File)
Jun 17 2025, 9:01 AM
Unknown Object (File)
Jun 9 2025, 2:03 AM
Unknown Object (File)
May 31 2025, 2:13 PM
Unknown Object (File)
May 8 2025, 12:01 PM
Unknown Object (File)
May 7 2025, 3:05 PM
Subscribers

Details

Summary

Ref T2222.

  • Removes DifferentialTasksAttacher, which has had no callsites for a very long time.
  • Moves differential.getrevisioncomments off DifferentialCommentQuery.
  • Moves Releeph churn field off DifferentialCommentQuery.
  • Removes dead code in DifferentialRevisionViewController.
  • Removes DifferentialException (no references).
  • Removes DifferentialRevision->loadComments() (no callsites).
  • Removes DifferentialRevision->loadReviewedBy() (all callsites updated).
  • Removes DifferentialCommentQuery (all callsites updated).
Test Plan

Mostly a lot of grep.

Diff Detail

Repository
rP Phabricator
Branch
dx28
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/infrastructure/storage/lisk/PhabricatorLiskDAO.php:191XHP16TODO Comment
Unit
Tests Passed

Event Timeline

btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 10 2014, 6:48 PM
epriestley updated this revision to Diff 20129.

Closed by commit rP592591e71538 (authored by @epriestley).