Page MenuHomePhabricator
Differential D8475

Move lint/unit test warning code forward to Transactions
ClosedPublic
Actions

Authored by epriestley on Mar 9 2014, 8:19 PM.
Tags
None
Referenced Files
F15512683: D8475.id.diff
Thu, Apr 17, 12:49 PM
F15512119: D8475.id20128.diff
Thu, Apr 17, 8:25 AM
F15510213: D8475.diff
Wed, Apr 16, 6:57 PM
F15469569: D8475.diff
Fri, Apr 4, 2:48 PM
F15429562: D8475.id20087.diff
Mar 24 2025, 2:57 AM
F15416149: D8475.id20128.diff
Mar 20 2025, 9:37 AM
Unknown Object (File)
Feb 24 2025, 11:35 AM
Unknown Object (File)
Feb 14 2025, 10:54 PM
View All Files
Subscribers
aran

Details

Reviewers
btrahan
Maniphest Tasks
T2222: Implement ApplicationTransactions in Differential
Commits
Restricted Diffusion Commit
rPa49fec39be84: Move lint/unit test warning code forward to Transactions
Summary

Ref T2222. Makes the "lint/unit errors" warnings work again.

Test Plan

Viewed some revisions with and without these warnings.

Diff Detail

Repository
rP Phabricator
Branch
dx27
Lint
Lint Passed
Unit
Tests Passed

Event Timeline

btrahan accepted this revision.Mar 10 2014, 6:43 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 10 2014, 6:43 PM
epriestley closed this revision.Mar 11 2014, 8:06 PM
epriestley updated this revision to Diff 20128.

Closed by commit rPa49fec39be84 (authored by @epriestley).

Revision Contents
Changeset List

PathSize
resources/
celerity/
32 lines
1 line
src/
2 lines
applications/
differential/
controller/
13 lines
customfield/
6 lines
21 lines
20 lines
field/
specification/
view/
33 lines
webroot/
rsrc/
js/
application/
differential/

Diff 20087

View Options

resources/celerity/map.php

Loading...
View Options

resources/celerity/packages.php

Loading...
View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/differential/controller/DifferentialRevisionViewController.php

Loading...
View Options

src/applications/differential/customfield/DifferentialCustomField.php

Loading...
View Options

src/applications/differential/customfield/DifferentialLintField.php

Loading...
View Options

src/applications/differential/customfield/DifferentialUnitField.php

Loading...
View Options

src/applications/differential/field/specification/DifferentialLintFieldSpecification.php

Loading...
View Options

src/applications/differential/field/specification/DifferentialUnitFieldSpecification.php

Loading...
View Options

src/applications/differential/view/DifferentialAddCommentView.php

Loading...
View Options

webroot/rsrc/js/application/differential/behavior-accept-with-errors.js

Loading...
Phabricator · Built by Phacility