Page MenuHomePhabricator

Fix three minor edge case behaviors in Conpherence
ClosedPublic

Authored by epriestley on Mar 9 2014, 3:41 PM.
Tags
None
Referenced Files
F13998286: D8467.diff
Thu, Oct 24, 8:37 AM
F13995308: D8467.id20104.diff
Wed, Oct 23, 12:04 PM
F13983092: D8467.diff
Sun, Oct 20, 4:06 AM
Unknown Object (File)
Oct 10 2024, 8:55 PM
Unknown Object (File)
Oct 3 2024, 12:34 PM
Unknown Object (File)
Sep 20 2024, 1:31 AM
Unknown Object (File)
Sep 3 2024, 5:38 AM
Unknown Object (File)
Aug 31 2024, 5:34 AM
Subscribers
Tokens
"Piece of Eight" token, awarded by btrahan.

Details

Summary

Couple of tweaks:

  • If a conpherence has no participants, we fail to attachParticipants(). This can happen if you leave a Conpherence as the last participant, then visit the URI again explicitly.
  • If you can't load any transactions (usually, because you don't have permission to view a thread's transactions), we try to attach null instead of array(). This can happen if you attempt to view a thread you don't have permission to see. A more general fix would be to tweak the load/filtering order, but I'm leaving that for another time since it's more involved and only gives us a small performance gain in unusual sitautions.
  • initializeNewThread() should be declared static.
Test Plan
  • Viewed a thread with no participants, got proper policy error.
  • Viewed a thread I couldn't see, got proper policy error.
  • Grepped for initializeNewThread().

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 10 2014, 5:04 PM
epriestley updated this revision to Diff 20104.

Closed by commit rP042ab0ad9d03 (authored by @epriestley).