Paths

Table of Contentst

Differential D8462

Utilize `assertFalse` and `assertTrue` methods.
ClosedPublic
Actions

Authored by joshuaspence on Mar 9 2014, 2:16 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rPHU4c7b876e5ad8: Utilize `assertFalse` and `assertTrue` methods.

Summary

Ref D8460.

Use $this->assertFalse(...) and $this->assertTrue(...) instead of $this->assertEqual(false, ...) and $this->assertEqual(true, ...) respectively.

Test Plan

arc unit

Diff Detail

Repository

rPHU libphutil

Branch

assert-true_false

Lint

Lint Passed

Unit

Tests Passed

Event Timeline

Closed by commit rPHU4c7b876e5ad8 (authored by @joshuaspence, committed by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

cache/

__tests__/

PhutilKeyValueCacheTestCase.php

3 lines

channel/

__tests__/

PhutilPHPObjectProtocolChannelTestCase.php

10 lines

error/

__tests__/

PhutilErrorHandlerTestCase.php

8 lines

PhutilOpaqueEnvelopeTestCase.php

20 lines

filesystem/

__tests__/

FileFinderTestCase.php

60 lines

FilesystemTestCase.php

14 lines

PhutilDeferredLogTestCase.php

4 lines

PhutilFileLockTestCase.php

52 lines

linesofalarge/

__tests__/

LinesOfALargeExecFutureTestCase.php

2 lines

LinesOfALargeFileTestCase.php

2 lines

future/

exec/

__tests__/

ExecFutureTestCase.php

10 lines

infrastructure/

__tests__/

PhutilInfrastructureTestCase.php

2 lines

internationalization/

__tests__/

PhutilTranslatorTestCase.php

4 lines

moduleutils/

__tests__/

PhutilExtensionsTestCase.php

6 lines

parser/

__tests__/

PhutilBugtraqParserTestCase.php

8 lines

PhutilParserGeneratorTestCase.php

18 lines

PhutilSimpleOptionsTestCase.php

3 lines

PhutilTypeSpecTestCase.php

14 lines

argument/

__tests__/

PhutilArgumentParserTestCase.php

28 lines

xhpast/

__tests__/

PHPASTParserTestCase.php

6 lines

utils/

__tests__/

AbstractDirectedGraphTestCase.php

3 lines

PhutilLunarPhaseTestCase.php

56 lines

PhutilUTF8TestCase.php

10 lines

PhutilUtilsTestCase.php

23 lines

xsprintf/

__tests__/

PhutilcsprintfTestCase.php

28 lines

Diff 20068

View Options

src/cache/tests/PhutilKeyValueCacheTestCase.php

View Options

src/channel/tests/PhutilPHPObjectProtocolChannelTestCase.php

View Options

src/error/tests/PhutilErrorHandlerTestCase.php

View Options

src/error/tests/PhutilOpaqueEnvelopeTestCase.php

View Options

src/filesystem/tests/FileFinderTestCase.php

View Options

src/filesystem/tests/FilesystemTestCase.php

View Options

src/filesystem/tests/PhutilDeferredLogTestCase.php

View Options

src/filesystem/tests/PhutilFileLockTestCase.php

View Options

src/filesystem/linesofalarge/tests/LinesOfALargeExecFutureTestCase.php

View Options

src/filesystem/linesofalarge/tests/LinesOfALargeFileTestCase.php

View Options

src/future/exec/tests/ExecFutureTestCase.php

View Options

src/infrastructure/tests/PhutilInfrastructureTestCase.php

View Options

src/internationalization/tests/PhutilTranslatorTestCase.php

View Options

src/moduleutils/tests/PhutilExtensionsTestCase.php

View Options

src/parser/tests/PhutilBugtraqParserTestCase.php

View Options

src/parser/tests/PhutilParserGeneratorTestCase.php

View Options

src/parser/tests/PhutilSimpleOptionsTestCase.php

View Options

src/parser/tests/PhutilTypeSpecTestCase.php

View Options

src/parser/argument/tests/PhutilArgumentParserTestCase.php

View Options

src/parser/xhpast/tests/PHPASTParserTestCase.php

View Options

src/utils/tests/AbstractDirectedGraphTestCase.php

View Options

src/utils/tests/PhutilLunarPhaseTestCase.php

View Options

src/utils/tests/PhutilUTF8TestCase.php

View Options

src/utils/tests/PhutilUtilsTestCase.php

View Options

src/xsprintf/tests/PhutilcsprintfTestCase.php

Utilize `assertFalse` and `assertTrue` methods.ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 20068

src/cache/__tests__/PhutilKeyValueCacheTestCase.php

src/channel/__tests__/PhutilPHPObjectProtocolChannelTestCase.php

src/error/__tests__/PhutilErrorHandlerTestCase.php

src/error/__tests__/PhutilOpaqueEnvelopeTestCase.php

src/filesystem/__tests__/FileFinderTestCase.php

src/filesystem/__tests__/FilesystemTestCase.php

src/filesystem/__tests__/PhutilDeferredLogTestCase.php

src/filesystem/__tests__/PhutilFileLockTestCase.php

src/filesystem/linesofalarge/__tests__/LinesOfALargeExecFutureTestCase.php

src/filesystem/linesofalarge/__tests__/LinesOfALargeFileTestCase.php

src/future/exec/__tests__/ExecFutureTestCase.php

src/infrastructure/__tests__/PhutilInfrastructureTestCase.php

src/internationalization/__tests__/PhutilTranslatorTestCase.php

src/moduleutils/__tests__/PhutilExtensionsTestCase.php

src/parser/__tests__/PhutilBugtraqParserTestCase.php

src/parser/__tests__/PhutilParserGeneratorTestCase.php

src/parser/__tests__/PhutilSimpleOptionsTestCase.php

src/parser/__tests__/PhutilTypeSpecTestCase.php

src/parser/argument/__tests__/PhutilArgumentParserTestCase.php

src/parser/xhpast/__tests__/PHPASTParserTestCase.php

src/utils/__tests__/AbstractDirectedGraphTestCase.php

src/utils/__tests__/PhutilLunarPhaseTestCase.php

src/utils/__tests__/PhutilUTF8TestCase.php

src/utils/__tests__/PhutilUtilsTestCase.php

src/xsprintf/__tests__/PhutilcsprintfTestCase.php

Utilize `assertFalse` and `assertTrue` methods.
ClosedPublic
Actions

Revision Contents
Changeset List

src/cache/tests/PhutilKeyValueCacheTestCase.php

src/channel/tests/PhutilPHPObjectProtocolChannelTestCase.php

src/error/tests/PhutilErrorHandlerTestCase.php

src/error/tests/PhutilOpaqueEnvelopeTestCase.php

src/filesystem/tests/FileFinderTestCase.php

src/filesystem/tests/FilesystemTestCase.php

src/filesystem/tests/PhutilDeferredLogTestCase.php

src/filesystem/tests/PhutilFileLockTestCase.php

src/filesystem/linesofalarge/tests/LinesOfALargeExecFutureTestCase.php

src/filesystem/linesofalarge/tests/LinesOfALargeFileTestCase.php

src/future/exec/tests/ExecFutureTestCase.php

src/infrastructure/tests/PhutilInfrastructureTestCase.php

src/internationalization/tests/PhutilTranslatorTestCase.php

src/moduleutils/tests/PhutilExtensionsTestCase.php

src/parser/tests/PhutilBugtraqParserTestCase.php

src/parser/tests/PhutilParserGeneratorTestCase.php

src/parser/tests/PhutilSimpleOptionsTestCase.php

src/parser/tests/PhutilTypeSpecTestCase.php

src/parser/argument/tests/PhutilArgumentParserTestCase.php

src/parser/xhpast/tests/PHPASTParserTestCase.php

src/utils/tests/AbstractDirectedGraphTestCase.php

src/utils/tests/PhutilLunarPhaseTestCase.php

src/utils/tests/PhutilUTF8TestCase.php

src/utils/tests/PhutilUtilsTestCase.php

src/xsprintf/tests/PhutilcsprintfTestCase.php