Perform derived index updates in TransactionEditor
ClosedPublic
Actions

Authored by epriestley on Mar 8 2014, 8:13 PM.

Tags

None

Referenced Files

	F13157168: D8455.diff
	Sun, May 5, 9:32 AM

	Unknown Object (File)
	Tue, Apr 30, 11:16 PM

	Unknown Object (File)
	Sat, Apr 27, 9:43 PM

	Unknown Object (File)
	Sat, Apr 27, 9:33 PM

	Unknown Object (File)
	Wed, Apr 24, 11:15 PM

	Unknown Object (File)
	Sat, Apr 20, 6:36 PM

	Unknown Object (File)
	Wed, Apr 17, 2:43 PM

	Unknown Object (File)
	Tue, Apr 16, 10:55 AM

View All Files

Subscribers

aran

Details

Reviewers

btrahan

Maniphest Tasks

T2222: Implement ApplicationTransactions in Differential

Commits

Restricted Diffusion Commit
rPc68703fbcb27: Perform derived index updates in TransactionEditor

Summary

Ref T2222. We have two tables (one for hashes; one for paths) which were unevenly updated before. Now, update them consistently in the TransactionEditor.

Test Plan

Created a revision, saw it populate this information.

Diff Detail

Repository

rP Phabricator

Branch

dx16

Lint

Lint Passed

Severity	Location	Code	Message
Advice	src/applications/differential/editor/DifferentialTransactionEditor.php:1330	XHP16	TODO Comment

Unit

Tests Passed

Event Timeline

btrahan accepted this revision.Mar 10 2014, 4:51 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Mar 10 2014, 4:51 PM

Closed by commit rPc68703fbcb27 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

editor/

DifferentialRevisionEditor.php

236 lines

DifferentialTransactionEditor.php

241 lines

Diff 20060

View Options

src/applications/differential/editor/DifferentialRevisionEditor.php