Paths

Table of Contentst

Differential D8444

Move Differential commit message parsing to a separate, tested class
ClosedPublic
Actions

Authored by epriestley on Mar 7 2014, 10:22 PM.

Tags

None

Referenced Files

	F14833505: D8444.id20046.diff
	Thu, Jan 30, 10:48 AM

	Unknown Object (File)
	Tue, Jan 28, 6:29 AM

	Unknown Object (File)
	Fri, Jan 24, 8:32 PM

	Unknown Object (File)
	Fri, Jan 24, 7:30 PM

	Unknown Object (File)
	Tue, Jan 21, 11:38 AM

	Unknown Object (File)
	Sat, Jan 18, 6:35 PM

	Unknown Object (File)
	Sat, Jan 18, 4:51 AM

	Unknown Object (File)
	Sun, Jan 12, 6:28 PM

Subscribers

Details

Reviewers

Maniphest Tasks

T2222: Implement ApplicationTransactions in Differential

Commits

Restricted Diffusion Commit
rPaff34077c52c: Move Differential commit message parsing to a separate, tested class

Summary

Ref T2222. We have a hunk of logic that purely does text parsing here; separate it and get coverage on it.

Test Plan

Ran new unit tests.
Used differential.parsecommitmessage.

Diff Detail

Repository

Branch

dx8

Lint

Lint Warnings

Severity	Location	Code	Message
Warning	src/applications/differential/parser/__tests__/messages/long-title.txt:1	TXT3	Line Too Long
Warning	src/applications/differential/parser/__tests__/messages/long-title.txt:7	TXT3	Line Too Long
Warning	src/applications/differential/parser/__tests__/messages/long-title.txt:8	TXT3	Line Too Long

Unit

Tests Passed

Event Timeline

btrahan accepted this revision.Mar 8 2014, 12:41 AM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Mar 8 2014, 12:41 AM

Closed by commit rPaff34077c52c (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

3 lines

applications/

differential/

conduit/

ConduitAPI_differential_parsecommitmessage_Method.php

105 lines

parser/

DifferentialCommitMessageParser.php

210 lines

__tests__/

DifferentialCommitMessageParserTestCase.php

65 lines

messages/

double-field.txt

17 lines

11 lines

multi-label.txt

15 lines

24 lines

12 lines

9 lines

Diff 20039

src/__phutil_library_map__.php

Loading...

src/applications/differential/conduit/ConduitAPI_differential_parsecommitmessage_Method.php

Loading...

src/applications/differential/parser/DifferentialCommitMessageParser.php

Loading...

src/applications/differential/parser/tests/DifferentialCommitMessageParserTestCase.php

Loading...

src/applications/differential/parser/tests/messages/double-field.txt

Loading...

src/applications/differential/parser/tests/messages/long-title.txt

Loading...

src/applications/differential/parser/tests/messages/multi-label.txt

Loading...

src/applications/differential/parser/tests/messages/normal.txt

Loading...

src/applications/differential/parser/tests/messages/simple.txt

Loading...

src/applications/differential/parser/tests/messages/trivial.txt

Loading...