Page MenuHomePhabricator
Differential D8435

Add assertions to every test in libphutil/
ClosedPublic
Actions

Authored by epriestley on Mar 7 2014, 2:16 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 19, 6:18 PM
Unknown Object (File)
Sat, Nov 16, 11:57 AM
Unknown Object (File)
Tue, Nov 12, 2:29 PM
Unknown Object (File)
Mon, Nov 11, 12:55 PM
Unknown Object (File)
Fri, Nov 8, 8:02 AM
Unknown Object (File)
Mon, Nov 4, 5:37 PM
Unknown Object (File)
Tue, Oct 29, 10:43 PM
Unknown Object (File)
Thu, Oct 24, 9:30 PM
View All Files
Subscribers
aran

Details

Reviewers
leebyron
btrahan
Maniphest Tasks
T4570: ArcanistLinterTestCase::executeTestsInDirectory() should fail when it finds 0 tests.
Commits
rPHU01e849c9bafc: Add assertions to every test in libphutil/
Summary

Ref T4570. Add an assertion to all tests which pass by not exploding, so we can fail tests which make no assertions.

Test Plan

arc unit --everything with the test engine set to fail on no assertions.

Diff Detail

Repository
rPHU libphutil
Branch
noassert1
Lint
Lint Passed
Unit
Tests Passed

Event Timeline

btrahan accepted this revision.Mar 7 2014, 5:48 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 7 2014, 5:48 PM
epriestley closed this revision.Mar 7 2014, 6:03 PM

Closed by commit rPHU01e849c9bafc (authored by @epriestley).

Revision Contents
Changeset List

PathSize
src/
channel/
__tests__/
2 lines
infrastructure/
__tests__/
1 line
parser/
__tests__/
2 lines
2 lines
utils/
__tests__/
2 lines

Diff 20019

View Options

src/channel/__tests__/PhutilPHPObjectProtocolChannelTestCase.php

Loading...
View Options

src/infrastructure/__tests__/PhutilInfrastructureTestCase.php

Loading...
View Options

src/parser/__tests__/PhutilParserGeneratorTestCase.php

Loading...
View Options

src/parser/__tests__/PhutilTypeSpecTestCase.php

Loading...
View Options

src/utils/__tests__/PhutilUTF8TestCase.php

Loading...
Phabricator · Built by Phacility