Paths

Table of Contentst

Add assertions to every test in libphutil/
ClosedPublic
Actions

Authored by epriestley on Mar 7 2014, 2:16 PM.

Tags

None

Referenced Files

	F14043994: D8435.diff
	Tue, Nov 12, 2:29 PM

	F14040742: D8435.diff
	Mon, Nov 11, 12:55 PM

	F14027594: D8435.diff
	Fri, Nov 8, 8:02 AM

	F14017481: D8435.diff
	Mon, Nov 4, 5:37 PM

	F14008491: D8435.id.diff
	Tue, Oct 29, 10:43 PM

	F14000411: D8435.id20019.diff
	Thu, Oct 24, 9:30 PM

	F13986888: D8435.id.diff
	Mon, Oct 21, 6:09 AM

	F13965884: D8435.diff
	Wed, Oct 16, 4:51 AM

View All Files

Subscribers

aran

Details

Reviewers

leebyron
btrahan

Maniphest Tasks

T4570: ArcanistLinterTestCase::executeTestsInDirectory() should fail when it finds 0 tests.

Commits

rPHU01e849c9bafc: Add assertions to every test in libphutil/

Summary

Ref T4570. Add an assertion to all tests which pass by not exploding, so we can fail tests which make no assertions.

Test Plan

arc unit --everything with the test engine set to fail on no assertions.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

btrahan accepted this revision.Mar 7 2014, 5:48 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Mar 7 2014, 5:48 PM

Closed by commit rPHU01e849c9bafc (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

channel/

__tests__/

PhutilPHPObjectProtocolChannelTestCase.php

2 lines

infrastructure/

__tests__/

PhutilInfrastructureTestCase.php

1 line

parser/

__tests__/

PhutilParserGeneratorTestCase.php

2 lines

PhutilTypeSpecTestCase.php

2 lines

utils/

__tests__/

PhutilUTF8TestCase.php

2 lines

Diff 20030

View Options

src/channel/tests/PhutilPHPObjectProtocolChannelTestCase.php

View Options

src/infrastructure/tests/PhutilInfrastructureTestCase.php

View Options

src/parser/tests/PhutilParserGeneratorTestCase.php

View Options

src/parser/tests/PhutilTypeSpecTestCase.php

View Options

src/utils/tests/PhutilUTF8TestCase.php

Add assertions to every test in libphutil/ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 20030

src/channel/__tests__/PhutilPHPObjectProtocolChannelTestCase.php

src/infrastructure/__tests__/PhutilInfrastructureTestCase.php

src/parser/__tests__/PhutilParserGeneratorTestCase.php

src/parser/__tests__/PhutilTypeSpecTestCase.php

src/utils/__tests__/PhutilUTF8TestCase.php

Add assertions to every test in libphutil/
ClosedPublic
Actions

Revision Contents
Changeset List

src/channel/tests/PhutilPHPObjectProtocolChannelTestCase.php

src/infrastructure/tests/PhutilInfrastructureTestCase.php

src/parser/tests/PhutilParserGeneratorTestCase.php

src/parser/tests/PhutilTypeSpecTestCase.php

src/utils/tests/PhutilUTF8TestCase.php