Page MenuHomePhabricator

Add assertions to every test in libphutil/
ClosedPublic

Authored by epriestley on Mar 7 2014, 2:16 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 19, 6:18 PM
Unknown Object (File)
Sat, Nov 16, 11:57 AM
Unknown Object (File)
Tue, Nov 12, 2:29 PM
Unknown Object (File)
Mon, Nov 11, 12:55 PM
Unknown Object (File)
Fri, Nov 8, 8:02 AM
Unknown Object (File)
Mon, Nov 4, 5:37 PM
Unknown Object (File)
Tue, Oct 29, 10:43 PM
Unknown Object (File)
Thu, Oct 24, 9:30 PM
Subscribers

Details

Summary

Ref T4570. Add an assertion to all tests which pass by not exploding, so we can fail tests which make no assertions.

Test Plan

arc unit --everything with the test engine set to fail on no assertions.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 7 2014, 5:48 PM