Page MenuHomePhabricator
Differential D8425

Update `differential.close` to use DifferentialTransactionEditor
ClosedPublic
Actions

Authored by epriestley on Mar 6 2014, 4:33 PM.
Tags
None
Referenced Files
F15331938: D8425.diff
Fri, Mar 7, 3:32 PM
Unknown Object (File)
Sat, Feb 22, 11:24 PM
Unknown Object (File)
Sun, Feb 9, 11:46 AM
Unknown Object (File)
Sun, Feb 9, 11:46 AM
Unknown Object (File)
Sun, Feb 9, 11:46 AM
Unknown Object (File)
Sun, Feb 9, 11:46 AM
Unknown Object (File)
Jan 28 2025, 7:01 AM
Unknown Object (File)
Jan 25 2025, 8:31 AM
View All Files
Subscribers
aran

Details

Reviewers
btrahan
Maniphest Tasks
T2222: Implement ApplicationTransactions in Differential
Commits
Restricted Diffusion Commit
rP75514cc0f713: Update `differential.close` to use DifferentialTransactionEditor
Summary

Ref T2222. Straightforward update to new stuff.

Test Plan
  • Tried to close an uncloseable revision.
  • Closed a closeable revision.

Diff Detail

Repository
rP Phabricator
Branch
dx2
Lint
Lint Passed
Unit
Tests Passed

Event Timeline

btrahan accepted this revision.Mar 6 2014, 10:43 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 6 2014, 10:43 PM
epriestley closed this revision.Mar 7 2014, 4:10 PM

Closed by commit rP75514cc0f713 (authored by @epriestley).

Revision Contents
Changeset List

PathSize
src/
applications/
differential/
conduit/
3 lines
37 lines
transactions/
editor/
10 lines

Diff 20003

View Options

src/applications/differential/conduit/ConduitAPI_differential_Method.php

Loading...
View Options

src/applications/differential/conduit/ConduitAPI_differential_close_Method.php

Loading...
View Options

src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php

Loading...
Phabricator · Built by Phacility