Make updates of rejected revisions behave correctly again
ClosedPublic
Actions

Authored by epriestley on Mar 5 2014, 1:55 AM.

Tags

None

Referenced Files

	F15464681: D8402.id19956.diff
	Wed, Apr 2, 12:16 PM

	F15452280: D8402.id19969.diff
	Sat, Mar 29, 3:30 AM

	F15445544: D8402.diff
	Thu, Mar 27, 2:30 PM

	F15429812: D8402.id19969.diff
	Mon, Mar 24, 4:24 AM

	F15429808: D8402.diff
	Mon, Mar 24, 4:23 AM

	F15386616: D8402.id19969.diff
	Sat, Mar 15, 12:57 AM

	F15290391: D8402.id.diff
	Mar 4 2025, 11:15 PM

	F15283138: D8402.id19969.diff
	Mar 4 2025, 5:31 AM

View All Files

Subscribers

aran

Details

Reviewers

btrahan

Maniphest Tasks

T4481: Differential Update Feedback / Rough Edges / Status
T2222: Implement ApplicationTransactions in Differential

Commits

Restricted Diffusion Commit
rP9da6ec208111: Make updates of rejected revisions behave correctly again

Summary

Ref T2222. Ref T4481. Specifically:

When a revision is updated, change all "Reject" reviewers to "Reject Prior".
Change status to "Needs Review".
Update the state logic to account for this properly.

Test Plan

Created a revision as user A, with B as a reviewer.
Rejected as B.
Updated the revision as A.
Saw revision in "needs review" state, with B as a "Rejected Prior" reviewer.

Diff Detail

Repository

rP Phabricator

Branch

statetrans2

Lint

Lint Passed

Severity	Location	Code	Message
Advice	src/applications/differential/editor/DifferentialTransactionEditor.php:227	XHP16	TODO Comment

Unit

Tests Passed

Event Timeline

btrahan accepted this revision.Mar 5 2014, 6:35 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Mar 5 2014, 6:35 PM

Closed by commit rP9da6ec208111 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

constants/

DifferentialReviewerStatus.php

9 lines

editor/

DifferentialTransactionEditor.php

45 lines

view/

DifferentialReviewersView.php

12 lines

Diff 19956

View Options

src/applications/differential/constants/DifferentialReviewerStatus.php

View Options

src/applications/differential/editor/DifferentialTransactionEditor.php

View Options

src/applications/differential/view/DifferentialReviewersView.php

Make updates of rejected revisions behave correctly againClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 19956

src/applications/differential/constants/DifferentialReviewerStatus.php

src/applications/differential/editor/DifferentialTransactionEditor.php

src/applications/differential/view/DifferentialReviewersView.php

Make updates of rejected revisions behave correctly again
ClosedPublic
Actions

Revision Contents
Changeset List