Paths

Table of Contentst

Add "Changes Planned" and "In Preparation" states for revisions
ClosedPublic
Actions

Authored by epriestley on Mar 5 2014, 1:12 AM.

Tags

None

Referenced Files

	F14498776: D8400.diff
	Fri, Jan 3, 9:06 PM

	Unknown Object (File)
	Sun, Dec 15, 5:58 PM

	Unknown Object (File)
	Sun, Dec 15, 8:00 AM

	Unknown Object (File)
	Wed, Dec 11, 10:07 PM

	Unknown Object (File)
	Wed, Dec 11, 3:44 PM

	Unknown Object (File)
	Tue, Dec 10, 3:49 AM

	Unknown Object (File)
	Tue, Dec 10, 3:48 AM

	Unknown Object (File)
	Tue, Dec 10, 3:47 AM

View All Files

Subscribers

aran

• weijingjaylin

Details

Reviewers

btrahan

Maniphest Tasks

T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential
T2222: Implement ApplicationTransactions in Differential

Commits

rARC7b6b24154b71: Add "Changes Planned" and "In Preparation" states for revisions

Summary

Ref T2222. Discussion in T4481. Ref T2543.

Primarily, this will let me fix some of the rough edges that came out of ApplicationTransactions and state-based transitions.

I'm also adding a constant for T2543 while I'm in here.

Test Plan

Used grep to look for any weird special behavior, didn't see any.

Diff Detail

Repository

rARC Arcanist

Branch

arcnew

Lint

Lint Passed

Unit

No Test Coverage

Event Timeline

btrahan accepted this revision.Mar 5 2014, 6:31 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Mar 5 2014, 6:31 PM

Closed by commit rARC7b6b24154b71 (authored by @epriestley).

what does "in preparation" mean? how to move it to "needs review" status?

Revision Contents
Changeset List

Path

Size

src/

differential/

constants/

ArcanistDifferentialRevisionStatus.php

16 lines

Diff 19954

View Options

src/differential/constants/ArcanistDifferentialRevisionStatus.php

Add "Changes Planned" and "In Preparation" states for revisionsClosedPublicActions