Page MenuHomePhabricator

Maniphest Tasks + Project Boards - some polish
ClosedPublic

Authored by btrahan on Mar 5 2014, 12:52 AM.
Tags
None
Referenced Files
F15505120: D8399.diff
Tue, Apr 15, 12:00 AM
F15482744: D8399.diff
Wed, Apr 9, 7:38 AM
F15451273: D8399.id19952.diff
Fri, Mar 28, 9:09 PM
F15435990: D8399.id.diff
Tue, Mar 25, 11:16 AM
F15435989: D8399.id19952.diff
Tue, Mar 25, 11:16 AM
F15390897: D8399.id.diff
Mar 15 2025, 7:15 AM
Unknown Object (File)
Mar 2 2025, 6:54 AM
Unknown Object (File)
Feb 23 2025, 4:49 PM

Details

Summary

Fixes T4550 by changing supportsFeed to shouldPublishFeedStory, so things can be more granular like that are with mail. Attempts to fix things generally too, filtering out xactions that have no business in feed, etc.

Also return an updated Task HTML representation on drag and drop moves, etc. This is important so if the priority changes you can see it reflected in the UI.

Test Plan

dragged tasks around. observed no feed stories on subpriority drags. observed feed stories and updated color bars on stories that changed priority

Diff Detail

Repository
rP Phabricator
Branch
oardsauce5
Lint
Lint Passed
Unit
Tests Passed

Event Timeline

epriestley edited edge metadata.

Looks great to me.

This revision is now accepted and ready to land.Mar 5 2014, 12:54 AM