Page MenuHomePhabricator

Make "EditPro" controller work with diff updates
ClosedPublic

Authored by epriestley on Feb 28 2014, 11:12 PM.
Tags
None
Referenced Files
F13149914: D8376.diff
Sat, May 4, 12:16 PM
Unknown Object (File)
Fri, May 3, 8:45 AM
Unknown Object (File)
Sun, Apr 28, 5:31 AM
Unknown Object (File)
Sun, Apr 28, 5:31 AM
Unknown Object (File)
Sun, Apr 28, 5:31 AM
Unknown Object (File)
Sun, Apr 28, 5:31 AM
Unknown Object (File)
Sun, Apr 28, 5:31 AM
Unknown Object (File)
Sun, Apr 28, 5:30 AM
Subscribers

Details

Summary

Ref T2222. Make the "EditPro" controller accommodate diff updates, and support the transaction type. This one is pretty straightforward.

Also make revisionPHID in the comments table nullable to fix the "Edit" action.

Test Plan
  • Created new revision.
  • Updated revision.
  • Tried to do some invalid stuff.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley updated this revision to Unknown Object (????).Feb 28 2014, 11:13 PM
  • Hold the /edit/ -> /editpro/ change.
epriestley updated this revision to Unknown Object (????).Feb 28 2014, 11:14 PM
  • Remove unused property.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 1 2014, 12:30 AM