Symbol import: preemptively error on non-utf8 symbols
ClosedPublic
Actions

Authored by avivey on Feb 26 2014, 8:35 PM.

Tags

None

Referenced Files

	F15467714: D8353.id19853.diff
	Thu, Apr 3, 5:32 PM

	F15459755: D8353.id19853.diff
	Mon, Mar 31, 3:56 PM

	F15457031: D8353.id19853.diff
	Sun, Mar 30, 1:52 PM

	F15451320: D8353.id.diff
	Fri, Mar 28, 9:26 PM

	F15445819: D8353.id19853.diff
	Thu, Mar 27, 4:10 PM

	F15444936: D8353.diff
	Thu, Mar 27, 11:56 AM

	F15441926: D8353.id.diff
	Wed, Mar 26, 8:37 PM

	F15434788: D8353.id.diff
	Tue, Mar 25, 5:23 AM

Subscribers

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

Restricted Diffusion Commit
rP361e49dd6799: Symbol import: preemptively error on non-utf8 symbols

Summary

Put a test somewhere we can --ignore it.

Also fix path tests.

Test Plan

insert good/bad values at various positions.

Diff Detail

Repository

rP Phabricator

Branch

master

Lint

Lint Passed

Unit

No Test Coverage

Event Timeline

The only reason I actually got a non-utf symbol was because of a ctags bug; But seeing as that bug is open since 2007...

epriestley accepted this revision.Feb 26 2014, 8:41 PM

Closed by commit rP361e49dd6799 (authored by @avivey, committed by @epriestley).

Revision Contents
Changeset List

Path

Size

scripts/

symbols/

import_project_symbols.php

45 lines

Diff 19852

View Options

scripts/symbols/import_project_symbols.php

Symbol import: preemptively error on non-utf8 symbolsClosedPublicActions