Symbol import: preemptively error on non-utf8 symbols
ClosedPublic
Actions

Authored by avivey on Feb 26 2014, 8:35 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, May 2, 1:41 PM

	Unknown Object (File)
	Sun, Apr 28, 5:25 AM

	Unknown Object (File)
	Sun, Apr 28, 5:25 AM

	Unknown Object (File)
	Sat, Apr 27, 12:03 PM

	Unknown Object (File)
	Sun, Apr 14, 8:23 AM

	Unknown Object (File)
	Wed, Apr 10, 12:02 AM

	Unknown Object (File)
	Sun, Apr 7, 9:38 PM

	Unknown Object (File)
	Mar 31 2024, 6:01 AM

Subscribers

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

Restricted Diffusion Commit
rP361e49dd6799: Symbol import: preemptively error on non-utf8 symbols

Summary

Put a test somewhere we can --ignore it.

Also fix path tests.

Test Plan

insert good/bad values at various positions.

Diff Detail

Repository

rP Phabricator

Branch

master

Lint

Lint Passed

Unit

No Test Coverage

Event Timeline

The only reason I actually got a non-utf symbol was because of a ctags bug; But seeing as that bug is open since 2007...

epriestley accepted this revision.Feb 26 2014, 8:41 PM

Closed by commit rP361e49dd6799 (authored by @avivey, committed by @epriestley).

Revision Contents
Changeset List

Path

Size

scripts/

symbols/

import_project_symbols.php

45 lines

Diff 19852

View Options

scripts/symbols/import_project_symbols.php

Symbol import: preemptively error on non-utf8 symbolsClosedPublicActions