Symbol import: preemptively error on non-utf8 symbols
ClosedPublic
Actions

Authored by avivey on Feb 26 2014, 8:35 PM.

Tags

None

Referenced Files

	F19080005: D8353.id.diff
	Dec 1 2025, 11:46 PM

	F18842108: D8353.id19853.diff
	Oct 28 2025, 1:22 PM

	F18837449: D8353.id19852.diff
	Oct 27 2025, 5:28 AM

	F18748375: D8353.id.diff
	Oct 3 2025, 9:02 PM

	F18579356: D8353.diff
	Sep 11 2025, 12:28 AM

	F18235121: D8353.id.diff
	Aug 20 2025, 7:07 PM

	F18218363: D8353.diff
	Aug 19 2025, 10:08 AM

	Unknown Object (File)
	Jun 9 2025, 1:59 AM

Subscribers

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

Restricted Diffusion Commit
rP361e49dd6799: Symbol import: preemptively error on non-utf8 symbols

Summary

Put a test somewhere we can --ignore it.

Also fix path tests.

Test Plan

insert good/bad values at various positions.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

The only reason I actually got a non-utf symbol was because of a ctags bug; But seeing as that bug is open since 2007...

epriestley accepted this revision.Feb 26 2014, 8:41 PM

Closed by commit rP361e49dd6799 (authored by @avivey, committed by @epriestley).

Revision Contents
Changeset List

Path

Size

scripts/

symbols/

import_project_symbols.php

45 lines

Diff 19853

View Options

scripts/symbols/import_project_symbols.php

Symbol import: preemptively error on non-utf8 symbolsClosedPublicActions