Page MenuHomePhabricator

Fixed naming convention violations.
ClosedPublic

Authored by joshuaspence on Feb 26 2014, 7:51 AM.
Tags
None
Referenced Files
F13816945: D8348.diff
Thu, Sep 19, 8:27 PM
Unknown Object (File)
Wed, Sep 18, 7:36 PM
Unknown Object (File)
Wed, Sep 4, 5:19 PM
Unknown Object (File)
Thu, Aug 29, 5:11 AM
Unknown Object (File)
Tue, Aug 27, 6:20 PM
Unknown Object (File)
Mon, Aug 26, 1:06 AM
Unknown Object (File)
Sun, Aug 25, 1:21 PM
Unknown Object (File)
Aug 19 2024, 12:25 PM

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
Restricted Diffusion Commit
rPcea58de0ba92: Fixed naming convention violations.
Summary

This file contains member variables prefixed with underscores. This violates the naming convention enforced by the linter.

Test Plan

The linter warnings have disappeared. Example:

>>> Lint for src/infrastructure/storage/lisk/LiskDAO.php:


   Warning  (XHP9) Naming Conventions
    Follow naming conventions: class properties should be named using
    lowerCamelCase.

             183
             184   const COUNTER_TABLE_NAME          = 'lisk_counter';
             185
    >>>      186   private $__dirtyFields            = array();
             187   private $__missingFields          = array();
             188   private static $processIsolationLevel       = 0;
             189   private static $transactionIsolationLevel   = 0;

Diff Detail

Repository
rP Phabricator
Branch
naming_conventions
Lint
Lint Passed
Unit
Tests Skipped