Page MenuHomePhabricator

Fixed naming convention violations.
ClosedPublic

Authored by joshuaspence on Feb 26 2014, 7:51 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Dec 20, 5:10 PM
Unknown Object (File)
Thu, Dec 19, 11:03 PM
Unknown Object (File)
Fri, Dec 13, 11:15 PM
Unknown Object (File)
Thu, Dec 5, 5:09 PM
Unknown Object (File)
Wed, Dec 4, 9:15 AM
Unknown Object (File)
Fri, Nov 29, 1:59 AM
Unknown Object (File)
Thu, Nov 28, 5:14 PM
Unknown Object (File)
Wed, Nov 27, 4:21 PM

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
Restricted Diffusion Commit
rPcea58de0ba92: Fixed naming convention violations.
Summary

This file contains member variables prefixed with underscores. This violates the naming convention enforced by the linter.

Test Plan

The linter warnings have disappeared. Example:

>>> Lint for src/infrastructure/storage/lisk/LiskDAO.php:


   Warning  (XHP9) Naming Conventions
    Follow naming conventions: class properties should be named using
    lowerCamelCase.

             183
             184   const COUNTER_TABLE_NAME          = 'lisk_counter';
             185
    >>>      186   private $__dirtyFields            = array();
             187   private $__missingFields          = array();
             188   private static $processIsolationLevel       = 0;
             189   private static $transactionIsolationLevel   = 0;

Diff Detail

Repository
rP Phabricator
Branch
naming_conventions
Lint
Lint Passed
Unit
Tests Skipped