Page MenuHomePhabricator

Fixed naming convention violations.
ClosedPublic

Authored by joshuaspence on Feb 26 2014, 7:51 AM.
Tags
None
Referenced Files
F18837765: D8348.id.diff
Mon, Oct 27, 7:36 AM
F18808857: D8348.diff
Sun, Oct 19, 9:13 AM
F18745810: D8348.id.diff
Fri, Oct 3, 9:33 AM
F18741123: D8348.diff
Thu, Oct 2, 8:41 AM
F18602289: D8348.diff
Sep 13 2025, 2:42 PM
F18588369: D8348.diff
Sep 12 2025, 12:03 AM
F18090940: D8348.id19855.diff
Aug 6 2025, 6:12 PM
F18088548: D8348.diff
Aug 6 2025, 8:24 AM

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
Restricted Diffusion Commit
rPcea58de0ba92: Fixed naming convention violations.
Summary

This file contains member variables prefixed with underscores. This violates the naming convention enforced by the linter.

Test Plan

The linter warnings have disappeared. Example:

>>> Lint for src/infrastructure/storage/lisk/LiskDAO.php:


   Warning  (XHP9) Naming Conventions
    Follow naming conventions: class properties should be named using
    lowerCamelCase.

             183
             184   const COUNTER_TABLE_NAME          = 'lisk_counter';
             185
    >>>      186   private $__dirtyFields            = array();
             187   private $__missingFields          = array();
             188   private static $processIsolationLevel       = 0;
             189   private static $transactionIsolationLevel   = 0;

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped