Page MenuHomePhabricator

Use ApplicationTransactions/CustomField to power Differential global search
ClosedPublic

Authored by epriestley on Feb 26 2014, 12:15 AM.
Tags
None
Referenced Files
F15585941: D8346.id.diff
Thu, May 8, 11:48 AM
F15585933: D8346.diff
Thu, May 8, 11:47 AM
F15584952: D8346.id19850.diff
Thu, May 8, 6:10 AM
F15584951: D8346.id19843.diff
Thu, May 8, 6:10 AM
F15584950: D8346.diff
Thu, May 8, 6:10 AM
F15583197: D8346.id19850.diff
Wed, May 7, 8:16 PM
F15582996: D8346.diff
Wed, May 7, 7:18 PM
F15491415: D8346.id.diff
Sat, Apr 12, 3:12 AM
Subscribers

Details

Summary

Ref T2222. Ref T3886. Ref T418. A few changes:

  • CustomField can now index into global search.
  • Use CustomField fields instead of older custom fields for Differential global search. (This slightly breaks any custom fields which exist, but they are presumably very rare, and probably do not exist; this break is also very mild.)
  • Automatically perform CustomField and Subscribable indexing on applicable object types.
Test Plan

Used bin/search index to reindex a bunch of stuff, then searched for it. Debug-dumped abstract documents to inspect them.

Diff Detail

Repository
rP Phabricator
Branch
dsearch1
Lint
Lint Passed
Unit
Tests Passed

Event Timeline

btrahan added inline comments.
src/applications/maniphest/search/ManiphestSearchIndexer.php
84

<3 these deletions