Various linter fixes.
ClosedPublic
Actions

Authored by joshuaspence on Feb 25 2014, 10:31 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

Restricted Diffusion Commit
rP627011476733: Various linter fixes.

Apply Patch

arc patch D8344

Summary

Removed trailing newlines.
Added newline at EOF.
Removed leading newlines.
Trimmed trailing whitespace.
Spelling fix.
Added newline at EOF

Test Plan

N/A

Diff Detail

Lint

Lint Skipped

Unit

Unit Tests Skipped

epriestley accepted this revision.Feb 26 2014, 8:44 PM

Closed by commit rP627011476733 (authored by @joshuaspence, committed by @epriestley).

Very Large Diff

This diff is very large and affects 268 files. You may load each file individually or Show All Files Inline

Revision Contents

			Path
M			conf/production.conf.php (1 line)
M			resources/sql/patches/000.project.sql (2 lines)
M			resources/sql/patches/0000.legacy.sql (6 lines)
M			resources/sql/patches/002.oauth.sql (2 lines)
M			resources/sql/patches/004.daemonrepos.sql (2 lines)
M			resources/sql/patches/005.workers.sql (2 lines)
M			resources/sql/patches/007.daemonlog.sql (2 lines)
M			resources/sql/patches/009.repo_summary.sql (2 lines)
M			resources/sql/patches/010.herald.sql (2 lines)
M			resources/sql/patches/011.badcommit.sql (2 lines)
M			resources/sql/patches/012.dropphidtype.sql (2 lines)
M			resources/sql/patches/016.userrealnameindex.sql (2 lines)
M			resources/sql/patches/018.owners.sql (2 lines)
M			resources/sql/patches/020.pathcapital.sql (2 lines)
M			resources/sql/patches/021.xhpastview.sql (1 line)
M			resources/sql/patches/024.mlistkeys.sql (1 line)
M			resources/sql/patches/025.commentopt.sql (2 lines)
M			resources/sql/patches/026.diffpropkey.sql (1 line)
M			resources/sql/patches/028.systemagent.sql (2 lines)
M			resources/sql/patches/034.savedheader.sql (2 lines)
M			resources/sql/patches/036.mailkey.sql (2 lines)
M			resources/sql/patches/043.pastebin.sql (2 lines)
M			resources/sql/patches/044.countdown.sql (2 lines)
M			resources/sql/patches/047.projectstatus.sql (2 lines)
M			resources/sql/patches/049.projectowner.sql (2 lines)
M			resources/sql/patches/052.pastelanguage.sql (2 lines)
M			resources/sql/patches/053.feed.sql (2 lines)
M			resources/sql/patches/055.add_author_to_files.sql (2 lines)
M			resources/sql/patches/056.slowvote.sql (4 lines)
M			resources/sql/patches/057.parsecache.sql (2 lines)
M			resources/sql/patches/058.missingkeys.sql (2 lines)
M			resources/sql/patches/060.phriction.sql (2 lines)
M			resources/sql/patches/061.phrictioncontent.sql (2 lines)
M			resources/sql/patches/062.phrictionmenu.sql (2 lines)
M			resources/sql/patches/063.pasteforks.sql (2 lines)
M			resources/sql/patches/064.subprojects.sql (2 lines)
M			resources/sql/patches/065.sshkeys.sql (2 lines)
M			resources/sql/patches/067.preferences.sql (2 lines)
M			resources/sql/patches/068.maniphestauxiliarystorage.sql (10 lines)
M			resources/sql/patches/076.indexedlanguages.sql (2 lines)
M			resources/sql/patches/080.filekeys.sql (2 lines)
M			resources/sql/patches/086.formeraffil.sql (2 lines)
M			resources/sql/patches/087.phrictiondelete.sql (2 lines)
M			resources/sql/patches/088.audit.sql (2 lines)
M			resources/sql/patches/092.dropgithubnotification.sql (2 lines)
M			resources/sql/patches/095.directory.sql (2 lines)
M			resources/sql/patches/097.heraldruletypes.sql (2 lines)
M			resources/sql/patches/099.drydock.sql (2 lines)
M			resources/sql/patches/106.chatlog.sql (1 line)
M			resources/sql/patches/107.oauthserver.sql (3 lines)
M			resources/sql/patches/108.oauthscope.sql (1 line)
M			resources/sql/patches/109.oauthclientphidkey.sql (1 line)
M			resources/sql/patches/110.commitaudit.sql (2 lines)
M			resources/sql/patches/112.oauthaccesscoderedirecturi.sql (1 line)
M			resources/sql/patches/116.utf8-backup-first-expect-wait.sql (3 lines)
M			resources/sql/patches/120.noop.sql (2 lines)
M			resources/sql/patches/122.flag.sql (4 lines)
M			resources/sql/patches/124.subpriority.sql (2 lines)
M			resources/sql/patches/128.phabricatorcom.sql (2 lines)
M			resources/sql/patches/132.phame.sql (2 lines)
M			resources/sql/patches/20121209.pholioxactions.sql (1 line)
M			resources/sql/patches/20130111.conpherence.sql (2 lines)
M			resources/sql/patches/20130127.altheraldtranscript.sql (1 line)
M			resources/sql/patches/20130131.conpherencepics.sql (4 lines)
M			resources/sql/patches/20130214.chatlogchannel.sql (1 line)
M			resources/sql/patches/20130215.phabricatorfileaddttl.sql (4 lines)
M			resources/sql/patches/20130317.phrictionedge.sql (1 line)
M			resources/sql/patches/20130320.phlux.sql (1 line)
M			resources/sql/patches/20130322.phortune.sql (1 line)
M			resources/sql/patches/20130417.externalaccount.sql (1 line)
M			resources/sql/patches/20130519.diviner.sql (2 lines)
M			resources/sql/patches/20130606.userxactions.sql (2 lines)
M			resources/sql/patches/20130620.diffxactions.sql (1 line)
M			resources/sql/patches/20130622.doorkeeper.sql (1 line)
M			resources/sql/patches/20130628.legalpadv0.sql (1 line)
M			resources/sql/patches/20130723.taskstarttime.sql (1 line)
M			resources/sql/patches/20130726.ponderxactions.sql (1 line)
M			resources/sql/patches/20130820.filexactions.sql (1 line)
M			resources/sql/patches/20130926.dinkeys.sql (1 line)
M			resources/sql/patches/20131030.repostatusmessage.sql (1 line)
M			resources/sql/patches/20131224.harbormanual.sql (1 line)
M			resources/sql/patches/20131227.heraldobject.sql (1 line)
M			resources/sql/patches/20131302.maniphestvalue.sql (1 line)
M			resources/sql/patches/emailtableremove.sql (2 lines)
M			resources/sql/patches/phameblog.sql (1 line)
M			resources/sql/patches/phamedomain.sql (2 lines)
M			resources/sql/patches/phamepolicy.sql (1 line)
M			resources/sql/patches/phiddrop.sql (2 lines)
M			resources/sql/patches/ponder-comments.sql (2 lines)
M			resources/sql/patches/ponder.sql (2 lines)
M			scripts/differential/destroy_revision.php (1 line)
M			scripts/mail/mail_handler.php (2 lines)
M			scripts/mail/manage_mail.php (1 line)
M			scripts/repository/test_connection.php (1 line)
M			scripts/search/reindex_maniphest.php (1 line)
M			src/aphront/console/DarkConsoleCore.php (1 line)
M			src/aphront/console/plugin/DarkConsoleServicesPlugin.php (1 line)
M			src/aphront/console/plugin/errorlog/DarkConsoleErrorLogPluginAPI.php (1 line)
M			src/aphront/console/plugin/event/DarkConsoleEventPluginAPI.php (1 line)
M			src/applications/audit/application/PhabricatorApplicationAudit.php (1 line)
M			src/applications/audit/events/AuditActionMenuEventListener.php (1 line)
M			src/applications/auth/storage/PhabricatorAuthProviderConfigTransaction.php (1 line)
M			src/applications/base/controller/__tests__/PhabricatorApplicationTest.php (1 line)
M			src/applications/chatlog/applications/PhabricatorApplicationChatLog.php (1 line)
M			src/applications/chatlog/storage/PhabricatorChatLogChannel.php (1 line)
M			src/applications/config/check/PhabricatorSetupCheckImagemagick.php (1 line)
M			src/applications/config/storage/PhabricatorConfigTransaction.php (1 line)
M			src/applications/conpherence/events/ConpherenceActionMenuEventListener.php (1 line)
M			src/applications/conpherence/events/ConpherenceHovercardEventListener.php (1 line)
M			src/applications/differential/application/PhabricatorApplicationDifferential.php (1 line)
M			src/applications/differential/controller/DifferentialRevisionLandController.php (1 line)
M			src/applications/differential/editor/DifferentialRevisionEditor.php (1 line)
M			src/applications/differential/event/DifferentialActionMenuEventListener.php (1 line)
M			src/applications/differential/field/selector/DifferentialDefaultFieldSelector.php (1 line)
M			src/applications/differential/mail/DifferentialExceptionMail.php (2 lines)
M			src/applications/differential/parser/__tests__/DifferentialHunkParserTestCase.php (1 line)
M			src/applications/differential/storage/DifferentialCustomFieldNumericIndex.php (1 line)
M			src/applications/differential/storage/DifferentialCustomFieldStorage.php (1 line)
M			src/applications/differential/storage/DifferentialCustomFieldStringIndex.php (1 line)
M			src/applications/differential/view/DifferentialChangesetFileTreeSideNavBuilder.php (1 line)
M			src/applications/diffusion/controller/DiffusionServeController.php (1 line)
M			src/applications/diffusion/events/DiffusionHovercardEventListener.php (1 line)
M			src/applications/diffusion/query/pathid/__tests__/DiffusionPathQueryTestCase.php (1 line)
M			src/applications/diviner/application/PhabricatorApplicationDiviner.php (1 line)
M			src/applications/diviner/atomizer/DivinerPHPAtomizer.php (1 line)
M			src/applications/drydock/worker/DrydockAllocatorWorker.php (2 lines)
M			src/applications/feed/application/PhabricatorApplicationFeed.php (1 line)
M			src/applications/flag/application/PhabricatorApplicationFlags.php (1 line)
M			src/applications/flag/events/PhabricatorFlagsUIEventListener.php (1 line)
M			src/applications/herald/adapter/HeraldAdapter.php (1 line)
M			src/applications/herald/engine/HeraldEffect.php (1 line)
M			src/applications/herald/storage/HeraldRuleTransactionComment.php (1 line)
M			src/applications/herald/storage/__tests__/HeraldTranscriptTestCase.php (2 lines)
M			src/applications/macro/storage/PhabricatorFileImageMacro.php (1 line)
M			src/applications/macro/storage/PhabricatorMacroTransaction.php (1 line)
M			src/applications/macro/storage/PhabricatorMacroTransactionComment.php (1 line)
M			src/applications/maniphest/application/PhabricatorApplicationManiphest.php (1 line)
M			src/applications/maniphest/storage/ManiphestCustomFieldNumericIndex.php (1 line)
M			src/applications/maniphest/storage/ManiphestCustomFieldStorage.php (1 line)
M			src/applications/maniphest/storage/ManiphestCustomFieldStringIndex.php (1 line)
M			src/applications/maniphest/storage/ManiphestTransaction.php (1 line)
M			src/applications/meta/application/PhabricatorApplicationApplications.php (1 line)
M			src/applications/meta/controller/PhabricatorApplicationUninstallController.php (1 line)
M			src/applications/metamta/adapter/PhabricatorMailImplementationSendGridAdapter.php (1 line)
M			src/applications/nuance/application/PhabricatorApplicationNuance.php (1 line)
M			src/applications/nuance/query/NuanceItemQuery.php (1 line)
M			src/applications/nuance/query/NuanceQuery.php (1 line)
M			src/applications/nuance/query/NuanceQueueQuery.php (1 line)
M			src/applications/nuance/query/NuanceRequestorQuery.php (1 line)
M			src/applications/nuance/source/NuanceSourceDefinition.php (1 line)
M			src/applications/owners/mail/OwnersPackageReplyHandler.php (2 lines)
M			src/applications/people/storage/PhabricatorUserConfiguredCustomFieldStorage.php (1 line)
M			src/applications/people/storage/PhabricatorUserCustomFieldNumericIndex.php (1 line)
M			src/applications/people/storage/PhabricatorUserCustomFieldStringIndex.php (1 line)
M			src/applications/people/storage/PhabricatorUserTransaction.php (1 line)
M			src/applications/pholio/event/PholioActionMenuEventListener.php (1 line)
M			src/applications/phragment/application/PhabricatorApplicationPhragment.php (1 line)
M			src/applications/phrequent/application/PhabricatorApplicationPhrequent.php (1 line)
M			src/applications/phrequent/query/PhrequentSearchEngine.php (1 line)
M			src/applications/phriction/application/PhabricatorApplicationPhriction.php (1 line)
M			src/applications/policy/application/PhabricatorApplicationPolicy.php (1 line)
M			src/applications/policy/capability/PhabricatorPolicyCapability.php (2 lines)
M			src/applications/policy/query/PhabricatorPolicyQuery.php (1 line)
M			src/applications/ponder/remarkup/PonderRemarkupRule.php (1 line)
M			src/applications/ponder/storage/PonderAnswerTransaction.php (1 line)
M			src/applications/ponder/storage/PonderAnswerTransactionComment.php (1 line)
M			src/applications/ponder/storage/PonderComment.php (1 line)
M			src/applications/ponder/storage/PonderQuestionTransactionComment.php (1 line)
M			src/applications/project/storage/PhabricatorProjectCustomFieldNumericIndex.php (1 line)
M			src/applications/project/storage/PhabricatorProjectCustomFieldStorage.php (1 line)
M			src/applications/project/storage/PhabricatorProjectCustomFieldStringIndex.php (1 line)
M			src/applications/releeph/storage/ReleephBranchTransaction.php (1 line)
M			src/applications/releeph/storage/ReleephProjectTransaction.php (1 line)
M			src/applications/repository/search/PhabricatorRepositoryCommitSearchIndexer.php (1 line)
M			src/applications/repository/storage/PhabricatorRepositoryTransaction.php (1 line)
M			src/applications/search/controller/PhabricatorSearchAttachController.php (2 lines)
M			src/applications/settings/panel/PhabricatorSettingsPanelConpherencePreferences.php (1 line)
M			src/applications/settings/panel/PhabricatorSettingsPanelDeveloperPreferences.php (1 line)
M			src/applications/settings/panel/PhabricatorSettingsPanelDiffPreferences.php (1 line)
M			src/applications/settings/panel/PhabricatorSettingsPanelDisplayPreferences.php (1 line)
M			src/applications/settings/panel/PhabricatorSettingsPanelHomePreferences.php (1 line)
M			src/applications/settings/panel/PhabricatorSettingsPanelSearchPreferences.php (1 line)
M			src/applications/slowvote/storage/PhabricatorSlowvoteTransaction.php (1 line)
M			src/applications/slowvote/storage/PhabricatorSlowvoteTransactionComment.php (1 line)
M			src/applications/subscriptions/application/PhabricatorApplicationSubscriptions.php (1 line)
M			src/applications/transactions/application/PhabricatorApplicationTransactions.php (1 line)
M			src/applications/transactions/view/PhabricatorApplicationTransactionCommentView.php (1 line)
M			src/applications/transactions/view/PhabricatorApplicationTransactionTextDiffDetailView.php (1 line)
M			src/applications/transactions/view/PhabricatorApplicationTransactionView.php (1 line)
M			src/applications/typeahead/storage/PhabricatorTypeaheadResult.php (1 line)
M			src/docs/user/configuration/troubleshooting_https.diviner (2 lines)
M			src/docs/user/contributing/php_coding_standards.diviner (1 line)
M			src/docs/user/developer/adding_new_css_and_js.diviner (1 line)
M			src/docs/user/developer/unit_tests.diviner (1 line)
M			src/docs/user/developer/using_oauthserver.diviner (92 lines)
M			src/docs/user/flavortext/javascript_object_array.diviner (1 line)
M			src/docs/user/flavortext/javascript_pitfalls.diviner (1 line)
M			src/docs/user/flavortext/things_you_should_do_now.diviner (2 lines)
M			src/docs/user/userguide/arcanist_lint.diviner (1 line)
M			src/docs/user/userguide/differential_test_plans.diviner (2 lines)
M			src/docs/user/userguide/herald.diviner (1 line)
M			src/docs/user/userguide/mail_rules.diviner (1 line)
M			src/docs/user/userguide/maniphest_custom.diviner (1 line)
M			src/docs/user/userguide/phame.diviner (16 lines)
M			src/infrastructure/__tests__/PhabricatorInfrastructureTestCase.php (1 line)
M			src/infrastructure/celerity/CeleritySpriteGenerator.php (2 lines)
M			src/infrastructure/daemon/bot/adapter/PhabricatorBotBaseStreamingProtocolAdapter.php (1 line)
M			src/infrastructure/events/PhabricatorEvent.php (5 lines)
M			src/infrastructure/events/PhabricatorEventListener.php (5 lines)
M			src/infrastructure/events/PhabricatorExampleEventListener.php (5 lines)
M			src/view/control/AphrontTableView.php (1 line)
M			src/view/layout/PhabricatorFileLinkListView.php (1 line)
M			src/view/viewutils.php (1 line)
M			support/aphlict/client/aphlict_test_client.php (1 line)
M			support/empty/README (1 line)
M			webroot/index.php (1 line)
M			webroot/rsrc/css/aphront/lightbox-attachment.css (1 line)
M			webroot/rsrc/css/aphront/phabricator-nav-view.css (1 line)
M			webroot/rsrc/css/application/conpherence/notification.css (1 line)
M			webroot/rsrc/css/application/differential/core.css (1 line)
M			webroot/rsrc/css/application/maniphest/batch-editor.css (1 line)
M			webroot/rsrc/css/application/people/people-profile.css (1 line)
M			webroot/rsrc/css/layout/phabricator-action-header-view.css (1 line)
M			webroot/rsrc/css/phui/phui-icon.css (2 lines)
M			webroot/rsrc/externals/javelin/LICENSE (1 line)
M			webroot/rsrc/externals/javelin/core/__tests__/event-stop-and-kill.js (4 lines)
M			webroot/rsrc/externals/javelin/core/__tests__/install.js (1 line)
M			webroot/rsrc/externals/javelin/docs/Base.js (5 lines)
M			webroot/rsrc/externals/javelin/docs/concepts/behaviors.diviner (1 line)
M			webroot/rsrc/externals/javelin/docs/onload.js (1 line)
M			webroot/rsrc/externals/javelin/ext/reactor/core/DynVal.js (1 line)
M			webroot/rsrc/externals/javelin/ext/reactor/core/Reactor.js (1 line)
M			webroot/rsrc/externals/javelin/ext/reactor/core/ReactorNode.js (1 line)
M			webroot/rsrc/externals/javelin/ext/reactor/core/ReactorNodeCalmer.js (1 line)
M			webroot/rsrc/externals/javelin/ext/reactor/dom/RDOM.js (2 lines)
M			webroot/rsrc/externals/javelin/ext/view/HTMLView.js (1 line)
M			webroot/rsrc/externals/javelin/ext/view/View.js (1 line)
M			webroot/rsrc/externals/javelin/ext/view/ViewRenderer.js (1 line)
M			webroot/rsrc/externals/javelin/ext/view/ViewVisitor.js (1 line)
M			webroot/rsrc/externals/javelin/lib/DOM.js (1 line)
M			webroot/rsrc/externals/javelin/lib/__tests__/URI.js (1 line)
M			webroot/rsrc/externals/javelin/lib/__tests__/behavior.js (1 line)
M			webroot/rsrc/externals/javelin/lib/control/typeahead/source/TypeaheadCompositeSource.js (1 line)
M			webroot/rsrc/externals/javelin/lib/control/typeahead/source/TypeaheadOnDemandSource.js (2 lines)
M			webroot/rsrc/externals/javelin/lib/control/typeahead/source/TypeaheadPreloadedSource.js (3 lines)
M			webroot/rsrc/externals/javelin/lib/control/typeahead/source/TypeaheadStaticSource.js (3 lines)
M			webroot/rsrc/image/icon/fatcow/README (2 lines)
M			webroot/rsrc/js/application/config/behavior-reorder-fields.js (1 line)
M			webroot/rsrc/js/application/countdown/timer.js (1 line)
M			webroot/rsrc/js/application/differential/behavior-add-reviewers-and-ccs.js (1 line)
M			webroot/rsrc/js/application/differential/behavior-edit-inline-comments.js (1 line)
M			webroot/rsrc/js/application/differential/behavior-keyboard-nav.js (1 line)
M			webroot/rsrc/js/application/diffusion/behavior-commit-branches.js (1 line)
M			webroot/rsrc/js/application/diffusion/behavior-commit-graph.js (1 line)
M			webroot/rsrc/js/application/diffusion/behavior-pull-lastmodified.js (1 line)
M			webroot/rsrc/js/application/doorkeeper/behavior-doorkeeper-tag.js (1 line)
M			webroot/rsrc/js/application/files/behavior-icon-composer.js (1 line)
M			webroot/rsrc/js/application/files/behavior-launch-icon-composer.js (1 line)
M			webroot/rsrc/js/application/harbormaster/behavior-reorder-steps.js (1 line)
M			webroot/rsrc/js/application/maniphest/behavior-line-chart.js (1 line)
M			webroot/rsrc/js/application/maniphest/behavior-transaction-controls.js (1 line)
M			webroot/rsrc/js/application/search/behavior-reorder-queries.js (1 line)
M			webroot/rsrc/js/core/FileUpload.js (1 line)
M			webroot/rsrc/js/core/MultirowRowManager.js (1 line)
M			webroot/rsrc/js/core/Notification.js (1 line)
M			webroot/rsrc/js/core/behavior-drag-and-drop-textarea.js (1 line)
M			webroot/rsrc/js/core/behavior-global-drag-and-drop.js (1 line)
M			webroot/rsrc/swf/test.html (2 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	19839	f0e6dc1		Feb 25 2014, 10:31 PM	★	★
Diff 2	19854	361e49d	Commit rP6270114767335d5f911c5a1b842ed541724e7fc1	Feb 26 2014, 8:44 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
86cf80be631e	32c9c654dc69	f82102a4f234	Joshua Spence	Added newline at EOF	Feb 25 2014, 9:19 PM
f82102a4f234	d18dc5b90ed6	65016b8efc0a	Joshua Spence	Spelling fix.	Feb 25 2014, 8:55 PM
65016b8efc0a	3a91c8b80e41	82a4bc0cfc10	Joshua Spence	Trimmed trailing whitespace.	Feb 25 2014, 8:19 PM
82a4bc0cfc10	479611cae1f2	d6ce8fd70532	Joshua Spence	Removed leading newlines.	Feb 25 2014, 8:11 PM
d6ce8fd70532	06be7c2db929	cbc263d7269e	Joshua Spence	Added newline at EOF.	Feb 25 2014, 8:08 PM
cbc263d7269e	057c8f29f183	f0e6dc122109	Joshua Spence	Removed trailing newlines.	Feb 25 2014, 7:59 PM