Index: conf/production.conf.php =================================================================== --- conf/production.conf.php +++ conf/production.conf.php @@ -3,4 +3,3 @@ return array( ) + phabricator_read_config_file('default'); - Index: resources/sql/patches/000.project.sql =================================================================== --- resources/sql/patches/000.project.sql +++ resources/sql/patches/000.project.sql @@ -1,4 +1,3 @@ - create table {$NAMESPACE}_project.project ( id int unsigned not null auto_increment primary key, name varchar(255) not null, @@ -28,4 +27,3 @@ dateCreated int unsigned not null, dateModified int unsigned not null ); - Index: resources/sql/patches/0000.legacy.sql =================================================================== --- resources/sql/patches/0000.legacy.sql +++ resources/sql/patches/0000.legacy.sql @@ -1,9 +1,3 @@ - - - - - - /*!40101 SET @OLD_CHARACTER_SET_CLIENT=@@CHARACTER_SET_CLIENT */; /*!40101 SET @OLD_CHARACTER_SET_RESULTS=@@CHARACTER_SET_RESULTS */; /*!40101 SET @OLD_COLLATION_CONNECTION=@@COLLATION_CONNECTION */; Index: resources/sql/patches/002.oauth.sql =================================================================== --- resources/sql/patches/002.oauth.sql +++ resources/sql/patches/002.oauth.sql @@ -15,4 +15,4 @@ FROM {$NAMESPACE}_user.user WHERE facebookUID is not null; -alter table {$NAMESPACE}_user.user drop facebookUID; \ No newline at end of file +alter table {$NAMESPACE}_user.user drop facebookUID; Index: resources/sql/patches/004.daemonrepos.sql =================================================================== --- resources/sql/patches/004.daemonrepos.sql +++ resources/sql/patches/004.daemonrepos.sql @@ -25,4 +25,4 @@ create table {$NAMESPACE}_timeline.timeline_cursor ( name varchar(255) not null primary key, position int unsigned not null -); \ No newline at end of file +); Index: resources/sql/patches/005.workers.sql =================================================================== --- resources/sql/patches/005.workers.sql +++ resources/sql/patches/005.workers.sql @@ -1,5 +1,3 @@ - - create table {$NAMESPACE}_worker.worker_task ( id int unsigned not null auto_increment primary key, taskClass varchar(255) not null, Index: resources/sql/patches/007.daemonlog.sql =================================================================== --- resources/sql/patches/007.daemonlog.sql +++ resources/sql/patches/007.daemonlog.sql @@ -1,5 +1,3 @@ - - create table {$NAMESPACE}_daemon.daemon_log ( id int unsigned not null auto_increment primary key, daemon varchar(255) not null, Index: resources/sql/patches/009.repo_summary.sql =================================================================== --- resources/sql/patches/009.repo_summary.sql +++ resources/sql/patches/009.repo_summary.sql @@ -4,4 +4,4 @@ `lastCommitID` int(10) unsigned NOT NULL, `epoch` int(10) unsigned DEFAULT NULL, PRIMARY KEY (`repositoryID`) -); \ No newline at end of file +); Index: resources/sql/patches/010.herald.sql =================================================================== --- resources/sql/patches/010.herald.sql +++ resources/sql/patches/010.herald.sql @@ -1,5 +1,3 @@ - - CREATE TABLE {$NAMESPACE}_herald.herald_action ( id int unsigned not null auto_increment primary key, ruleID int unsigned not null, Index: resources/sql/patches/011.badcommit.sql =================================================================== --- resources/sql/patches/011.badcommit.sql +++ resources/sql/patches/011.badcommit.sql @@ -1,4 +1,4 @@ CREATE TABLE {$NAMESPACE}_repository.repository_badcommit ( fullCommitName varchar(255) binary not null primary key, description longblob not null -); \ No newline at end of file +); Index: resources/sql/patches/012.dropphidtype.sql =================================================================== --- resources/sql/patches/012.dropphidtype.sql +++ resources/sql/patches/012.dropphidtype.sql @@ -1 +1 @@ -/* This database was later removed entirely. */ \ No newline at end of file +/* This database was later removed entirely. */ Index: resources/sql/patches/016.userrealnameindex.sql =================================================================== --- resources/sql/patches/016.userrealnameindex.sql +++ resources/sql/patches/016.userrealnameindex.sql @@ -1 +1 @@ -ALTER TABLE {$NAMESPACE}_user.user ADD key (realName); \ No newline at end of file +ALTER TABLE {$NAMESPACE}_user.user ADD key (realName); Index: resources/sql/patches/018.owners.sql =================================================================== --- resources/sql/patches/018.owners.sql +++ resources/sql/patches/018.owners.sql @@ -1,5 +1,3 @@ - - CREATE TABLE {$NAMESPACE}_owners.owners_package ( id int unsigned not null auto_increment primary key, phid varchar(64) binary not null, Index: resources/sql/patches/020.pathcapital.sql =================================================================== --- resources/sql/patches/020.pathcapital.sql +++ resources/sql/patches/020.pathcapital.sql @@ -1,2 +1,2 @@ ALTER TABLE {$NAMESPACE}_differential.differential_diff - CHANGE sourceControlpath sourceControlPath varchar(255); \ No newline at end of file + CHANGE sourceControlpath sourceControlPath varchar(255); Index: resources/sql/patches/021.xhpastview.sql =================================================================== --- resources/sql/patches/021.xhpastview.sql +++ resources/sql/patches/021.xhpastview.sql @@ -1,4 +1,3 @@ - CREATE TABLE {$NAMESPACE}_xhpastview.xhpastview_parsetree ( id int unsigned not null auto_increment primary key, authorPHID varchar(64) binary, Index: resources/sql/patches/024.mlistkeys.sql =================================================================== --- resources/sql/patches/024.mlistkeys.sql +++ resources/sql/patches/024.mlistkeys.sql @@ -3,4 +3,3 @@ ALTER TABLE {$NAMESPACE}_metamta.metamta_mailinglist ADD UNIQUE KEY (name); - Index: resources/sql/patches/025.commentopt.sql =================================================================== --- resources/sql/patches/025.commentopt.sql +++ resources/sql/patches/025.commentopt.sql @@ -1,2 +1,2 @@ ALTER TABLE {$NAMESPACE}_differential.differential_inlinecomment - ADD KEY (revisionID, authorPHID); \ No newline at end of file + ADD KEY (revisionID, authorPHID); Index: resources/sql/patches/026.diffpropkey.sql =================================================================== --- resources/sql/patches/026.diffpropkey.sql +++ resources/sql/patches/026.diffpropkey.sql @@ -1,3 +1,2 @@ ALTER TABLE {$NAMESPACE}_differential.differential_diffproperty ADD UNIQUE KEY (diffID, name); - Index: resources/sql/patches/028.systemagent.sql =================================================================== --- resources/sql/patches/028.systemagent.sql +++ resources/sql/patches/028.systemagent.sql @@ -1,2 +1,2 @@ ALTER TABLE {$NAMESPACE}_user.user - ADD isSystemAgent bool not null default 0; \ No newline at end of file + ADD isSystemAgent bool not null default 0; Index: resources/sql/patches/034.savedheader.sql =================================================================== --- resources/sql/patches/034.savedheader.sql +++ resources/sql/patches/034.savedheader.sql @@ -1,4 +1,4 @@ CREATE TABLE {$NAMESPACE}_herald.herald_savedheader ( phid varchar(64) binary not null primary key, header varchar(255) not null -) ENGINE=InnoDB; \ No newline at end of file +) ENGINE=InnoDB; Index: resources/sql/patches/036.mailkey.sql =================================================================== --- resources/sql/patches/036.mailkey.sql +++ resources/sql/patches/036.mailkey.sql @@ -16,4 +16,4 @@ message longblob, dateCreated int unsigned not null, dateModified int unsigned not null -) engine=innodb; \ No newline at end of file +) engine=innodb; Index: resources/sql/patches/043.pastebin.sql =================================================================== --- resources/sql/patches/043.pastebin.sql +++ resources/sql/patches/043.pastebin.sql @@ -1,5 +1,3 @@ - - CREATE TABLE {$NAMESPACE}_pastebin.pastebin_paste ( id INT UNSIGNED NOT NULL AUTO_INCREMENT PRIMARY KEY, title VARCHAR(255) NOT NULL, Index: resources/sql/patches/044.countdown.sql =================================================================== --- resources/sql/patches/044.countdown.sql +++ resources/sql/patches/044.countdown.sql @@ -1,5 +1,3 @@ - - CREATE TABLE {$NAMESPACE}_countdown.countdown_timer ( id INT UNSIGNED NOT NULL AUTO_INCREMENT PRIMARY KEY, title VARCHAR(255) NOT NULL, Index: resources/sql/patches/047.projectstatus.sql =================================================================== --- resources/sql/patches/047.projectstatus.sql +++ resources/sql/patches/047.projectstatus.sql @@ -1,2 +1,2 @@ ALTER TABLE {$NAMESPACE}_project.project - ADD status varchar(32) not null; \ No newline at end of file + ADD status varchar(32) not null; Index: resources/sql/patches/049.projectowner.sql =================================================================== --- resources/sql/patches/049.projectowner.sql +++ resources/sql/patches/049.projectowner.sql @@ -1,2 +1,2 @@ ALTER TABLE {$NAMESPACE}_project.project_affiliation - ADD isOwner bool NOT NULL; \ No newline at end of file + ADD isOwner bool NOT NULL; Index: resources/sql/patches/052.pastelanguage.sql =================================================================== --- resources/sql/patches/052.pastelanguage.sql +++ resources/sql/patches/052.pastelanguage.sql @@ -1,2 +1,2 @@ ALTER TABLE {$NAMESPACE}_pastebin.pastebin_paste - ADD COLUMN language VARCHAR(64) NOT NULL; \ No newline at end of file + ADD COLUMN language VARCHAR(64) NOT NULL; Index: resources/sql/patches/053.feed.sql =================================================================== --- resources/sql/patches/053.feed.sql +++ resources/sql/patches/053.feed.sql @@ -1,5 +1,3 @@ - - CREATE TABLE {$NAMESPACE}_feed.feed_storydata ( id INT UNSIGNED NOT NULL AUTO_INCREMENT PRIMARY KEY, phid VARCHAR(64) BINARY NOT NULL, Index: resources/sql/patches/055.add_author_to_files.sql =================================================================== --- resources/sql/patches/055.add_author_to_files.sql +++ resources/sql/patches/055.add_author_to_files.sql @@ -1,3 +1,3 @@ ALTER TABLE {$NAMESPACE}_file.file ADD COLUMN authorPHID VARCHAR(64) BINARY, - ADD KEY (authorPHID); \ No newline at end of file + ADD KEY (authorPHID); Index: resources/sql/patches/056.slowvote.sql =================================================================== --- resources/sql/patches/056.slowvote.sql +++ resources/sql/patches/056.slowvote.sql @@ -1,5 +1,3 @@ - - CREATE TABLE {$NAMESPACE}_slowvote.slowvote_poll ( id INT UNSIGNED NOT NULL AUTO_INCREMENT PRIMARY KEY, question VARCHAR(255) NOT NULL, @@ -41,4 +39,4 @@ KEY (authorPHID), dateCreated INT UNSIGNED NOT NULL, dateModified INT UNSIGNED NOT NULL -); \ No newline at end of file +); Index: resources/sql/patches/057.parsecache.sql =================================================================== --- resources/sql/patches/057.parsecache.sql +++ resources/sql/patches/057.parsecache.sql @@ -4,4 +4,4 @@ ADD dateCreated INT UNSIGNED NOT NULL; ALTER TABLE {$NAMESPACE}_differential.differential_changeset_parse_cache - ADD KEY (dateCreated); \ No newline at end of file + ADD KEY (dateCreated); Index: resources/sql/patches/058.missingkeys.sql =================================================================== --- resources/sql/patches/058.missingkeys.sql +++ resources/sql/patches/058.missingkeys.sql @@ -8,4 +8,4 @@ ADD KEY (ruleID); ALTER TABLE {$NAMESPACE}_herald.herald_action - ADD KEY (ruleID); \ No newline at end of file + ADD KEY (ruleID); Index: resources/sql/patches/060.phriction.sql =================================================================== --- resources/sql/patches/060.phriction.sql +++ resources/sql/patches/060.phriction.sql @@ -1,5 +1,3 @@ - - CREATE TABLE {$NAMESPACE}_phriction.phriction_document ( id INT UNSIGNED NOT NULL, phid VARCHAR(64) BINARY NOT NULL, Index: resources/sql/patches/061.phrictioncontent.sql =================================================================== --- resources/sql/patches/061.phrictioncontent.sql +++ resources/sql/patches/061.phrictioncontent.sql @@ -19,4 +19,4 @@ content LONGBLOB NOT NULL, dateCreated INT UNSIGNED NOT NULL, dateModified INT UNSIGNED NOT NULL -) ENGINE=InnoDB; \ No newline at end of file +) ENGINE=InnoDB; Index: resources/sql/patches/062.phrictionmenu.sql =================================================================== --- resources/sql/patches/062.phrictionmenu.sql +++ resources/sql/patches/062.phrictionmenu.sql @@ -1,3 +1,3 @@ /* Older versions incorrectly computed the depth for the root page. */ UPDATE {$NAMESPACE}_phriction.phriction_document - SET depth = 0 where slug = '/'; \ No newline at end of file + SET depth = 0 where slug = '/'; Index: resources/sql/patches/063.pasteforks.sql =================================================================== --- resources/sql/patches/063.pasteforks.sql +++ resources/sql/patches/063.pasteforks.sql @@ -1,3 +1,3 @@ ALTER TABLE {$NAMESPACE}_pastebin.pastebin_paste ADD COLUMN parentPHID VARCHAR(64) BINARY, - ADD KEY (parentPHID); \ No newline at end of file + ADD KEY (parentPHID); Index: resources/sql/patches/064.subprojects.sql =================================================================== --- resources/sql/patches/064.subprojects.sql +++ resources/sql/patches/064.subprojects.sql @@ -8,4 +8,4 @@ subprojectPHID varchar(64) BINARY NOT NULL, PRIMARY KEY (subprojectPHID, projectPHID), UNIQUE KEY (projectPHID, subprojectPHID) -) ENGINE=InnoDB; \ No newline at end of file +) ENGINE=InnoDB; Index: resources/sql/patches/065.sshkeys.sql =================================================================== --- resources/sql/patches/065.sshkeys.sql +++ resources/sql/patches/065.sshkeys.sql @@ -9,4 +9,4 @@ keyComment varchar(255), dateCreated INT UNSIGNED NOT NULL, dateModified INT UNSIGNED NOT NULL -) ENGINE=InnoDB; \ No newline at end of file +) ENGINE=InnoDB; Index: resources/sql/patches/067.preferences.sql =================================================================== --- resources/sql/patches/067.preferences.sql +++ resources/sql/patches/067.preferences.sql @@ -1 +1 @@ -/* This used to be a "directory" update. */; \ No newline at end of file +/* This used to be a "directory" update. */; Index: resources/sql/patches/068.maniphestauxiliarystorage.sql =================================================================== --- resources/sql/patches/068.maniphestauxiliarystorage.sql +++ resources/sql/patches/068.maniphestauxiliarystorage.sql @@ -1,9 +1,9 @@ -create table {$NAMESPACE}_maniphest.maniphest_taskauxiliarystorage +create table {$NAMESPACE}_maniphest.maniphest_taskauxiliarystorage (id int unsigned not null auto_increment primary key, - taskPHID varchar(64) binary not null, - name varchar(255) not null, - value varchar(255) not null, + taskPHID varchar(64) binary not null, + name varchar(255) not null, + value varchar(255) not null, unique key (taskPHID,name), dateCreated int unsigned not null, dateModified int unsigned not null) - ENGINE = InnoDB; \ No newline at end of file + ENGINE = InnoDB; Index: resources/sql/patches/076.indexedlanguages.sql =================================================================== --- resources/sql/patches/076.indexedlanguages.sql +++ resources/sql/patches/076.indexedlanguages.sql @@ -1,4 +1,4 @@ ALTER TABLE {$NAMESPACE}_repository.repository_arcanistproject ADD symbolIndexLanguages LONGBLOB NOT NULL; ALTER TABLE {$NAMESPACE}_repository.repository_arcanistproject - ADD symbolIndexProjects LONGBLOB NOT NULL; \ No newline at end of file + ADD symbolIndexProjects LONGBLOB NOT NULL; Index: resources/sql/patches/080.filekeys.sql =================================================================== --- resources/sql/patches/080.filekeys.sql +++ resources/sql/patches/080.filekeys.sql @@ -1,2 +1,2 @@ ALTER TABLE {$NAMESPACE}_file.file - ADD secretKey VARCHAR(20) BINARY; \ No newline at end of file + ADD secretKey VARCHAR(20) BINARY; Index: resources/sql/patches/086.formeraffil.sql =================================================================== --- resources/sql/patches/086.formeraffil.sql +++ resources/sql/patches/086.formeraffil.sql @@ -1 +1 @@ -ALTER TABLE {$NAMESPACE}_project.project_affiliation DROP status; \ No newline at end of file +ALTER TABLE {$NAMESPACE}_project.project_affiliation DROP status; Index: resources/sql/patches/087.phrictiondelete.sql =================================================================== --- resources/sql/patches/087.phrictiondelete.sql +++ resources/sql/patches/087.phrictiondelete.sql @@ -5,4 +5,4 @@ ADD changeType INT UNSIGNED NOT NULL DEFAULT 0; ALTER TABLE {$NAMESPACE}_phriction.phriction_content - ADD changeRef INT UNSIGNED DEFAULT NULL; \ No newline at end of file + ADD changeRef INT UNSIGNED DEFAULT NULL; Index: resources/sql/patches/088.audit.sql =================================================================== --- resources/sql/patches/088.audit.sql +++ resources/sql/patches/088.audit.sql @@ -1,5 +1,3 @@ - - ALTER TABLE {$NAMESPACE}_owners.owners_packagecommitrelationship ADD COLUMN `auditStatus` varchar(64) NOT NULL, ADD COLUMN `auditReasons` longtext NOT NULL, Index: resources/sql/patches/092.dropgithubnotification.sql =================================================================== --- resources/sql/patches/092.dropgithubnotification.sql +++ resources/sql/patches/092.dropgithubnotification.sql @@ -1 +1 @@ -DROP TABLE {$NAMESPACE}_repository.repository_githubnotification; \ No newline at end of file +DROP TABLE {$NAMESPACE}_repository.repository_githubnotification; Index: resources/sql/patches/095.directory.sql =================================================================== --- resources/sql/patches/095.directory.sql +++ resources/sql/patches/095.directory.sql @@ -1 +1 @@ -/* This used to be a "directory" update. */; \ No newline at end of file +/* This used to be a "directory" update. */; Index: resources/sql/patches/097.heraldruletypes.sql =================================================================== --- resources/sql/patches/097.heraldruletypes.sql +++ resources/sql/patches/097.heraldruletypes.sql @@ -1,2 +1,2 @@ ALTER TABLE {$NAMESPACE}_herald.herald_rule ADD ruleType varchar(255) not null DEFAULT 'global'; -CREATE INDEX IDX_RULE_TYPE on {$NAMESPACE}_herald.herald_rule (ruleType); \ No newline at end of file +CREATE INDEX IDX_RULE_TYPE on {$NAMESPACE}_herald.herald_rule (ruleType); Index: resources/sql/patches/099.drydock.sql =================================================================== --- resources/sql/patches/099.drydock.sql +++ resources/sql/patches/099.drydock.sql @@ -1,5 +1,3 @@ - - CREATE TABLE {$NAMESPACE}_drydock.drydock_resource ( id INT UNSIGNED NOT NULL AUTO_INCREMENT PRIMARY KEY, phid VARCHAR(64) BINARY NOT NULL, Index: resources/sql/patches/106.chatlog.sql =================================================================== --- resources/sql/patches/106.chatlog.sql +++ resources/sql/patches/106.chatlog.sql @@ -1,4 +1,3 @@ - CREATE TABLE {$NAMESPACE}_chatlog.chatlog_event ( id INT UNSIGNED NOT NULL PRIMARY KEY AUTO_INCREMENT, channel VARCHAR(64) BINARY NOT NULL, Index: resources/sql/patches/107.oauthserver.sql =================================================================== --- resources/sql/patches/107.oauthserver.sql +++ resources/sql/patches/107.oauthserver.sql @@ -1,5 +1,3 @@ - - CREATE TABLE `{$NAMESPACE}_oauth_server`.`oauth_server_oauthserverclient` ( `id` int(10) unsigned NOT NULL AUTO_INCREMENT, `phid` varchar(64) BINARY NOT NULL, @@ -48,4 +46,3 @@ PRIMARY KEY (`id`), UNIQUE KEY `token` (`token`) ) ENGINE=InnoDB; - Index: resources/sql/patches/108.oauthscope.sql =================================================================== --- resources/sql/patches/108.oauthscope.sql +++ resources/sql/patches/108.oauthscope.sql @@ -3,4 +3,3 @@ ALTER TABLE `{$NAMESPACE}_oauth_server`.`oauth_server_oauthserveraccesstoken` DROP `dateExpires`; - Index: resources/sql/patches/109.oauthclientphidkey.sql =================================================================== --- resources/sql/patches/109.oauthclientphidkey.sql +++ resources/sql/patches/109.oauthclientphidkey.sql @@ -1,3 +1,2 @@ ALTER TABLE `{$NAMESPACE}_oauth_server`.`oauth_server_oauthserverclient` ADD KEY `creatorPHID` (`creatorPHID`) - Index: resources/sql/patches/110.commitaudit.sql =================================================================== --- resources/sql/patches/110.commitaudit.sql +++ resources/sql/patches/110.commitaudit.sql @@ -8,4 +8,4 @@ ADD auditStatus INT UNSIGNED NOT NULL; ALTER TABLE {$NAMESPACE}_repository.repository_commit - ADD KEY (authorPHID, auditStatus, epoch); \ No newline at end of file + ADD KEY (authorPHID, auditStatus, epoch); Index: resources/sql/patches/112.oauthaccesscoderedirecturi.sql =================================================================== --- resources/sql/patches/112.oauthaccesscoderedirecturi.sql +++ resources/sql/patches/112.oauthaccesscoderedirecturi.sql @@ -1,3 +1,2 @@ ALTER TABLE `{$NAMESPACE}_oauth_server`.`oauth_server_oauthserverauthorizationcode` ADD `redirectURI` varchar(255) NOT NULL - Index: resources/sql/patches/116.utf8-backup-first-expect-wait.sql =================================================================== --- resources/sql/patches/116.utf8-backup-first-expect-wait.sql +++ resources/sql/patches/116.utf8-backup-first-expect-wait.sql @@ -1123,6 +1123,3 @@ MODIFY `authorPHID` varchar(64) COLLATE utf8_bin, MODIFY `input` longtext COLLATE utf8_bin NOT NULL, MODIFY `stdout` longtext COLLATE utf8_bin NOT NULL; - - - Index: resources/sql/patches/120.noop.sql =================================================================== --- resources/sql/patches/120.noop.sql +++ resources/sql/patches/120.noop.sql @@ -1,2 +1,2 @@ /* Do nothing, patch 121 got committed before there was a patch 120. */ -SELECT 1; \ No newline at end of file +SELECT 1; Index: resources/sql/patches/122.flag.sql =================================================================== --- resources/sql/patches/122.flag.sql +++ resources/sql/patches/122.flag.sql @@ -1,5 +1,3 @@ - - CREATE TABLE {$NAMESPACE}_flag.flag ( id INT UNSIGNED NOT NULL AUTO_INCREMENT PRIMARY KEY, ownerPHID varchar(64) COLLATE utf8_bin NOT NULL, @@ -13,4 +11,4 @@ UNIQUE KEY (ownerPHID, type, objectPHID), KEY (objectPHID) -) ENGINE=InnoDB; \ No newline at end of file +) ENGINE=InnoDB; Index: resources/sql/patches/124.subpriority.sql =================================================================== --- resources/sql/patches/124.subpriority.sql +++ resources/sql/patches/124.subpriority.sql @@ -7,5 +7,3 @@ /* Seed the subpriority column with reasonable values that keep order stable. */ UPDATE {$NAMESPACE}_maniphest.maniphest_task SET subpriority = (UNIX_TIMESTAMP() - dateModified); - - Index: resources/sql/patches/128.phabricatorcom.sql =================================================================== --- resources/sql/patches/128.phabricatorcom.sql +++ resources/sql/patches/128.phabricatorcom.sql @@ -1 +1 @@ -/* This used to be a "directory" update. */; \ No newline at end of file +/* This used to be a "directory" update. */; Index: resources/sql/patches/132.phame.sql =================================================================== --- resources/sql/patches/132.phame.sql +++ resources/sql/patches/132.phame.sql @@ -1,5 +1,3 @@ - - CREATE TABLE `{$NAMESPACE}_phame`.`phame_post` ( `id` INT UNSIGNED NOT NULL AUTO_INCREMENT PRIMARY KEY, `phid` VARCHAR(64) BINARY NOT NULL COLLATE utf8_bin, Index: resources/sql/patches/20121209.pholioxactions.sql =================================================================== --- resources/sql/patches/20121209.pholioxactions.sql +++ resources/sql/patches/20121209.pholioxactions.sql @@ -48,4 +48,3 @@ UNIQUE KEY `key_draft` (authorPHID, mockID, transactionPHID) ) ENGINE=InnoDB, COLLATE utf8_general_ci; - Index: resources/sql/patches/20130111.conpherence.sql =================================================================== --- resources/sql/patches/20130111.conpherence.sql +++ resources/sql/patches/20130111.conpherence.sql @@ -1,4 +1,3 @@ - CREATE TABLE {$NAMESPACE}_conpherence.conpherence_thread ( id INT UNSIGNED NOT NULL PRIMARY KEY AUTO_INCREMENT, phid VARCHAR(64) NOT NULL COLLATE utf8_bin, @@ -80,4 +79,3 @@ UNIQUE KEY `key_draft` (authorPHID, conpherencePHID, transactionPHID) ) ENGINE=InnoDB, COLLATE utf8_general_ci; - Index: resources/sql/patches/20130127.altheraldtranscript.sql =================================================================== --- resources/sql/patches/20130127.altheraldtranscript.sql +++ resources/sql/patches/20130127.altheraldtranscript.sql @@ -1,3 +1,2 @@ ALTER TABLE `{$NAMESPACE}_herald`.`herald_transcript` DROP `psth`; - Index: resources/sql/patches/20130131.conpherencepics.sql =================================================================== --- resources/sql/patches/20130131.conpherencepics.sql +++ resources/sql/patches/20130131.conpherencepics.sql @@ -1,6 +1,6 @@ -ALTER TABLE {$NAMESPACE}_conpherence.conpherence_thread +ALTER TABLE {$NAMESPACE}_conpherence.conpherence_thread DROP imagePHID, ADD imagePHIDs LONGTEXT COLLATE utf8_bin NOT NULL AFTER title; -UPDATE {$NAMESPACE}_conpherence.conpherence_thread +UPDATE {$NAMESPACE}_conpherence.conpherence_thread SET imagePHIDs = '{}' WHERE imagePHIDs = ''; Index: resources/sql/patches/20130214.chatlogchannel.sql =================================================================== --- resources/sql/patches/20130214.chatlogchannel.sql +++ resources/sql/patches/20130214.chatlogchannel.sql @@ -1,4 +1,3 @@ - CREATE TABLE {$NAMESPACE}_chatlog.chatlog_channel ( id INT UNSIGNED NOT NULL PRIMARY KEY AUTO_INCREMENT, serviceName VARCHAR(64) COLLATE utf8_bin NOT NULL, Index: resources/sql/patches/20130215.phabricatorfileaddttl.sql =================================================================== --- resources/sql/patches/20130215.phabricatorfileaddttl.sql +++ resources/sql/patches/20130215.phabricatorfileaddttl.sql @@ -1,3 +1,3 @@ -ALTER TABLE {$NAMESPACE}_file.file - ADD ttl INT(10) UNSIGNED DEFAULT NULL, +ALTER TABLE {$NAMESPACE}_file.file + ADD ttl INT(10) UNSIGNED DEFAULT NULL, ADD KEY key_ttl (ttl); Index: resources/sql/patches/20130317.phrictionedge.sql =================================================================== --- resources/sql/patches/20130317.phrictionedge.sql +++ resources/sql/patches/20130317.phrictionedge.sql @@ -13,4 +13,3 @@ id INT UNSIGNED NOT NULL PRIMARY KEY AUTO_INCREMENT, data LONGTEXT NOT NULL COLLATE utf8_bin ) ENGINE=InnoDB, COLLATE utf8_general_ci; - Index: resources/sql/patches/20130320.phlux.sql =================================================================== --- resources/sql/patches/20130320.phlux.sql +++ resources/sql/patches/20130320.phlux.sql @@ -29,4 +29,3 @@ UNIQUE KEY `key_phid` (phid), KEY `key_object` (objectPHID) ) ENGINE=InnoDB DEFAULT CHARSET=utf8; - Index: resources/sql/patches/20130322.phortune.sql =================================================================== --- resources/sql/patches/20130322.phortune.sql +++ resources/sql/patches/20130322.phortune.sql @@ -43,4 +43,3 @@ id INT UNSIGNED NOT NULL PRIMARY KEY AUTO_INCREMENT, data LONGTEXT NOT NULL COLLATE utf8_bin ) ENGINE=InnoDB DEFAULT CHARSET=utf8; - Index: resources/sql/patches/20130417.externalaccount.sql =================================================================== --- resources/sql/patches/20130417.externalaccount.sql +++ resources/sql/patches/20130417.externalaccount.sql @@ -1,4 +1,3 @@ - CREATE TABLE {$NAMESPACE}_user.externalaccount ( id INT UNSIGNED NOT NULL PRIMARY KEY AUTO_INCREMENT, phid VARCHAR(64) COLLATE utf8_bin NOT NULL UNIQUE KEY, Index: resources/sql/patches/20130519.diviner.sql =================================================================== --- resources/sql/patches/20130519.diviner.sql +++ resources/sql/patches/20130519.diviner.sql @@ -34,5 +34,3 @@ atomData LONGTEXT NOT NULL COLLATE utf8_bin, UNIQUE KEY (symbolPHID) ) ENGINE=InnoDB, DEFAULT CHARSET = utf8; - - Index: resources/sql/patches/20130606.userxactions.sql =================================================================== --- resources/sql/patches/20130606.userxactions.sql +++ resources/sql/patches/20130606.userxactions.sql @@ -19,5 +19,3 @@ KEY `key_object` (objectPHID) ) ENGINE=InnoDB, COLLATE utf8_general_ci; - - Index: resources/sql/patches/20130620.diffxactions.sql =================================================================== --- resources/sql/patches/20130620.diffxactions.sql +++ resources/sql/patches/20130620.diffxactions.sql @@ -48,4 +48,3 @@ UNIQUE KEY `key_draft` (authorPHID, revisionPHID, transactionPHID) ) ENGINE=InnoDB, COLLATE utf8_general_ci; - Index: resources/sql/patches/20130622.doorkeeper.sql =================================================================== --- resources/sql/patches/20130622.doorkeeper.sql +++ resources/sql/patches/20130622.doorkeeper.sql @@ -32,4 +32,3 @@ id INT UNSIGNED NOT NULL PRIMARY KEY AUTO_INCREMENT, data LONGTEXT NOT NULL COLLATE utf8_bin ) ENGINE=InnoDB, COLLATE utf8_general_ci; - Index: resources/sql/patches/20130628.legalpadv0.sql =================================================================== --- resources/sql/patches/20130628.legalpadv0.sql +++ resources/sql/patches/20130628.legalpadv0.sql @@ -101,4 +101,3 @@ UNIQUE KEY `key_draft` (authorPHID, documentID, transactionPHID) ) ENGINE=InnoDB, COLLATE utf8_general_ci; - Index: resources/sql/patches/20130723.taskstarttime.sql =================================================================== --- resources/sql/patches/20130723.taskstarttime.sql +++ resources/sql/patches/20130723.taskstarttime.sql @@ -3,4 +3,3 @@ ALTER TABLE {$NAMESPACE}_worker.worker_activetask ADD KEY `key_failuretime` (`failureTime`); - Index: resources/sql/patches/20130726.ponderxactions.sql =================================================================== --- resources/sql/patches/20130726.ponderxactions.sql +++ resources/sql/patches/20130726.ponderxactions.sql @@ -79,4 +79,3 @@ UNIQUE KEY `key_version` (transactionPHID, commentVersion) ) ENGINE=InnoDB, COLLATE utf8_general_ci; - Index: resources/sql/patches/20130820.filexactions.sql =================================================================== --- resources/sql/patches/20130820.filexactions.sql +++ resources/sql/patches/20130820.filexactions.sql @@ -39,4 +39,3 @@ UNIQUE KEY `key_draft` (authorPHID, transactionPHID) ) ENGINE=InnoDB, COLLATE utf8_general_ci; - Index: resources/sql/patches/20130926.dinkeys.sql =================================================================== --- resources/sql/patches/20130926.dinkeys.sql +++ resources/sql/patches/20130926.dinkeys.sql @@ -12,4 +12,3 @@ ALTER TABLE {$NAMESPACE}_differential.differential_transaction_comment ADD KEY `key_legacy` (legacyCommentID); - Index: resources/sql/patches/20131030.repostatusmessage.sql =================================================================== --- resources/sql/patches/20131030.repostatusmessage.sql +++ resources/sql/patches/20131030.repostatusmessage.sql @@ -7,4 +7,3 @@ epoch INT UNSIGNED NOT NULL, UNIQUE KEY (repositoryID, statusType) ) ENGINE=InnoDB, CHARSET utf8; - Index: resources/sql/patches/20131224.harbormanual.sql =================================================================== --- resources/sql/patches/20131224.harbormanual.sql +++ resources/sql/patches/20131224.harbormanual.sql @@ -3,4 +3,3 @@ ALTER TABLE {$NAMESPACE}_harbormaster.harbormaster_buildable ADD KEY `key_manual` (isManualBuildable); - Index: resources/sql/patches/20131227.heraldobject.sql =================================================================== --- resources/sql/patches/20131227.heraldobject.sql +++ resources/sql/patches/20131227.heraldobject.sql @@ -3,4 +3,3 @@ ALTER TABLE {$NAMESPACE}_herald.herald_rule ADD KEY `key_trigger` (triggerObjectPHID); - Index: resources/sql/patches/20131302.maniphestvalue.sql =================================================================== --- resources/sql/patches/20131302.maniphestvalue.sql +++ resources/sql/patches/20131302.maniphestvalue.sql @@ -1,3 +1,2 @@ ALTER TABLE {$NAMESPACE}_maniphest.maniphest_taskauxiliarystorage MODIFY value LONGTEXT COLLATE utf8_bin; - Index: resources/sql/patches/emailtableremove.sql =================================================================== --- resources/sql/patches/emailtableremove.sql +++ resources/sql/patches/emailtableremove.sql @@ -1 +1 @@ -ALTER TABLE {$NAMESPACE}_user.user DROP email; \ No newline at end of file +ALTER TABLE {$NAMESPACE}_user.user DROP email; Index: resources/sql/patches/phameblog.sql =================================================================== --- resources/sql/patches/phameblog.sql +++ resources/sql/patches/phameblog.sql @@ -28,4 +28,3 @@ ALTER TABLE {$NAMESPACE}_phame.phame_post ADD KEY `instancePosts` (`visibility`, `datePublished`, `id`); - Index: resources/sql/patches/phamedomain.sql =================================================================== --- resources/sql/patches/phamedomain.sql +++ resources/sql/patches/phamedomain.sql @@ -1,4 +1,4 @@ ALTER TABLE `{$NAMESPACE}_phame`.`phame_blog` - ADD COLUMN `domain` varchar(255) CHARACTER SET utf8 COLLATE utf8_bin + ADD COLUMN `domain` varchar(255) CHARACTER SET utf8 COLLATE utf8_bin AFTER `description`, ADD UNIQUE KEY (`domain`); Index: resources/sql/patches/phamepolicy.sql =================================================================== --- resources/sql/patches/phamepolicy.sql +++ resources/sql/patches/phamepolicy.sql @@ -15,4 +15,3 @@ UPDATE `{$NAMESPACE}_phame`.`phame_blog` SET joinPolicy = 'users' WHERE joinPolicy IS NULL; - Index: resources/sql/patches/phiddrop.sql =================================================================== --- resources/sql/patches/phiddrop.sql +++ resources/sql/patches/phiddrop.sql @@ -1 +1 @@ -DROP DATABASE IF EXISTS {$NAMESPACE}_phid; \ No newline at end of file +DROP DATABASE IF EXISTS {$NAMESPACE}_phid; Index: resources/sql/patches/ponder-comments.sql =================================================================== --- resources/sql/patches/ponder-comments.sql +++ resources/sql/patches/ponder-comments.sql @@ -8,4 +8,4 @@ PRIMARY KEY (`id`), KEY `authorPHID` (`authorPHID`), KEY `targetPHID` (`targetPHID`) -) ENGINE=InnoDB DEFAULT CHARSET=utf8; \ No newline at end of file +) ENGINE=InnoDB DEFAULT CHARSET=utf8; Index: resources/sql/patches/ponder.sql =================================================================== --- resources/sql/patches/ponder.sql +++ resources/sql/patches/ponder.sql @@ -47,4 +47,4 @@ `id` int(10) unsigned NOT NULL AUTO_INCREMENT, `data` longtext CHARACTER SET utf8 COLLATE utf8_bin NOT NULL, PRIMARY KEY (`id`) -) ENGINE=InnoDB DEFAULT CHARSET=utf8; \ No newline at end of file +) ENGINE=InnoDB DEFAULT CHARSET=utf8; Index: scripts/differential/destroy_revision.php =================================================================== --- scripts/differential/destroy_revision.php +++ scripts/differential/destroy_revision.php @@ -49,4 +49,3 @@ $revision->delete(); echo "OK, destroyed revision.\n"; - Index: scripts/mail/mail_handler.php =================================================================== --- scripts/mail/mail_handler.php +++ scripts/mail/mail_handler.php @@ -92,5 +92,3 @@ throw $e; } - - Index: scripts/mail/manage_mail.php =================================================================== --- scripts/mail/manage_mail.php +++ scripts/mail/manage_mail.php @@ -19,4 +19,3 @@ ->loadObjects(); $workflows[] = new PhutilHelpArgumentWorkflow(); $args->parseWorkflows($workflows); - Index: scripts/repository/test_connection.php =================================================================== --- scripts/repository/test_connection.php +++ scripts/repository/test_connection.php @@ -3,4 +3,3 @@ echo "This script is obsolete. Use `bin/repository` to manage repositories.\n"; exit(1); - Index: scripts/search/reindex_maniphest.php =================================================================== --- scripts/search/reindex_maniphest.php +++ scripts/search/reindex_maniphest.php @@ -13,4 +13,3 @@ echo '.'; } echo "\nDone.\n"; - Index: src/aphront/console/DarkConsoleCore.php =================================================================== --- src/aphront/console/DarkConsoleCore.php +++ src/aphront/console/DarkConsoleCore.php @@ -135,4 +135,3 @@ } } - Index: src/aphront/console/plugin/DarkConsoleServicesPlugin.php =================================================================== --- src/aphront/console/plugin/DarkConsoleServicesPlugin.php +++ src/aphront/console/plugin/DarkConsoleServicesPlugin.php @@ -293,4 +293,3 @@ return phutil_implode_html("\n", $results); } } - Index: src/aphront/console/plugin/errorlog/DarkConsoleErrorLogPluginAPI.php =================================================================== --- src/aphront/console/plugin/errorlog/DarkConsoleErrorLogPluginAPI.php +++ src/aphront/console/plugin/errorlog/DarkConsoleErrorLogPluginAPI.php @@ -76,4 +76,3 @@ } } - Index: src/aphront/console/plugin/event/DarkConsoleEventPluginAPI.php =================================================================== --- src/aphront/console/plugin/event/DarkConsoleEventPluginAPI.php +++ src/aphront/console/plugin/event/DarkConsoleEventPluginAPI.php @@ -28,4 +28,3 @@ } } - Index: src/applications/audit/application/PhabricatorApplicationAudit.php =================================================================== --- src/applications/audit/application/PhabricatorApplicationAudit.php +++ src/applications/audit/application/PhabricatorApplicationAudit.php @@ -78,4 +78,3 @@ } } - Index: src/applications/audit/events/AuditActionMenuEventListener.php =================================================================== --- src/applications/audit/events/AuditActionMenuEventListener.php +++ src/applications/audit/events/AuditActionMenuEventListener.php @@ -43,4 +43,3 @@ } } - Index: src/applications/auth/storage/PhabricatorAuthProviderConfigTransaction.php =================================================================== --- src/applications/auth/storage/PhabricatorAuthProviderConfigTransaction.php +++ src/applications/auth/storage/PhabricatorAuthProviderConfigTransaction.php @@ -140,4 +140,3 @@ } } - Index: src/applications/base/controller/__tests__/PhabricatorApplicationTest.php =================================================================== --- src/applications/base/controller/__tests__/PhabricatorApplicationTest.php +++ src/applications/base/controller/__tests__/PhabricatorApplicationTest.php @@ -35,4 +35,3 @@ } } - Index: src/applications/chatlog/applications/PhabricatorApplicationChatLog.php =================================================================== --- src/applications/chatlog/applications/PhabricatorApplicationChatLog.php +++ src/applications/chatlog/applications/PhabricatorApplicationChatLog.php @@ -38,4 +38,3 @@ } } - Index: src/applications/chatlog/storage/PhabricatorChatLogChannel.php =================================================================== --- src/applications/chatlog/storage/PhabricatorChatLogChannel.php +++ src/applications/chatlog/storage/PhabricatorChatLogChannel.php @@ -37,4 +37,3 @@ } } - Index: src/applications/config/check/PhabricatorSetupCheckImagemagick.php =================================================================== --- src/applications/config/check/PhabricatorSetupCheckImagemagick.php +++ src/applications/config/check/PhabricatorSetupCheckImagemagick.php @@ -21,4 +21,3 @@ } } } - Index: src/applications/config/storage/PhabricatorConfigTransaction.php =================================================================== --- src/applications/config/storage/PhabricatorConfigTransaction.php +++ src/applications/config/storage/PhabricatorConfigTransaction.php @@ -116,4 +116,3 @@ } } - Index: src/applications/conpherence/events/ConpherenceActionMenuEventListener.php =================================================================== --- src/applications/conpherence/events/ConpherenceActionMenuEventListener.php +++ src/applications/conpherence/events/ConpherenceActionMenuEventListener.php @@ -42,4 +42,3 @@ } } - Index: src/applications/conpherence/events/ConpherenceHovercardEventListener.php =================================================================== --- src/applications/conpherence/events/ConpherenceHovercardEventListener.php +++ src/applications/conpherence/events/ConpherenceHovercardEventListener.php @@ -39,4 +39,3 @@ } } - Index: src/applications/differential/application/PhabricatorApplicationDifferential.php =================================================================== --- src/applications/differential/application/PhabricatorApplicationDifferential.php +++ src/applications/differential/application/PhabricatorApplicationDifferential.php @@ -132,4 +132,3 @@ } } - Index: src/applications/differential/controller/DifferentialRevisionLandController.php =================================================================== --- src/applications/differential/controller/DifferentialRevisionLandController.php +++ src/applications/differential/controller/DifferentialRevisionLandController.php @@ -151,4 +151,3 @@ return $lock; } } - Index: src/applications/differential/editor/DifferentialRevisionEditor.php =================================================================== --- src/applications/differential/editor/DifferentialRevisionEditor.php +++ src/applications/differential/editor/DifferentialRevisionEditor.php @@ -994,4 +994,3 @@ } } - Index: src/applications/differential/event/DifferentialActionMenuEventListener.php =================================================================== --- src/applications/differential/event/DifferentialActionMenuEventListener.php +++ src/applications/differential/event/DifferentialActionMenuEventListener.php @@ -67,4 +67,3 @@ } } - Index: src/applications/differential/field/selector/DifferentialDefaultFieldSelector.php =================================================================== --- src/applications/differential/field/selector/DifferentialDefaultFieldSelector.php +++ src/applications/differential/field/selector/DifferentialDefaultFieldSelector.php @@ -93,4 +93,3 @@ } } - Index: src/applications/differential/mail/DifferentialExceptionMail.php =================================================================== --- src/applications/differential/mail/DifferentialExceptionMail.php +++ src/applications/differential/mail/DifferentialExceptionMail.php @@ -43,5 +43,3 @@ } } - - Index: src/applications/differential/parser/__tests__/DifferentialHunkParserTestCase.php =================================================================== --- src/applications/differential/parser/__tests__/DifferentialHunkParserTestCase.php +++ src/applications/differential/parser/__tests__/DifferentialHunkParserTestCase.php @@ -280,4 +280,3 @@ } } - Index: src/applications/differential/storage/DifferentialCustomFieldNumericIndex.php =================================================================== --- src/applications/differential/storage/DifferentialCustomFieldNumericIndex.php +++ src/applications/differential/storage/DifferentialCustomFieldNumericIndex.php @@ -8,4 +8,3 @@ } } - Index: src/applications/differential/storage/DifferentialCustomFieldStorage.php =================================================================== --- src/applications/differential/storage/DifferentialCustomFieldStorage.php +++ src/applications/differential/storage/DifferentialCustomFieldStorage.php @@ -8,4 +8,3 @@ } } - Index: src/applications/differential/storage/DifferentialCustomFieldStringIndex.php =================================================================== --- src/applications/differential/storage/DifferentialCustomFieldStringIndex.php +++ src/applications/differential/storage/DifferentialCustomFieldStringIndex.php @@ -8,4 +8,3 @@ } } - Index: src/applications/differential/view/DifferentialChangesetFileTreeSideNavBuilder.php =================================================================== --- src/applications/differential/view/DifferentialChangesetFileTreeSideNavBuilder.php +++ src/applications/differential/view/DifferentialChangesetFileTreeSideNavBuilder.php @@ -140,4 +140,3 @@ } } - Index: src/applications/diffusion/controller/DiffusionServeController.php =================================================================== --- src/applications/diffusion/controller/DiffusionServeController.php +++ src/applications/diffusion/controller/DiffusionServeController.php @@ -601,4 +601,3 @@ } } - Index: src/applications/diffusion/events/DiffusionHovercardEventListener.php =================================================================== --- src/applications/diffusion/events/DiffusionHovercardEventListener.php +++ src/applications/diffusion/events/DiffusionHovercardEventListener.php @@ -73,4 +73,3 @@ } } - Index: src/applications/diffusion/query/pathid/__tests__/DiffusionPathQueryTestCase.php =================================================================== --- src/applications/diffusion/query/pathid/__tests__/DiffusionPathQueryTestCase.php +++ src/applications/diffusion/query/pathid/__tests__/DiffusionPathQueryTestCase.php @@ -40,4 +40,3 @@ } } - Index: src/applications/diviner/application/PhabricatorApplicationDiviner.php =================================================================== --- src/applications/diviner/application/PhabricatorApplicationDiviner.php +++ src/applications/diviner/application/PhabricatorApplicationDiviner.php @@ -72,4 +72,3 @@ } - Index: src/applications/diviner/atomizer/DivinerPHPAtomizer.php =================================================================== --- src/applications/diviner/atomizer/DivinerPHPAtomizer.php +++ src/applications/diviner/atomizer/DivinerPHPAtomizer.php @@ -316,4 +316,3 @@ } } - Index: src/applications/drydock/worker/DrydockAllocatorWorker.php =================================================================== --- src/applications/drydock/worker/DrydockAllocatorWorker.php +++ src/applications/drydock/worker/DrydockAllocatorWorker.php @@ -179,5 +179,3 @@ } } - - Index: src/applications/feed/application/PhabricatorApplicationFeed.php =================================================================== --- src/applications/feed/application/PhabricatorApplicationFeed.php +++ src/applications/feed/application/PhabricatorApplicationFeed.php @@ -33,4 +33,3 @@ } } - Index: src/applications/flag/application/PhabricatorApplicationFlags.php =================================================================== --- src/applications/flag/application/PhabricatorApplicationFlags.php +++ src/applications/flag/application/PhabricatorApplicationFlags.php @@ -58,4 +58,3 @@ } } - Index: src/applications/flag/events/PhabricatorFlagsUIEventListener.php =================================================================== --- src/applications/flag/events/PhabricatorFlagsUIEventListener.php +++ src/applications/flag/events/PhabricatorFlagsUIEventListener.php @@ -59,4 +59,3 @@ } } - Index: src/applications/herald/adapter/HeraldAdapter.php =================================================================== --- src/applications/herald/adapter/HeraldAdapter.php +++ src/applications/herald/adapter/HeraldAdapter.php @@ -1077,4 +1077,3 @@ } } - Index: src/applications/herald/engine/HeraldEffect.php =================================================================== --- src/applications/herald/engine/HeraldEffect.php +++ src/applications/herald/engine/HeraldEffect.php @@ -76,4 +76,3 @@ } } - Index: src/applications/herald/storage/HeraldRuleTransactionComment.php =================================================================== --- src/applications/herald/storage/HeraldRuleTransactionComment.php +++ src/applications/herald/storage/HeraldRuleTransactionComment.php @@ -8,4 +8,3 @@ } } - Index: src/applications/herald/storage/__tests__/HeraldTranscriptTestCase.php =================================================================== --- src/applications/herald/storage/__tests__/HeraldTranscriptTestCase.php +++ src/applications/herald/storage/__tests__/HeraldTranscriptTestCase.php @@ -44,4 +44,4 @@ implode('!', $truncated_fields['ma'])); } -} \ No newline at end of file +} Index: src/applications/macro/storage/PhabricatorFileImageMacro.php =================================================================== --- src/applications/macro/storage/PhabricatorFileImageMacro.php +++ src/applications/macro/storage/PhabricatorFileImageMacro.php @@ -110,4 +110,3 @@ } } - Index: src/applications/macro/storage/PhabricatorMacroTransaction.php =================================================================== --- src/applications/macro/storage/PhabricatorMacroTransaction.php +++ src/applications/macro/storage/PhabricatorMacroTransaction.php @@ -301,4 +301,3 @@ } - Index: src/applications/macro/storage/PhabricatorMacroTransactionComment.php =================================================================== --- src/applications/macro/storage/PhabricatorMacroTransactionComment.php +++ src/applications/macro/storage/PhabricatorMacroTransactionComment.php @@ -8,4 +8,3 @@ } } - Index: src/applications/maniphest/application/PhabricatorApplicationManiphest.php =================================================================== --- src/applications/maniphest/application/PhabricatorApplicationManiphest.php +++ src/applications/maniphest/application/PhabricatorApplicationManiphest.php @@ -124,4 +124,3 @@ } } - Index: src/applications/maniphest/storage/ManiphestCustomFieldNumericIndex.php =================================================================== --- src/applications/maniphest/storage/ManiphestCustomFieldNumericIndex.php +++ src/applications/maniphest/storage/ManiphestCustomFieldNumericIndex.php @@ -8,4 +8,3 @@ } } - Index: src/applications/maniphest/storage/ManiphestCustomFieldStorage.php =================================================================== --- src/applications/maniphest/storage/ManiphestCustomFieldStorage.php +++ src/applications/maniphest/storage/ManiphestCustomFieldStorage.php @@ -8,4 +8,3 @@ } } - Index: src/applications/maniphest/storage/ManiphestCustomFieldStringIndex.php =================================================================== --- src/applications/maniphest/storage/ManiphestCustomFieldStringIndex.php +++ src/applications/maniphest/storage/ManiphestCustomFieldStringIndex.php @@ -8,4 +8,3 @@ } } - Index: src/applications/maniphest/storage/ManiphestTransaction.php =================================================================== --- src/applications/maniphest/storage/ManiphestTransaction.php +++ src/applications/maniphest/storage/ManiphestTransaction.php @@ -667,4 +667,3 @@ } - Index: src/applications/meta/application/PhabricatorApplicationApplications.php =================================================================== --- src/applications/meta/application/PhabricatorApplicationApplications.php +++ src/applications/meta/application/PhabricatorApplicationApplications.php @@ -43,4 +43,3 @@ } } - Index: src/applications/meta/controller/PhabricatorApplicationUninstallController.php =================================================================== --- src/applications/meta/controller/PhabricatorApplicationUninstallController.php +++ src/applications/meta/controller/PhabricatorApplicationUninstallController.php @@ -90,4 +90,3 @@ } } - Index: src/applications/metamta/adapter/PhabricatorMailImplementationSendGridAdapter.php =================================================================== --- src/applications/metamta/adapter/PhabricatorMailImplementationSendGridAdapter.php +++ src/applications/metamta/adapter/PhabricatorMailImplementationSendGridAdapter.php @@ -155,4 +155,3 @@ } } - Index: src/applications/nuance/application/PhabricatorApplicationNuance.php =================================================================== --- src/applications/nuance/application/PhabricatorApplicationNuance.php +++ src/applications/nuance/application/PhabricatorApplicationNuance.php @@ -70,4 +70,3 @@ } } - Index: src/applications/nuance/query/NuanceItemQuery.php =================================================================== --- src/applications/nuance/query/NuanceItemQuery.php +++ src/applications/nuance/query/NuanceItemQuery.php @@ -68,4 +68,3 @@ } } - Index: src/applications/nuance/query/NuanceQuery.php =================================================================== --- src/applications/nuance/query/NuanceQuery.php +++ src/applications/nuance/query/NuanceQuery.php @@ -8,4 +8,3 @@ } } - Index: src/applications/nuance/query/NuanceQueueQuery.php =================================================================== --- src/applications/nuance/query/NuanceQueueQuery.php +++ src/applications/nuance/query/NuanceQueueQuery.php @@ -54,4 +54,3 @@ } } - Index: src/applications/nuance/query/NuanceRequestorQuery.php =================================================================== --- src/applications/nuance/query/NuanceRequestorQuery.php +++ src/applications/nuance/query/NuanceRequestorQuery.php @@ -54,4 +54,3 @@ } } - Index: src/applications/nuance/source/NuanceSourceDefinition.php =================================================================== --- src/applications/nuance/source/NuanceSourceDefinition.php +++ src/applications/nuance/source/NuanceSourceDefinition.php @@ -260,4 +260,3 @@ abstract public function renderListView(); } - Index: src/applications/owners/mail/OwnersPackageReplyHandler.php =================================================================== --- src/applications/owners/mail/OwnersPackageReplyHandler.php +++ src/applications/owners/mail/OwnersPackageReplyHandler.php @@ -28,5 +28,3 @@ return; } } - - Index: src/applications/people/storage/PhabricatorUserConfiguredCustomFieldStorage.php =================================================================== --- src/applications/people/storage/PhabricatorUserConfiguredCustomFieldStorage.php +++ src/applications/people/storage/PhabricatorUserConfiguredCustomFieldStorage.php @@ -8,4 +8,3 @@ } } - Index: src/applications/people/storage/PhabricatorUserCustomFieldNumericIndex.php =================================================================== --- src/applications/people/storage/PhabricatorUserCustomFieldNumericIndex.php +++ src/applications/people/storage/PhabricatorUserCustomFieldNumericIndex.php @@ -8,4 +8,3 @@ } } - Index: src/applications/people/storage/PhabricatorUserCustomFieldStringIndex.php =================================================================== --- src/applications/people/storage/PhabricatorUserCustomFieldStringIndex.php +++ src/applications/people/storage/PhabricatorUserCustomFieldStringIndex.php @@ -8,4 +8,3 @@ } } - Index: src/applications/people/storage/PhabricatorUserTransaction.php =================================================================== --- src/applications/people/storage/PhabricatorUserTransaction.php +++ src/applications/people/storage/PhabricatorUserTransaction.php @@ -16,4 +16,3 @@ } } - Index: src/applications/pholio/event/PholioActionMenuEventListener.php =================================================================== --- src/applications/pholio/event/PholioActionMenuEventListener.php +++ src/applications/pholio/event/PholioActionMenuEventListener.php @@ -49,4 +49,3 @@ } } - Index: src/applications/phragment/application/PhabricatorApplicationPhragment.php =================================================================== --- src/applications/phragment/application/PhabricatorApplicationPhragment.php +++ src/applications/phragment/application/PhabricatorApplicationPhragment.php @@ -65,4 +65,3 @@ } } - Index: src/applications/phrequent/application/PhabricatorApplicationPhrequent.php =================================================================== --- src/applications/phrequent/application/PhabricatorApplicationPhrequent.php +++ src/applications/phrequent/application/PhabricatorApplicationPhrequent.php @@ -59,4 +59,3 @@ } } - Index: src/applications/phrequent/query/PhrequentSearchEngine.php =================================================================== --- src/applications/phrequent/query/PhrequentSearchEngine.php +++ src/applications/phrequent/query/PhrequentSearchEngine.php @@ -111,4 +111,3 @@ } } - Index: src/applications/phriction/application/PhabricatorApplicationPhriction.php =================================================================== --- src/applications/phriction/application/PhabricatorApplicationPhriction.php +++ src/applications/phriction/application/PhabricatorApplicationPhriction.php @@ -67,4 +67,3 @@ } } - Index: src/applications/policy/application/PhabricatorApplicationPolicy.php =================================================================== --- src/applications/policy/application/PhabricatorApplicationPolicy.php +++ src/applications/policy/application/PhabricatorApplicationPolicy.php @@ -21,4 +21,3 @@ } } - Index: src/applications/policy/capability/PhabricatorPolicyCapability.php =================================================================== --- src/applications/policy/capability/PhabricatorPolicyCapability.php +++ src/applications/policy/capability/PhabricatorPolicyCapability.php @@ -68,5 +68,3 @@ } } - - Index: src/applications/policy/query/PhabricatorPolicyQuery.php =================================================================== --- src/applications/policy/query/PhabricatorPolicyQuery.php +++ src/applications/policy/query/PhabricatorPolicyQuery.php @@ -234,4 +234,3 @@ } } - Index: src/applications/ponder/remarkup/PonderRemarkupRule.php =================================================================== --- src/applications/ponder/remarkup/PonderRemarkupRule.php +++ src/applications/ponder/remarkup/PonderRemarkupRule.php @@ -28,4 +28,3 @@ } } - Index: src/applications/ponder/storage/PonderAnswerTransaction.php =================================================================== --- src/applications/ponder/storage/PonderAnswerTransaction.php +++ src/applications/ponder/storage/PonderAnswerTransaction.php @@ -102,4 +102,3 @@ } } - Index: src/applications/ponder/storage/PonderAnswerTransactionComment.php =================================================================== --- src/applications/ponder/storage/PonderAnswerTransactionComment.php +++ src/applications/ponder/storage/PonderAnswerTransactionComment.php @@ -8,4 +8,3 @@ } } - Index: src/applications/ponder/storage/PonderComment.php =================================================================== --- src/applications/ponder/storage/PonderComment.php +++ src/applications/ponder/storage/PonderComment.php @@ -38,4 +38,3 @@ return self::MARKUP_FIELD_CONTENT; } } - Index: src/applications/ponder/storage/PonderQuestionTransactionComment.php =================================================================== --- src/applications/ponder/storage/PonderQuestionTransactionComment.php +++ src/applications/ponder/storage/PonderQuestionTransactionComment.php @@ -8,4 +8,3 @@ } } - Index: src/applications/project/storage/PhabricatorProjectCustomFieldNumericIndex.php =================================================================== --- src/applications/project/storage/PhabricatorProjectCustomFieldNumericIndex.php +++ src/applications/project/storage/PhabricatorProjectCustomFieldNumericIndex.php @@ -8,4 +8,3 @@ } } - Index: src/applications/project/storage/PhabricatorProjectCustomFieldStorage.php =================================================================== --- src/applications/project/storage/PhabricatorProjectCustomFieldStorage.php +++ src/applications/project/storage/PhabricatorProjectCustomFieldStorage.php @@ -8,4 +8,3 @@ } } - Index: src/applications/project/storage/PhabricatorProjectCustomFieldStringIndex.php =================================================================== --- src/applications/project/storage/PhabricatorProjectCustomFieldStringIndex.php +++ src/applications/project/storage/PhabricatorProjectCustomFieldStringIndex.php @@ -8,4 +8,3 @@ } } - Index: src/applications/releeph/storage/ReleephBranchTransaction.php =================================================================== --- src/applications/releeph/storage/ReleephBranchTransaction.php +++ src/applications/releeph/storage/ReleephBranchTransaction.php @@ -12,4 +12,3 @@ } } - Index: src/applications/releeph/storage/ReleephProjectTransaction.php =================================================================== --- src/applications/releeph/storage/ReleephProjectTransaction.php +++ src/applications/releeph/storage/ReleephProjectTransaction.php @@ -12,4 +12,3 @@ } } - Index: src/applications/repository/search/PhabricatorRepositoryCommitSearchIndexer.php =================================================================== --- src/applications/repository/search/PhabricatorRepositoryCommitSearchIndexer.php +++ src/applications/repository/search/PhabricatorRepositoryCommitSearchIndexer.php @@ -80,4 +80,3 @@ return $doc; } } - Index: src/applications/repository/storage/PhabricatorRepositoryTransaction.php =================================================================== --- src/applications/repository/storage/PhabricatorRepositoryTransaction.php +++ src/applications/repository/storage/PhabricatorRepositoryTransaction.php @@ -388,4 +388,3 @@ } } - Index: src/applications/search/controller/PhabricatorSearchAttachController.php =================================================================== --- src/applications/search/controller/PhabricatorSearchAttachController.php +++ src/applications/search/controller/PhabricatorSearchAttachController.php @@ -26,7 +26,7 @@ $request = $this->getRequest(); $user = $request->getUser(); - $handle = id(New PhabricatorHandleQuery()) + $handle = id(new PhabricatorHandleQuery()) ->setViewer($user) ->withPHIDs(array($this->phid)) ->executeOne(); Index: src/applications/settings/panel/PhabricatorSettingsPanelConpherencePreferences.php =================================================================== --- src/applications/settings/panel/PhabricatorSettingsPanelConpherencePreferences.php +++ src/applications/settings/panel/PhabricatorSettingsPanelConpherencePreferences.php @@ -66,4 +66,3 @@ ); } } - Index: src/applications/settings/panel/PhabricatorSettingsPanelDeveloperPreferences.php =================================================================== --- src/applications/settings/panel/PhabricatorSettingsPanelDeveloperPreferences.php +++ src/applications/settings/panel/PhabricatorSettingsPanelDeveloperPreferences.php @@ -95,4 +95,3 @@ ); } } - Index: src/applications/settings/panel/PhabricatorSettingsPanelDiffPreferences.php =================================================================== --- src/applications/settings/panel/PhabricatorSettingsPanelDiffPreferences.php +++ src/applications/settings/panel/PhabricatorSettingsPanelDiffPreferences.php @@ -68,4 +68,3 @@ ); } } - Index: src/applications/settings/panel/PhabricatorSettingsPanelDisplayPreferences.php =================================================================== --- src/applications/settings/panel/PhabricatorSettingsPanelDisplayPreferences.php +++ src/applications/settings/panel/PhabricatorSettingsPanelDisplayPreferences.php @@ -147,4 +147,3 @@ ); } } - Index: src/applications/settings/panel/PhabricatorSettingsPanelHomePreferences.php =================================================================== --- src/applications/settings/panel/PhabricatorSettingsPanelHomePreferences.php +++ src/applications/settings/panel/PhabricatorSettingsPanelHomePreferences.php @@ -216,4 +216,3 @@ return array($header, $error_view, $form); } } - Index: src/applications/settings/panel/PhabricatorSettingsPanelSearchPreferences.php =================================================================== --- src/applications/settings/panel/PhabricatorSettingsPanelSearchPreferences.php +++ src/applications/settings/panel/PhabricatorSettingsPanelSearchPreferences.php @@ -60,4 +60,3 @@ ); } } - Index: src/applications/slowvote/storage/PhabricatorSlowvoteTransaction.php =================================================================== --- src/applications/slowvote/storage/PhabricatorSlowvoteTransaction.php +++ src/applications/slowvote/storage/PhabricatorSlowvoteTransaction.php @@ -124,4 +124,3 @@ } - Index: src/applications/slowvote/storage/PhabricatorSlowvoteTransactionComment.php =================================================================== --- src/applications/slowvote/storage/PhabricatorSlowvoteTransactionComment.php +++ src/applications/slowvote/storage/PhabricatorSlowvoteTransactionComment.php @@ -8,4 +8,3 @@ } } - Index: src/applications/subscriptions/application/PhabricatorApplicationSubscriptions.php =================================================================== --- src/applications/subscriptions/application/PhabricatorApplicationSubscriptions.php +++ src/applications/subscriptions/application/PhabricatorApplicationSubscriptions.php @@ -26,4 +26,3 @@ } } - Index: src/applications/transactions/application/PhabricatorApplicationTransactions.php =================================================================== --- src/applications/transactions/application/PhabricatorApplicationTransactions.php +++ src/applications/transactions/application/PhabricatorApplicationTransactions.php @@ -24,4 +24,3 @@ } } - Index: src/applications/transactions/view/PhabricatorApplicationTransactionCommentView.php =================================================================== --- src/applications/transactions/view/PhabricatorApplicationTransactionCommentView.php +++ src/applications/transactions/view/PhabricatorApplicationTransactionCommentView.php @@ -234,4 +234,3 @@ } } - Index: src/applications/transactions/view/PhabricatorApplicationTransactionTextDiffDetailView.php =================================================================== --- src/applications/transactions/view/PhabricatorApplicationTransactionTextDiffDetailView.php +++ src/applications/transactions/view/PhabricatorApplicationTransactionTextDiffDetailView.php @@ -54,4 +54,3 @@ } } - Index: src/applications/transactions/view/PhabricatorApplicationTransactionView.php =================================================================== --- src/applications/transactions/view/PhabricatorApplicationTransactionView.php +++ src/applications/transactions/view/PhabricatorApplicationTransactionView.php @@ -349,4 +349,3 @@ } } - Index: src/applications/typeahead/storage/PhabricatorTypeaheadResult.php =================================================================== --- src/applications/typeahead/storage/PhabricatorTypeaheadResult.php +++ src/applications/typeahead/storage/PhabricatorTypeaheadResult.php @@ -83,4 +83,3 @@ } } - Index: src/docs/user/configuration/troubleshooting_https.diviner =================================================================== --- src/docs/user/configuration/troubleshooting_https.diviner +++ src/docs/user/configuration/troubleshooting_https.diviner @@ -10,7 +10,7 @@ connection." error, this document may be able to help you diagnose and resolve the problem. -Connection negotation can fail for several reasons. The major ones are: +Connection negotiation can fail for several reasons. The major ones are: - You have not added the the Certificate Authority as a trusted authority (this is the most common problem, and usually the issue for self-signed Index: src/docs/user/contributing/php_coding_standards.diviner =================================================================== --- src/docs/user/contributing/php_coding_standards.diviner +++ src/docs/user/contributing/php_coding_standards.diviner @@ -167,4 +167,3 @@ return $this->favoriteFood; } } - Index: src/docs/user/developer/adding_new_css_and_js.diviner =================================================================== --- src/docs/user/developer/adding_new_css_and_js.diviner +++ src/docs/user/developer/adding_new_css_and_js.diviner @@ -83,4 +83,3 @@ should @{function:require_celerity_resource} a resource only if you are actually using it on a specific rendering of the page, not just because some views of the page might require it. - Index: src/docs/user/developer/unit_tests.diviner =================================================================== --- src/docs/user/developer/unit_tests.diviner +++ src/docs/user/developer/unit_tests.diviner @@ -84,4 +84,3 @@ ##self::PHABRICATOR_TESTCONFIG_ISOLATE_LISK => false## in the configuration dictionary you return. This will disable isolation entirely. STRONGLY NOT RECOMMENDED. - Index: src/docs/user/developer/using_oauthserver.diviner =================================================================== --- src/docs/user/developer/using_oauthserver.diviner +++ src/docs/user/developer/using_oauthserver.diviner @@ -5,32 +5,32 @@ = Overview = -Phabricator includes an OAuth Server which supports the -##Authorization Code Grant## flow as described in the OAuth 2.0 +Phabricator includes an OAuth Server which supports the +##Authorization Code Grant## flow as described in the OAuth 2.0 specification: http://tools.ietf.org/html/draft-ietf-oauth-v2-23 -This functionality can allow clients to integrate with a given -Phabricator instance in a secure way with granular data access. -For example, Phabricator can be used as a central identity store for any +This functionality can allow clients to integrate with a given +Phabricator instance in a secure way with granular data access. +For example, Phabricator can be used as a central identity store for any clients that implement OAuth 2.0. = Vocabulary = -- **Access token** - a token which allows a client to ask for data on -behalf of a resource owner. A given client will only be able to access +- **Access token** - a token which allows a client to ask for data on +behalf of a resource owner. A given client will only be able to access data included in the scope(s) the resource owner authorized that client for. -- **Authorization code** - a short-lived code which allows an authenticated +- **Authorization code** - a short-lived code which allows an authenticated client to ask for an access token on behalf of some resource owner. -- **Client** - this is the application or system asking for data from the +- **Client** - this is the application or system asking for data from the OAuth Server on behalf of the resource owner. -- **Resource owner** - this is the user the client and OAuth Server are +- **Resource owner** - this is the user the client and OAuth Server are concerned with on a given request. -- **Scope** - this defines a specific piece of granular data a client can -or can not access on behalf of a user. For example, if authorized for the -"whoami" scope on behalf of a given resource owner, the client can get the -results of Conduit.whoami for that resource owner when authenticated with +- **Scope** - this defines a specific piece of granular data a client can +or can not access on behalf of a user. For example, if authorized for the +"whoami" scope on behalf of a given resource owner, the client can get the +results of Conduit.whoami for that resource owner when authenticated with a valid access token. = Setup - Creating a Client = @@ -41,80 +41,80 @@ = Obtaining an Authorization Code = -POST or GET https://phabricator.example.com/oauthserver/auth/ with the +POST or GET https://phabricator.example.com/oauthserver/auth/ with the following parameters: - Required - **client_id** - the id of the newly registered client. -- Required - **response_type** - the desired type of authorization code +- Required - **response_type** - the desired type of authorization code response. Only code is supported at this time. -- Optional - **redirect_uri** - override the redirect_uri the client -registered. This redirect_uri must have the same fully-qualified domain -and have at least the same query parameters as the redirect_uri the client +- Optional - **redirect_uri** - override the redirect_uri the client +registered. This redirect_uri must have the same fully-qualified domain +and have at least the same query parameters as the redirect_uri the client registered, as well as have no fragments. - Optional - **scope** - specify what scope(s) the client needs access to in a space-delimited list. -- Optional - **state** - an opaque value the client can send to the server -for programmatic excellence. Some clients use this value to implement XSRF +- Optional - **state** - an opaque value the client can send to the server +for programmatic excellence. Some clients use this value to implement XSRF protection or for debugging purposes. -If done correctly and the resource owner has not yet authorized the client -for the desired scope, then the resource owner will be presented with an -interface to authorize the client for the desired scope. The OAuth Server -will redirect to the pertinent redirect_uri with an authorization code or +If done correctly and the resource owner has not yet authorized the client +for the desired scope, then the resource owner will be presented with an +interface to authorize the client for the desired scope. The OAuth Server +will redirect to the pertinent redirect_uri with an authorization code or an error indicating the resource owner did not authorize the client, depending. -If done correctly and the resource owner has already authorized the client for -the desired scope, then the OAuth Server will redirect to the pertinent -redirect_uri with a valid authorization code. +If done correctly and the resource owner has already authorized the client for +the desired scope, then the OAuth Server will redirect to the pertinent +redirect_uri with a valid authorization code. -If there is an error, the OAuth Server will return a descriptive error -message. This error will be presented to the resource owner on the -Phabricator domain if there is reason to believe there is something fishy -with the client. For example, if there is an issue with the redirect_uri. -Otherwise, the OAuth Server will redirect to the pertinent redirect_uri +If there is an error, the OAuth Server will return a descriptive error +message. This error will be presented to the resource owner on the +Phabricator domain if there is reason to believe there is something fishy +with the client. For example, if there is an issue with the redirect_uri. +Otherwise, the OAuth Server will redirect to the pertinent redirect_uri and include the pertinent error information. = Obtaining an Access Token = -POST or GET https://phabricator.example.com/oauthserver/token/ +POST or GET https://phabricator.example.com/oauthserver/token/ with the following parameters: - Required - **client_id** - the id of the client -- Required - **client_secret** - the secret of the client. +- Required - **client_secret** - the secret of the client. This is used to authenticate the client. - Required - **code** - the authorization code obtained earlier. -- Required - **grant_type** - the desired type of access grant. +- Required - **grant_type** - the desired type of access grant. Only token is supported at this time. -- Optional - **redirect_uri** - should be the exact same redirect_uri as -the redirect_uri specified to obtain the authorization code. If no -redirect_uri was specified to obtain the authorization code then this +- Optional - **redirect_uri** - should be the exact same redirect_uri as +the redirect_uri specified to obtain the authorization code. If no +redirect_uri was specified to obtain the authorization code then this should not be specified. -If done correctly, the OAuth Server will redirect to the pertinent +If done correctly, the OAuth Server will redirect to the pertinent redirect_uri with an access token. -If there is an error, the OAuth Server will return a descriptive error +If there is an error, the OAuth Server will return a descriptive error message. = Using an Access Token = -Simply include a query param with the key of "access_token" and the value +Simply include a query param with the key of "access_token" and the value as the earlier obtained access token. For example: https://phabricator.example.com/api/user.whoami?access_token=ykc7ly7vtibj334oga4fnfbuvnwz4ocp If the token has expired or is otherwise invalid, the client will receive -an error indicating as such. In these cases, the client should re-initiate +an error indicating as such. In these cases, the client should re-initiate the entire ##Authorization Code Grant## flow. -NOTE: See "Scopes" section below for more information on what data is +NOTE: See "Scopes" section below for more information on what data is currently exposed through the OAuth Server. = Scopes = There are only two scopes supported at this time. -- **offline_access** - allows an access token to work indefinitely without +- **offline_access** - allows an access token to work indefinitely without expiring. -- **whoami** - allows the client to access the results of Conduit.whoami on +- **whoami** - allows the client to access the results of Conduit.whoami on behalf of the resource owner. Index: src/docs/user/flavortext/javascript_object_array.diviner =================================================================== --- src/docs/user/flavortext/javascript_object_array.diviner +++ src/docs/user/flavortext/javascript_object_array.diviner @@ -150,4 +150,3 @@ and a list for key order. Don't try to build an ordered map using one Object or one Array. This generally applies for other complicated datatypes, as well; you need to build them out of more than one primitive. - Index: src/docs/user/flavortext/javascript_pitfalls.diviner =================================================================== --- src/docs/user/flavortext/javascript_pitfalls.diviner +++ src/docs/user/flavortext/javascript_pitfalls.diviner @@ -85,4 +85,3 @@ **Never use** ##new Number()##, ##new String()## or ##new Boolean()## unless your Javascript is God Tier and you are absolutely sure you know what you are doing. - Index: src/docs/user/flavortext/things_you_should_do_now.diviner =================================================================== --- src/docs/user/flavortext/things_you_should_do_now.diviner +++ src/docs/user/flavortext/things_you_should_do_now.diviner @@ -136,5 +136,3 @@ can handle escaping for you. If so, use them. If you're using PHP and don't have a solution in place yet, the Phabricator implementation of qsprintf() is similar to Facebook's system and was successful there. - - Index: src/docs/user/userguide/arcanist_lint.diviner =================================================================== --- src/docs/user/userguide/arcanist_lint.diviner +++ src/docs/user/userguide/arcanist_lint.diviner @@ -195,4 +195,3 @@ @{article:Arcanist User Guide: Customizing Existing Linters}; or - learning how to add new linters and lint engines with @{article:Arcanist User Guide: Customizing Lint, Unit Tests and Workflows}. - Index: src/docs/user/userguide/differential_test_plans.diviner =================================================================== --- src/docs/user/userguide/differential_test_plans.diviner +++ src/docs/user/userguide/differential_test_plans.diviner @@ -63,5 +63,3 @@ - **Static Resources:** Will your change cause the application to serve more JS or CSS? Can you use less JS/CSS, or reuse more? - **Browsers:** Have you tested your change in multiple browsers? - - Index: src/docs/user/userguide/herald.diviner =================================================================== --- src/docs/user/userguide/herald.diviner +++ src/docs/user/userguide/herald.diviner @@ -96,4 +96,3 @@ than "all" vs "any" allows, or have a common set of conditions which you want to share between several rules. If a rule is only being used as a group of conditions, you can set the action to "Do Nothing". - Index: src/docs/user/userguide/mail_rules.diviner =================================================================== --- src/docs/user/userguide/mail_rules.diviner +++ src/docs/user/userguide/mail_rules.diviner @@ -79,4 +79,3 @@ - ##X-Herald-Rules##: this is attached to some mail and shows Herald rule IDs which have triggered for the object. You can use this to sort or categorize mail that has triggered specific rules. - Index: src/docs/user/userguide/maniphest_custom.diviner =================================================================== --- src/docs/user/userguide/maniphest_custom.diviner +++ src/docs/user/userguide/maniphest_custom.diviner @@ -62,4 +62,3 @@ "Create Another Similar Task". Some fields from the original task are copied into the new task, while others are not; by default, fields are not copied. If you want this field to be copied, specify `true` for the `copy` property. - Index: src/docs/user/userguide/phame.diviner =================================================================== --- src/docs/user/userguide/phame.diviner +++ src/docs/user/userguide/phame.diviner @@ -7,18 +7,18 @@ Phame is a simple blogging platform. You can write drafts which only you can see. Later, you can publish these drafts as posts which anyone who can access -the Phabricator instance can see. You can also add posts to blogs to increase +the Phabricator instance can see. You can also add posts to blogs to increase your distribution. -Overall, Phame is intended to help an individual spread their message. As +Overall, Phame is intended to help an individual spread their message. As such, pertinent design decisions skew towards favoring the individual -rather than the collective. +rather than the collective. = Drafts = -Drafts are completely private so draft away. +Drafts are completely private so draft away. -= Posts = += Posts = Posts are accessible to anyone who has access to the Phabricator instance. @@ -33,10 +33,10 @@ blog.yourcompany.com -by making pertinent configuration changes with your DNS authority and +by making pertinent configuration changes with your DNS authority and Phabricator instance. -NOTE: removing a blogger from a given blog does not remove their posts that +NOTE: removing a blogger from a given blog does not remove their posts that are already associated with the blog. Rather, it removes their ability to edit metadata about and add posts to the blog. @@ -50,7 +50,7 @@ instance of a given comment widget will appear for a given post regardless of whether that post is being viewed in the context of a blog. -= Next Steps = += Next Steps = - Phame is extremely new and very basic for now. Give us feedback on what you'd like to see improve! See @{article:Give Feedback! Get Support!}. Index: src/infrastructure/__tests__/PhabricatorInfrastructureTestCase.php =================================================================== --- src/infrastructure/__tests__/PhabricatorInfrastructureTestCase.php +++ src/infrastructure/__tests__/PhabricatorInfrastructureTestCase.php @@ -101,4 +101,3 @@ } } - Index: src/infrastructure/celerity/CeleritySpriteGenerator.php =================================================================== --- src/infrastructure/celerity/CeleritySpriteGenerator.php +++ src/infrastructure/celerity/CeleritySpriteGenerator.php @@ -863,5 +863,3 @@ return $sheet; } } - - Index: src/infrastructure/daemon/bot/adapter/PhabricatorBotBaseStreamingProtocolAdapter.php =================================================================== --- src/infrastructure/daemon/bot/adapter/PhabricatorBotBaseStreamingProtocolAdapter.php +++ src/infrastructure/daemon/bot/adapter/PhabricatorBotBaseStreamingProtocolAdapter.php @@ -160,4 +160,3 @@ abstract protected function processMessage($raw_object); } - Index: src/infrastructure/events/PhabricatorEvent.php =================================================================== --- src/infrastructure/events/PhabricatorEvent.php +++ src/infrastructure/events/PhabricatorEvent.php @@ -42,8 +42,3 @@ } } - - - - - Index: src/infrastructure/events/PhabricatorEventListener.php =================================================================== --- src/infrastructure/events/PhabricatorEventListener.php +++ src/infrastructure/events/PhabricatorEventListener.php @@ -49,8 +49,3 @@ } } - - - - - Index: src/infrastructure/events/PhabricatorExampleEventListener.php =================================================================== --- src/infrastructure/events/PhabricatorExampleEventListener.php +++ src/infrastructure/events/PhabricatorExampleEventListener.php @@ -29,8 +29,3 @@ } } - - - - - Index: src/view/control/AphrontTableView.php =================================================================== --- src/view/control/AphrontTableView.php +++ src/view/control/AphrontTableView.php @@ -320,4 +320,3 @@ } - Index: src/view/layout/PhabricatorFileLinkListView.php =================================================================== --- src/view/layout/PhabricatorFileLinkListView.php +++ src/view/layout/PhabricatorFileLinkListView.php @@ -34,4 +34,3 @@ return phutil_implode_html(phutil_tag('br'), $file_links); } } - Index: src/view/viewutils.php =================================================================== --- src/view/viewutils.php +++ src/view/viewutils.php @@ -277,4 +277,3 @@ return $num_string; } - Index: support/aphlict/client/aphlict_test_client.php =================================================================== --- support/aphlict/client/aphlict_test_client.php +++ support/aphlict/client/aphlict_test_client.php @@ -53,4 +53,3 @@ $message = $proto_channel->waitForMessage(); $console->writeOut($json->encodeFormatted($message)); } - Index: support/empty/README =================================================================== --- support/empty/README +++ support/empty/README @@ -3,4 +3,3 @@ Of course, it's not quite empty because it has this file in it. So it's a mostly-empty, readable directory. - Index: webroot/index.php =================================================================== --- webroot/index.php +++ webroot/index.php @@ -148,4 +148,3 @@ $ex, $show_unexpected_traces); } - Index: webroot/rsrc/css/aphront/lightbox-attachment.css =================================================================== --- webroot/rsrc/css/aphront/lightbox-attachment.css +++ webroot/rsrc/css/aphront/lightbox-attachment.css @@ -104,4 +104,3 @@ .lightbox-attachment .lightbox-right:hover { background: url('/rsrc/image/icon/lightbox/right-arrow-hover-2.png'); } - Index: webroot/rsrc/css/aphront/phabricator-nav-view.css =================================================================== --- webroot/rsrc/css/aphront/phabricator-nav-view.css +++ webroot/rsrc/css/aphront/phabricator-nav-view.css @@ -100,4 +100,3 @@ .device-phone .phabricator-side-menu-home .phabricator-nav-local { width: 100%; } - Index: webroot/rsrc/css/application/conpherence/notification.css =================================================================== --- webroot/rsrc/css/application/conpherence/notification.css +++ webroot/rsrc/css/application/conpherence/notification.css @@ -77,4 +77,3 @@ color: #a1a5a9; font-size: 11px; } - Index: webroot/rsrc/css/application/differential/core.css =================================================================== --- webroot/rsrc/css/application/differential/core.css +++ webroot/rsrc/css/application/differential/core.css @@ -23,4 +23,3 @@ -ms-user-select: none; user-select: none; } - Index: webroot/rsrc/css/application/maniphest/batch-editor.css =================================================================== --- webroot/rsrc/css/application/maniphest/batch-editor.css +++ webroot/rsrc/css/application/maniphest/batch-editor.css @@ -16,4 +16,3 @@ width: 100%; text-align: left; } - Index: webroot/rsrc/css/application/people/people-profile.css =================================================================== --- webroot/rsrc/css/application/people/people-profile.css +++ webroot/rsrc/css/application/people/people-profile.css @@ -76,4 +76,3 @@ .compose-dialog .compose-background-backdrop { background-color: {$backdrop}; } - Index: webroot/rsrc/css/layout/phabricator-action-header-view.css =================================================================== --- webroot/rsrc/css/layout/phabricator-action-header-view.css +++ webroot/rsrc/css/layout/phabricator-action-header-view.css @@ -62,4 +62,3 @@ width: 16px; margin-right: 4px; } - Index: webroot/rsrc/css/phui/phui-icon.css =================================================================== --- webroot/rsrc/css/phui/phui-icon.css +++ webroot/rsrc/css/phui/phui-icon.css @@ -50,5 +50,3 @@ width: 35px; background-size: 35px; } - - Index: webroot/rsrc/externals/javelin/LICENSE =================================================================== --- webroot/rsrc/externals/javelin/LICENSE +++ webroot/rsrc/externals/javelin/LICENSE @@ -22,4 +22,3 @@ ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. - Index: webroot/rsrc/externals/javelin/core/__tests__/event-stop-and-kill.js =================================================================== --- webroot/rsrc/externals/javelin/core/__tests__/event-stop-and-kill.js +++ webroot/rsrc/externals/javelin/core/__tests__/event-stop-and-kill.js @@ -33,7 +33,3 @@ expect(target.getStopped()).toBe(true); }); }); - - - - Index: webroot/rsrc/externals/javelin/core/__tests__/install.js =================================================================== --- webroot/rsrc/externals/javelin/core/__tests__/install.js +++ webroot/rsrc/externals/javelin/core/__tests__/install.js @@ -149,4 +149,3 @@ }); }); - Index: webroot/rsrc/externals/javelin/docs/Base.js =================================================================== --- webroot/rsrc/externals/javelin/docs/Base.js +++ webroot/rsrc/externals/javelin/docs/Base.js @@ -68,8 +68,3 @@ } }); - - - - - Index: webroot/rsrc/externals/javelin/docs/concepts/behaviors.diviner =================================================================== --- webroot/rsrc/externals/javelin/docs/concepts/behaviors.diviner +++ webroot/rsrc/externals/javelin/docs/concepts/behaviors.diviner @@ -179,4 +179,3 @@ have more than just glue code, and should have been refactored into a real class some time ago. This is a pretty high-level drawback and is manageable through awareness of the risk and code review. - Index: webroot/rsrc/externals/javelin/docs/onload.js =================================================================== --- webroot/rsrc/externals/javelin/docs/onload.js +++ webroot/rsrc/externals/javelin/docs/onload.js @@ -19,4 +19,3 @@ // This isn't the real function definition, it's only defined here to let the // documentation generator find it. The actual definition is in init.js. }; - Index: webroot/rsrc/externals/javelin/ext/reactor/core/DynVal.js =================================================================== --- webroot/rsrc/externals/javelin/ext/reactor/core/DynVal.js +++ webroot/rsrc/externals/javelin/ext/reactor/core/DynVal.js @@ -45,4 +45,3 @@ })); } }); - Index: webroot/rsrc/externals/javelin/ext/reactor/core/Reactor.js =================================================================== --- webroot/rsrc/externals/javelin/ext/reactor/core/Reactor.js +++ webroot/rsrc/externals/javelin/ext/reactor/core/Reactor.js @@ -87,4 +87,3 @@ } } }); - Index: webroot/rsrc/externals/javelin/ext/reactor/core/ReactorNode.js =================================================================== --- webroot/rsrc/externals/javelin/ext/reactor/core/ReactorNode.js +++ webroot/rsrc/externals/javelin/ext/reactor/core/ReactorNode.js @@ -94,4 +94,3 @@ } } }); - Index: webroot/rsrc/externals/javelin/ext/reactor/core/ReactorNodeCalmer.js =================================================================== --- webroot/rsrc/externals/javelin/ext/reactor/core/ReactorNodeCalmer.js +++ webroot/rsrc/externals/javelin/ext/reactor/core/ReactorNodeCalmer.js @@ -45,4 +45,3 @@ } } }); - Index: webroot/rsrc/externals/javelin/ext/reactor/dom/RDOM.js =================================================================== --- webroot/rsrc/externals/javelin/ext/reactor/dom/RDOM.js +++ webroot/rsrc/externals/javelin/ext/reactor/dom/RDOM.js @@ -403,5 +403,3 @@ } } }); - - Index: webroot/rsrc/externals/javelin/ext/view/HTMLView.js =================================================================== --- webroot/rsrc/externals/javelin/ext/view/HTMLView.js +++ webroot/rsrc/externals/javelin/ext/view/HTMLView.js @@ -135,4 +135,3 @@ } } }); - Index: webroot/rsrc/externals/javelin/ext/view/View.js =================================================================== --- webroot/rsrc/externals/javelin/ext/view/View.js +++ webroot/rsrc/externals/javelin/ext/view/View.js @@ -189,4 +189,3 @@ } } }); - Index: webroot/rsrc/externals/javelin/ext/view/ViewRenderer.js =================================================================== --- webroot/rsrc/externals/javelin/ext/view/ViewRenderer.js +++ webroot/rsrc/externals/javelin/ext/view/ViewRenderer.js @@ -17,4 +17,3 @@ } } }); - Index: webroot/rsrc/externals/javelin/ext/view/ViewVisitor.js =================================================================== --- webroot/rsrc/externals/javelin/ext/view/ViewVisitor.js +++ webroot/rsrc/externals/javelin/ext/view/ViewVisitor.js @@ -33,4 +33,3 @@ } } }); - Index: webroot/rsrc/externals/javelin/lib/DOM.js =================================================================== --- webroot/rsrc/externals/javelin/lib/DOM.js +++ webroot/rsrc/externals/javelin/lib/DOM.js @@ -962,4 +962,3 @@ } } }); - Index: webroot/rsrc/externals/javelin/lib/__tests__/URI.js =================================================================== --- webroot/rsrc/externals/javelin/lib/__tests__/URI.js +++ webroot/rsrc/externals/javelin/lib/__tests__/URI.js @@ -300,4 +300,3 @@ }); }); - Index: webroot/rsrc/externals/javelin/lib/__tests__/behavior.js =================================================================== --- webroot/rsrc/externals/javelin/lib/__tests__/behavior.js +++ webroot/rsrc/externals/javelin/lib/__tests__/behavior.js @@ -93,4 +93,3 @@ }); }); - Index: webroot/rsrc/externals/javelin/lib/control/typeahead/source/TypeaheadCompositeSource.js =================================================================== --- webroot/rsrc/externals/javelin/lib/control/typeahead/source/TypeaheadCompositeSource.js +++ webroot/rsrc/externals/javelin/lib/control/typeahead/source/TypeaheadCompositeSource.js @@ -75,4 +75,3 @@ } } }); - Index: webroot/rsrc/externals/javelin/lib/control/typeahead/source/TypeaheadOnDemandSource.js =================================================================== --- webroot/rsrc/externals/javelin/lib/control/typeahead/source/TypeaheadOnDemandSource.js +++ webroot/rsrc/externals/javelin/lib/control/typeahead/source/TypeaheadOnDemandSource.js @@ -99,5 +99,3 @@ } } }); - - Index: webroot/rsrc/externals/javelin/lib/control/typeahead/source/TypeaheadPreloadedSource.js =================================================================== --- webroot/rsrc/externals/javelin/lib/control/typeahead/source/TypeaheadPreloadedSource.js +++ webroot/rsrc/externals/javelin/lib/control/typeahead/source/TypeaheadPreloadedSource.js @@ -56,6 +56,3 @@ } } }); - - - Index: webroot/rsrc/externals/javelin/lib/control/typeahead/source/TypeaheadStaticSource.js =================================================================== --- webroot/rsrc/externals/javelin/lib/control/typeahead/source/TypeaheadStaticSource.js +++ webroot/rsrc/externals/javelin/lib/control/typeahead/source/TypeaheadStaticSource.js @@ -35,6 +35,3 @@ } } }); - - - Index: webroot/rsrc/image/icon/fatcow/README =================================================================== --- webroot/rsrc/image/icon/fatcow/README +++ webroot/rsrc/image/icon/fatcow/README @@ -14,4 +14,4 @@ source/conduit.png (from satellite_dish.png) source/mobile.png (from phone.png) source/tablet.png (from tablet.png) - source/fax.png (from fax.png) \ No newline at end of file + source/fax.png (from fax.png) Index: webroot/rsrc/js/application/config/behavior-reorder-fields.js =================================================================== --- webroot/rsrc/js/application/config/behavior-reorder-fields.js +++ webroot/rsrc/js/application/config/behavior-reorder-fields.js @@ -55,4 +55,3 @@ }; }); - Index: webroot/rsrc/js/application/countdown/timer.js =================================================================== --- webroot/rsrc/js/application/countdown/timer.js +++ webroot/rsrc/js/application/countdown/timer.js @@ -50,4 +50,3 @@ } }); - Index: webroot/rsrc/js/application/differential/behavior-add-reviewers-and-ccs.js =================================================================== --- webroot/rsrc/js/application/differential/behavior-add-reviewers-and-ccs.js +++ webroot/rsrc/js/application/differential/behavior-add-reviewers-and-ccs.js @@ -45,4 +45,3 @@ } }); }); - Index: webroot/rsrc/js/application/differential/behavior-edit-inline-comments.js =================================================================== --- webroot/rsrc/js/application/differential/behavior-edit-inline-comments.js +++ webroot/rsrc/js/application/differential/behavior-edit-inline-comments.js @@ -267,4 +267,3 @@ }); }); - Index: webroot/rsrc/js/application/differential/behavior-keyboard-nav.js =================================================================== --- webroot/rsrc/js/application/differential/behavior-keyboard-nav.js +++ webroot/rsrc/js/application/differential/behavior-keyboard-nav.js @@ -274,4 +274,3 @@ } }); - Index: webroot/rsrc/js/application/diffusion/behavior-commit-branches.js =================================================================== --- webroot/rsrc/js/application/diffusion/behavior-commit-branches.js +++ webroot/rsrc/js/application/diffusion/behavior-commit-branches.js @@ -16,4 +16,3 @@ } }); - Index: webroot/rsrc/js/application/diffusion/behavior-commit-graph.js =================================================================== --- webroot/rsrc/js/application/diffusion/behavior-commit-graph.js +++ webroot/rsrc/js/application/diffusion/behavior-commit-graph.js @@ -140,4 +140,3 @@ }); - Index: webroot/rsrc/js/application/diffusion/behavior-pull-lastmodified.js =================================================================== --- webroot/rsrc/js/application/diffusion/behavior-pull-lastmodified.js +++ webroot/rsrc/js/application/diffusion/behavior-pull-lastmodified.js @@ -19,4 +19,3 @@ } }); - Index: webroot/rsrc/js/application/doorkeeper/behavior-doorkeeper-tag.js =================================================================== --- webroot/rsrc/js/application/doorkeeper/behavior-doorkeeper-tag.js +++ webroot/rsrc/js/application/doorkeeper/behavior-doorkeeper-tag.js @@ -62,4 +62,3 @@ JX.onload(load); }); - Index: webroot/rsrc/js/application/files/behavior-icon-composer.js =================================================================== --- webroot/rsrc/js/application/files/behavior-icon-composer.js +++ webroot/rsrc/js/application/files/behavior-icon-composer.js @@ -73,4 +73,3 @@ redraw(); }); - Index: webroot/rsrc/js/application/files/behavior-launch-icon-composer.js =================================================================== --- webroot/rsrc/js/application/files/behavior-launch-icon-composer.js +++ webroot/rsrc/js/application/files/behavior-launch-icon-composer.js @@ -22,4 +22,3 @@ }); }); - Index: webroot/rsrc/js/application/harbormaster/behavior-reorder-steps.js =================================================================== --- webroot/rsrc/js/application/harbormaster/behavior-reorder-steps.js +++ webroot/rsrc/js/application/harbormaster/behavior-reorder-steps.js @@ -39,4 +39,3 @@ }); }); - Index: webroot/rsrc/js/application/maniphest/behavior-line-chart.js =================================================================== --- webroot/rsrc/js/application/maniphest/behavior-line-chart.js +++ webroot/rsrc/js/application/maniphest/behavior-line-chart.js @@ -86,4 +86,3 @@ }); }); - Index: webroot/rsrc/js/application/maniphest/behavior-transaction-controls.js =================================================================== --- webroot/rsrc/js/application/maniphest/behavior-transaction-controls.js +++ webroot/rsrc/js/application/maniphest/behavior-transaction-controls.js @@ -33,4 +33,3 @@ }); }); - Index: webroot/rsrc/js/application/search/behavior-reorder-queries.js =================================================================== --- webroot/rsrc/js/application/search/behavior-reorder-queries.js +++ webroot/rsrc/js/application/search/behavior-reorder-queries.js @@ -39,4 +39,3 @@ }); }); - Index: webroot/rsrc/js/core/FileUpload.js =================================================================== --- webroot/rsrc/js/core/FileUpload.js +++ webroot/rsrc/js/core/FileUpload.js @@ -111,4 +111,3 @@ } }); - Index: webroot/rsrc/js/core/MultirowRowManager.js =================================================================== --- webroot/rsrc/js/core/MultirowRowManager.js +++ webroot/rsrc/js/core/MultirowRowManager.js @@ -143,4 +143,3 @@ _removeSigil : "tools-multirow-row-manager-row-remove" } }); - Index: webroot/rsrc/js/core/Notification.js =================================================================== --- webroot/rsrc/js/core/Notification.js +++ webroot/rsrc/js/core/Notification.js @@ -188,4 +188,3 @@ } }); - Index: webroot/rsrc/js/core/behavior-drag-and-drop-textarea.js =================================================================== --- webroot/rsrc/js/core/behavior-drag-and-drop-textarea.js +++ webroot/rsrc/js/core/behavior-drag-and-drop-textarea.js @@ -39,4 +39,3 @@ } }); - Index: webroot/rsrc/js/core/behavior-global-drag-and-drop.js =================================================================== --- webroot/rsrc/js/core/behavior-global-drag-and-drop.js +++ webroot/rsrc/js/core/behavior-global-drag-and-drop.js @@ -65,4 +65,3 @@ drop.start(); }); - Index: webroot/rsrc/swf/test.html =================================================================== --- webroot/rsrc/swf/test.html +++ webroot/rsrc/swf/test.html @@ -1,4 +1,4 @@ - \ No newline at end of file +