Paths

Table of Contentst

Possibly fix issue where refs engine finds empty refs?
ClosedPublic
Actions

Authored by epriestley on Feb 24 2014, 8:52 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Dec 17, 11:14 AM

	Unknown Object (File)
	Tue, Dec 3, 11:25 AM

	Unknown Object (File)
	Tue, Dec 3, 11:25 AM

	Unknown Object (File)
	Tue, Dec 3, 11:25 AM

	Unknown Object (File)
	Tue, Dec 3, 11:04 AM

	Unknown Object (File)
	Fri, Nov 29, 1:55 AM

	Unknown Object (File)
	Wed, Nov 27, 8:28 PM

	Unknown Object (File)
	Mon, Nov 25, 8:03 PM

View All Files

Subscribers

aran

mbishopim3

Details

Reviewers

btrahan

Commits

Restricted Diffusion Commit
rP763a049f7499: Possibly fix issue where refs engine finds empty refs?

Summary

@mbishopim3 reported an issue in IRC:

mbishopim3: epriestley: "Error updating working copy: Commit "" has not been discovered yet! Run discovery before updating refs." any ideas?

I can't reproduce it and it went away for him, but one theory is that we're getting here and git/hg are spitting out nothing, which we incorrectly parse as array("") when we intend array().

Test Plan

Pushed some new commits, ran bin/repositoy refs X, got expected results.

I can't actually reproduce the bug, but this might fix it and appears to make the code more correct.

Diff Detail

Repository

rP Phabricator

Branch

maybeempty

Lint

Lint Passed

Unit

Tests Passed

Event Timeline

Could this in any way be related to T4445 or T1621? The issue seemed to occur when a tag was created and did not resolve until later "normal" commits were pushed.

btrahan accepted this revision.Feb 24 2014, 10:30 PM

Closed by commit rP763a049f7499 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

repository/

engine/

PhabricatorRepositoryRefEngine.php

10 lines

Diff 19800

View Options

src/applications/repository/engine/PhabricatorRepositoryRefEngine.php

Possibly fix issue where refs engine finds empty refs?ClosedPublicActions