Page MenuHomePhabricator

Possibly fix issue where refs engine finds empty refs?
ClosedPublic

Authored by epriestley on Feb 24 2014, 8:52 PM.
Tags
None
Referenced Files
F14061667: D8326.diff
Mon, Nov 18, 7:42 AM
F14037009: D8326.diff
Sun, Nov 10, 1:24 PM
F14036684: D8326.diff
Sun, Nov 10, 11:35 AM
F14011285: D8326.id19800.diff
Thu, Oct 31, 10:36 PM
F14011284: D8326.id19801.diff
Thu, Oct 31, 10:36 PM
F14011283: D8326.id.diff
Thu, Oct 31, 10:36 PM
F14011268: D8326.diff
Thu, Oct 31, 10:19 PM
F13996830: D8326.id.diff
Thu, Oct 24, 12:18 AM
Subscribers

Details

Summary

@mbishopim3 reported an issue in IRC:

mbishopim3: epriestley: "Error updating working copy: Commit "" has not been discovered yet! Run discovery before updating refs." any ideas?

I can't reproduce it and it went away for him, but one theory is that we're getting here and git/hg are spitting out nothing, which we incorrectly parse as array("") when we intend array().

Test Plan

Pushed some new commits, ran bin/repositoy refs X, got expected results.

I can't actually reproduce the bug, but this might fix it and appears to make the code more correct.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

Could this in any way be related to T4445 or T1621? The issue seemed to occur when a tag was created and did not resolve until later "normal" commits were pushed.