Page MenuHomePhabricator

Recommend STRICT_ALL_TABLES for every install, not just development installs
ClosedPublic

Authored by epriestley on Feb 23 2014, 6:07 PM.
Tags
None
Referenced Files
F13228646: D8309.diff
Mon, May 20, 11:00 AM
F13216661: D8309.diff
Sat, May 18, 1:50 AM
F13200178: D8309.diff
Mon, May 13, 10:40 PM
F13182338: D8309.diff
Thu, May 9, 11:24 PM
F13174777: D8309.diff
Wed, May 8, 1:07 AM
Unknown Object (File)
Tue, Apr 23, 5:19 PM
Unknown Object (File)
Apr 19 2024, 4:54 PM
Unknown Object (File)
Apr 15 2024, 4:28 PM
Subscribers

Details

Summary

See D8308. Enabling STRICT_ALL_TABLES prevents this entire class of error, by fataling on truncation instead of truncating. We never want truncation; it is always bad and sometimes extremely bad.

We've recommended this mode for developer installs for a long time, and some users run with it enabled, so it's very unlikely to cause any issues (I've had it enabled locally for at least 6-8 months, I think).

Test Plan
  • Disabled mode.
  • Saw warning.
  • Enabled mode.
  • No warning.

{F117040}

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

Just enabled on our production instance.

{F117053}