Page MenuHomePhabricator

Recommend STRICT_ALL_TABLES for every install, not just development installs
ClosedPublic

Authored by epriestley on Feb 23 2014, 6:07 PM.
Tags
None
Referenced Files
F16312603: D8309.diff
Sun, Jun 15, 3:41 PM
Unknown Object (File)
May 2 2025, 5:20 AM
Unknown Object (File)
Apr 18 2025, 11:41 PM
Unknown Object (File)
Apr 8 2025, 6:48 PM
Unknown Object (File)
Mar 27 2025, 10:02 AM
Unknown Object (File)
Mar 20 2025, 6:24 PM
Unknown Object (File)
Mar 16 2025, 1:11 PM
Unknown Object (File)
Mar 14 2025, 2:14 AM
Subscribers

Details

Summary

See D8308. Enabling STRICT_ALL_TABLES prevents this entire class of error, by fataling on truncation instead of truncating. We never want truncation; it is always bad and sometimes extremely bad.

We've recommended this mode for developer installs for a long time, and some users run with it enabled, so it's very unlikely to cause any issues (I've had it enabled locally for at least 6-8 months, I think).

Test Plan
  • Disabled mode.
  • Saw warning.
  • Enabled mode.
  • No warning.

{F117040}

Diff Detail

Repository
rP Phabricator
Branch
sec2
Lint
Lint Passed
Unit
No Test Coverage

Event Timeline

Just enabled on our production instance.

{F117053}