Page MenuHomePhabricator

Recommend STRICT_ALL_TABLES for every install, not just development installs
ClosedPublic

Authored by epriestley on Feb 23 2014, 6:07 PM.
Tags
None
Referenced Files
F18900175: D8309.diff
Fri, Nov 7, 8:35 PM
F18854797: D8309.id19760.diff
Sat, Nov 1, 12:38 AM
F18840091: D8309.id.diff
Mon, Oct 27, 9:02 PM
F18833332: D8309.diff
Sun, Oct 26, 2:37 AM
F18826039: D8309.id19760.diff
Fri, Oct 24, 2:13 AM
F18776727: D8309.diff
Fri, Oct 10, 11:09 PM
F18763836: D8309.id.diff
Oct 7 2025, 2:33 AM
F18756256: D8309.id19760.diff
Oct 5 2025, 10:29 AM
Subscribers

Details

Summary

See D8308. Enabling STRICT_ALL_TABLES prevents this entire class of error, by fataling on truncation instead of truncating. We never want truncation; it is always bad and sometimes extremely bad.

We've recommended this mode for developer installs for a long time, and some users run with it enabled, so it's very unlikely to cause any issues (I've had it enabled locally for at least 6-8 months, I think).

Test Plan
  • Disabled mode.
  • Saw warning.
  • Enabled mode.
  • No warning.

{F117040}

Diff Detail

Repository
rP Phabricator
Branch
sec2
Lint
Lint Passed
Unit
No Test Coverage

Event Timeline

Just enabled on our production instance.

{F117053}