Page MenuHomePhabricator

Recommend STRICT_ALL_TABLES for every install, not just development installs
ClosedPublic

Authored by epriestley on Feb 23 2014, 6:07 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Dec 20, 4:00 PM
Unknown Object (File)
Fri, Dec 20, 10:07 AM
Unknown Object (File)
Sat, Dec 14, 9:17 PM
Unknown Object (File)
Tue, Dec 10, 7:03 PM
Unknown Object (File)
Mon, Dec 9, 4:42 PM
Unknown Object (File)
Wed, Dec 4, 12:26 AM
Unknown Object (File)
Tue, Dec 3, 12:44 PM
Unknown Object (File)
Wed, Nov 27, 12:00 AM
Subscribers

Details

Summary

See D8308. Enabling STRICT_ALL_TABLES prevents this entire class of error, by fataling on truncation instead of truncating. We never want truncation; it is always bad and sometimes extremely bad.

We've recommended this mode for developer installs for a long time, and some users run with it enabled, so it's very unlikely to cause any issues (I've had it enabled locally for at least 6-8 months, I think).

Test Plan
  • Disabled mode.
  • Saw warning.
  • Enabled mode.
  • No warning.

{F117040}

Diff Detail

Repository
rP Phabricator
Branch
sec2
Lint
Lint Passed
Unit
No Test Coverage

Event Timeline

Just enabled on our production instance.

{F117053}