Page MenuHomePhabricator

Recommend STRICT_ALL_TABLES for every install, not just development installs
ClosedPublic

Authored by epriestley on Feb 23 2014, 6:07 PM.
Tags
None
Referenced Files
F15444550: D8309.id19758.diff
Thu, Mar 27, 10:02 AM
F15417774: D8309.id19758.diff
Thu, Mar 20, 6:24 PM
F15396281: D8309.diff
Sun, Mar 16, 1:11 PM
F15380259: D8309.id.diff
Fri, Mar 14, 2:14 AM
F15378584: D8309.id19760.diff
Thu, Mar 13, 3:28 PM
Unknown Object (File)
Feb 24 2025, 11:31 AM
Unknown Object (File)
Feb 21 2025, 4:27 AM
Unknown Object (File)
Jan 31 2025, 7:32 AM
Subscribers

Details

Summary

See D8308. Enabling STRICT_ALL_TABLES prevents this entire class of error, by fataling on truncation instead of truncating. We never want truncation; it is always bad and sometimes extremely bad.

We've recommended this mode for developer installs for a long time, and some users run with it enabled, so it's very unlikely to cause any issues (I've had it enabled locally for at least 6-8 months, I think).

Test Plan
  • Disabled mode.
  • Saw warning.
  • Enabled mode.
  • No warning.

{F117040}

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

Just enabled on our production instance.

{F117053}