Page MenuHomePhabricator

Recommend STRICT_ALL_TABLES for every install, not just development installs
ClosedPublic

Authored by epriestley on Feb 23 2014, 6:07 PM.
Tags
None
Referenced Files
F18616032: D8309.diff
Sun, Sep 14, 3:58 PM
F18605247: D8309.id.diff
Sat, Sep 13, 8:19 PM
F18599593: D8309.diff
Sat, Sep 13, 7:46 AM
F18589087: D8309.diff
Fri, Sep 12, 2:22 AM
F18106992: D8309.diff
Aug 10 2025, 11:35 PM
F18103013: D8309.diff
Aug 10 2025, 1:01 AM
F18053458: D8309.id19758.diff
Aug 4 2025, 5:04 AM
F18051930: D8309.diff
Aug 4 2025, 12:45 AM
Subscribers

Details

Summary

See D8308. Enabling STRICT_ALL_TABLES prevents this entire class of error, by fataling on truncation instead of truncating. We never want truncation; it is always bad and sometimes extremely bad.

We've recommended this mode for developer installs for a long time, and some users run with it enabled, so it's very unlikely to cause any issues (I've had it enabled locally for at least 6-8 months, I think).

Test Plan
  • Disabled mode.
  • Saw warning.
  • Enabled mode.
  • No warning.

{F117040}

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

Just enabled on our production instance.

{F117053}