Page MenuHomePhabricator

Recommend STRICT_ALL_TABLES for every install, not just development installs
ClosedPublic

Authored by epriestley on Feb 23 2014, 6:07 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jan 17, 8:57 AM
Unknown Object (File)
Sun, Jan 12, 4:41 AM
Unknown Object (File)
Fri, Dec 20, 4:00 PM
Unknown Object (File)
Dec 20 2024, 10:07 AM
Unknown Object (File)
Dec 14 2024, 9:17 PM
Unknown Object (File)
Dec 10 2024, 7:03 PM
Unknown Object (File)
Dec 9 2024, 4:42 PM
Unknown Object (File)
Dec 4 2024, 12:26 AM
Subscribers

Details

Summary

See D8308. Enabling STRICT_ALL_TABLES prevents this entire class of error, by fataling on truncation instead of truncating. We never want truncation; it is always bad and sometimes extremely bad.

We've recommended this mode for developer installs for a long time, and some users run with it enabled, so it's very unlikely to cause any issues (I've had it enabled locally for at least 6-8 months, I think).

Test Plan
  • Disabled mode.
  • Saw warning.
  • Enabled mode.
  • No warning.

{F117040}

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

Just enabled on our production instance.

{F117053}