Page MenuHomePhabricator

Recommend STRICT_ALL_TABLES for every install, not just development installs
ClosedPublic

Authored by epriestley on Feb 23 2014, 6:07 PM.
Tags
None
Referenced Files
F19053133: D8309.diff
Fri, Nov 28, 7:37 AM
F19052035: D8309.diff
Fri, Nov 28, 2:38 AM
F18903927: D8309.id19760.diff
Sat, Nov 8, 6:56 AM
F18903501: D8309.id19760.diff
Sat, Nov 8, 5:20 AM
F18902411: D8309.id19758.diff
Sat, Nov 8, 1:07 AM
F18900175: D8309.diff
Fri, Nov 7, 8:35 PM
F18854797: D8309.id19760.diff
Sat, Nov 1, 12:38 AM
F18840091: D8309.id.diff
Oct 27 2025, 9:02 PM
Subscribers

Details

Summary

See D8308. Enabling STRICT_ALL_TABLES prevents this entire class of error, by fataling on truncation instead of truncating. We never want truncation; it is always bad and sometimes extremely bad.

We've recommended this mode for developer installs for a long time, and some users run with it enabled, so it's very unlikely to cause any issues (I've had it enabled locally for at least 6-8 months, I think).

Test Plan
  • Disabled mode.
  • Saw warning.
  • Enabled mode.
  • No warning.

{F117040}

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

Just enabled on our production instance.

{F117053}