Page MenuHomePhabricator

Recommend STRICT_ALL_TABLES for every install, not just development installs
ClosedPublic

Authored by epriestley on Feb 23 2014, 6:07 PM.
Tags
None
Referenced Files
F14064788: D8309.diff
Tue, Nov 19, 1:25 AM
F14051172: D8309.diff
Thu, Nov 14, 10:47 PM
F14037863: D8309.diff
Sun, Nov 10, 7:43 PM
F14024152: D8309.diff
Thu, Nov 7, 6:38 AM
F14022118: D8309.id.diff
Wed, Nov 6, 3:20 PM
F14017949: D8309.diff
Tue, Nov 5, 1:29 AM
F13995717: D8309.diff
Wed, Oct 23, 2:57 PM
Unknown Object (File)
Oct 11 2024, 11:18 PM
Subscribers

Details

Summary

See D8308. Enabling STRICT_ALL_TABLES prevents this entire class of error, by fataling on truncation instead of truncating. We never want truncation; it is always bad and sometimes extremely bad.

We've recommended this mode for developer installs for a long time, and some users run with it enabled, so it's very unlikely to cause any issues (I've had it enabled locally for at least 6-8 months, I think).

Test Plan
  • Disabled mode.
  • Saw warning.
  • Enabled mode.
  • No warning.

{F117040}

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

Just enabled on our production instance.

{F117053}