Page MenuHomePhabricator

Recommend STRICT_ALL_TABLES for every install, not just development installs
ClosedPublic

Authored by epriestley on Feb 23 2014, 6:07 PM.
Tags
None
Referenced Files
F19470436: D8309.diff
Mon, Jan 5, 3:46 PM
F19470377: D8309.diff
Mon, Jan 5, 2:42 PM
F19074075: D8309.id19760.diff
Dec 1 2025, 4:13 AM
F19064278: D8309.id.diff
Nov 29 2025, 8:28 PM
F19053133: D8309.diff
Nov 28 2025, 7:37 AM
F19052035: D8309.diff
Nov 28 2025, 2:38 AM
F18903927: D8309.id19760.diff
Nov 8 2025, 6:56 AM
F18903501: D8309.id19760.diff
Nov 8 2025, 5:20 AM
Subscribers

Details

Summary

See D8308. Enabling STRICT_ALL_TABLES prevents this entire class of error, by fataling on truncation instead of truncating. We never want truncation; it is always bad and sometimes extremely bad.

We've recommended this mode for developer installs for a long time, and some users run with it enabled, so it's very unlikely to cause any issues (I've had it enabled locally for at least 6-8 months, I think).

Test Plan
  • Disabled mode.
  • Saw warning.
  • Enabled mode.
  • No warning.

{F117040}

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

Just enabled on our production instance.

{F117053}