Page MenuHomePhabricator
Differential D8306

Add inline comment support to "Pro" comment save controller
ClosedPublic
Actions

Authored by epriestley on Feb 22 2014, 5:36 PM.
Tags
None
Referenced Files
F14065442: D8306.diff
Tue, Nov 19, 4:40 AM
F14052306: D8306.diff
Fri, Nov 15, 8:06 AM
F14038661: D8306.diff
Mon, Nov 11, 1:06 AM
F14024083: D8306.diff
Thu, Nov 7, 5:41 AM
F14015612: D8306.id19805.diff
Sun, Nov 3, 10:26 PM
F14008112: D8306.diff
Tue, Oct 29, 3:53 PM
F14007350: D8306.id19805.diff
Tue, Oct 29, 4:16 AM
F13993920: D8306.id.diff
Wed, Oct 23, 2:18 AM
View All Files
Subscribers
aran

Details

Reviewers
btrahan
Maniphest Tasks
T2222: Implement ApplicationTransactions in Differential
Commits
Restricted Diffusion Commit
rPd48a88d4cd78: Add inline comment support to "Pro" comment save controller
Summary

Ref T2222. Makes the "pro" controller work with inlines.

Test Plan

Added a bunch of inlines and saved them with the "pro" controller.

Diff Detail

Repository
rP Phabricator
Branch
dxfield3
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/differential/controller/DifferentialCommentSaveControllerPro.php:156XHP16TODO Comment
Unit
Tests Passed

Revision Contents
Changeset List

PathSize
src/
applications/
differential/
controller/
53 lines
editor/
28 lines
transactions/
editor/
7 lines
storage/
17 lines

Diff 19754

View Options

src/applications/differential/controller/DifferentialCommentSaveControllerPro.php

Loading...
View Options

src/applications/differential/editor/DifferentialTransactionEditor.php

Loading...
View Options

src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php

Loading...
View Options

src/applications/transactions/storage/PhabricatorApplicationTransaction.php

Loading...
Phabricator · Built by Phacility