Ref T2222. Ref T1790. I partially modernized this recently, but bring it to the mail version too.
Details
Details
- Reviewers
btrahan - Maniphest Tasks
- Restricted Maniphest Task
T2222: Implement ApplicationTransactions in Differential - Commits
- Restricted Diffusion Commit
rP92ac8b5ad9a5: Make Differential inline comment rendering more consistent and somewhat more…
See screenshots.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- dxiorder
- Lint
Lint Passed - Unit
Tests Passed
Event Timeline
| src/applications/differential/controller/DifferentialChangesetViewController.php | ||
|---|---|---|
| 359 | This true -> 1 stuff is for MySQL strict mode. | |
| src/applications/differential/editor/DifferentialCommentEditor.php | ||
| 662–663 | Most of this juggling is to start unraveling our dependence on the old proxy/wrapper objects. | |
| src/infrastructure/diff/view/PhabricatorInlineSummaryView.php | ||
| 43–45 | Stuff is always passed in to this view in the correct order now, and we just respect it. | |