Page MenuHomePhabricator

Use standard rendering and controller for Differential subscriptions
ClosedPublic

Authored by epriestley on Feb 21 2014, 6:07 PM.
Tags
None
Referenced Files
F14002244: D8293.diff
Fri, Oct 25, 4:45 PM
F13997655: D8293.id19731.diff
Thu, Oct 24, 5:32 AM
F13996689: D8293.id19721.diff
Wed, Oct 23, 11:12 PM
Unknown Object (File)
Sep 27 2024, 4:04 PM
Unknown Object (File)
Sep 23 2024, 1:23 PM
Unknown Object (File)
Sep 23 2024, 1:23 PM
Unknown Object (File)
Sep 23 2024, 1:23 PM
Unknown Object (File)
Sep 23 2024, 1:19 PM
Subscribers

Details

Summary

Ref T2222. Differential has custom code for managing subscriptions, but no longer requires it.

The one trick is that we don't have a hook for loading related data on the subscriptions workflow right now. Just glue that in for the moment; it's relatively harmless, and once Diffusion converts we'll have more context on how to best surface it properly.

Test Plan

Subscribed and unsubscribed from a revision. Viewed different revisions and saw correct subscription state.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

does this change where the action ends up in the list? no big deal to me, i would expect a complaint or two though if so.

Yeah, it generally moves somewhere lower in the menu. I'd be surprised if we got too many complaints, but we'll see...