Ref T3496. Currently, we call loadAssets() on each revision table, which invokes a new revision query and a pile of subqueries.
Instead, add needFlags() and needDrafts() to RevisionQuery. Some day these could perhaps be more generic.
Details
Details
- Reviewers
btrahan - Maniphest Tasks
- Restricted Maniphest Task
- Commits
- Restricted Diffusion Commit
rP50ed42761ce9: Don't issue a bazillion queries to load Differential object lists
- Viewed home, differential, etc., no longer saw 9203809238 queries being run for no reason.
- Drafts and flags still appear properly.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- dquery
- Lint
Lint Passed - Unit
Tests Passed