Page MenuHomePhabricator

Fix double-rendering of inline comments in mail
ClosedPublic

Authored by epriestley on Feb 13 2014, 8:17 PM.
Tags
None
Referenced Files
F17629350: D8216.id.diff
Thu, Jul 10, 8:42 AM
Unknown Object (File)
Sun, Jun 29, 12:06 AM
Unknown Object (File)
Jun 20 2025, 9:58 PM
Unknown Object (File)
Jun 18 2025, 2:44 AM
Unknown Object (File)
Jun 9 2025, 1:56 AM
Unknown Object (File)
May 9 2025, 10:25 PM
Unknown Object (File)
May 9 2025, 12:42 PM
Unknown Object (File)
May 8 2025, 11:39 AM
Subscribers

Details

Summary

Ref T2222. This is a tmp.differential-only issue. Inline comment transactions now have content, so we treat them like body text. We also render them separately as inline text. This produces mail where inlines are rendered twice.

Test Plan

Sent myself mail, saw only one copy of inlines.

Diff Detail

Repository
rP Phabricator
Branch
dxn5
Lint
Lint Passed
Unit
Tests Passed

Event Timeline

epriestley updated this revision to Unknown Object (????).Feb 13 2014, 8:19 PM

(Also fix missing string for "inline" action.)