Page MenuHomePhabricator

Reduce reliance on `getRevisionID()` on DifferentialComment
ClosedPublic

Authored by epriestley on Feb 12 2014, 6:47 PM.
Tags
None
Referenced Files
F15374911: D8209.diff
Wed, Mar 12, 8:35 PM
F15336818: D8209.id18569.diff
Sun, Mar 9, 2:09 AM
Unknown Object (File)
Thu, Feb 27, 1:00 PM
Unknown Object (File)
Tue, Feb 18, 4:14 PM
Unknown Object (File)
Sat, Feb 15, 1:27 AM
Unknown Object (File)
Sat, Feb 15, 1:27 AM
Unknown Object (File)
Sat, Feb 15, 1:27 AM
Unknown Object (File)
Sat, Feb 15, 1:27 AM
Subscribers

Details

Summary

Ref T2222. A few rendering interfaces rely on fishing the revision ID out of a DifferentialComment, but it will only have the PHID soon. Pass in the revision and use it to determine the ID instead.

Test Plan

Browsed, previewed, examined comments. Clicked anchors.

Diff Detail

Repository
rP Phabricator
Branch
dxn2
Lint
Lint Passed
Unit
Tests Passed

Event Timeline

lamest inline feedback in awhile

src/applications/differential/controller/DifferentialCommentPreviewController.php
51

these could all be $viewer I s'pose