Ref T2222. A few rendering interfaces rely on fishing the revision ID out of a DifferentialComment, but it will only have the PHID soon. Pass in the revision and use it to determine the ID instead.
Details
Details
- Reviewers
btrahan chad - Maniphest Tasks
- T2222: Implement ApplicationTransactions in Differential
- Commits
- Restricted Diffusion Commit
rP3092efdc65a4: Reduce reliance on `getRevisionID()` on DifferentialComment
Browsed, previewed, examined comments. Clicked anchors.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- dxn2
- Lint
Lint Passed Severity Location Code Message Advice src/applications/differential/conduit/ConduitAPI_differential_getrevisioncomments_Method.php:56 XHP16 TODO Comment - Unit
Tests Passed
Event Timeline
Comment Actions
lamest inline feedback in awhile
| src/applications/differential/controller/DifferentialCommentPreviewController.php | ||
|---|---|---|
| 51 | these could all be $viewer I s'pose | |