Page MenuHomePhabricator

Remove PhabricatorProjectEditor
ClosedPublic

Authored by epriestley on Feb 8 2014, 12:25 AM.
Tags
None
Referenced Files
F19801012: D8168.id18518.diff
Sat, Feb 28, 8:07 PM
F19706067: D8168.diff
Wed, Feb 11, 9:05 AM
F19684895: D8168.id.diff
Mon, Feb 9, 6:43 AM
F19530654: D8168.id18518.diff
Jan 19 2026, 11:32 PM
F19527182: D8168.id18518.diff
Jan 18 2026, 11:32 PM
F18851493: D8168.id18479.diff
Oct 31 2025, 1:46 AM
F18836003: D8168.diff
Oct 26 2025, 8:46 PM
F18833052: D8168.diff
Oct 26 2025, 12:28 AM
Subscribers

Details

Summary

Ref T4379. Perform all editing with modern transaction infrastructure. A few practical changes here:

  • Message for "project name required" should be a little nicer. I'll deal with this once more stuff gets straightened out. You get a reasonable message now, it's just not nicely handled as part of the form.
  • Message for "project name is not unique" should be a little nicer. Same as above.
  • Previously, we would automatically archive a project when the last member left or was removed. I'll probably restore this in a bit but am omitting it for the moment for simplicity.
  • Previously, we would create projects with goofy nonsensical permissions. Now we create them with reasonable permissions.
Test Plan
  • Created project.
  • Edited project.
  • Ran unit tests.
  • Viewed project edit history.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped