Page MenuHomePhabricator

Remove PhabricatorProjectEditor
ClosedPublic

Authored by epriestley on Feb 8 2014, 12:25 AM.
Tags
None
Referenced Files
F15571381: D8168.id18479.diff
Mon, May 5, 6:02 AM
F15571380: D8168.id.diff
Mon, May 5, 6:02 AM
F15571379: D8168.diff
Mon, May 5, 6:02 AM
F15522975: D8168.diff
Sun, Apr 20, 10:48 PM
F15502646: D8168.diff
Mon, Apr 14, 2:47 AM
F15493727: D8168.diff
Sat, Apr 12, 10:06 PM
F15477115: D8168.id18518.diff
Apr 7 2025, 12:38 PM
F15473397: D8168.id.diff
Apr 5 2025, 9:42 PM
Subscribers

Details

Summary

Ref T4379. Perform all editing with modern transaction infrastructure. A few practical changes here:

  • Message for "project name required" should be a little nicer. I'll deal with this once more stuff gets straightened out. You get a reasonable message now, it's just not nicely handled as part of the form.
  • Message for "project name is not unique" should be a little nicer. Same as above.
  • Previously, we would automatically archive a project when the last member left or was removed. I'll probably restore this in a bit but am omitting it for the moment for simplicity.
  • Previously, we would create projects with goofy nonsensical permissions. Now we create them with reasonable permissions.
Test Plan
  • Created project.
  • Edited project.
  • Ran unit tests.
  • Viewed project edit history.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped