Page MenuHomePhabricator

Remove PhabricatorProjectEditor
ClosedPublic

Authored by epriestley on Feb 8 2014, 12:25 AM.
Tags
None
Referenced Files
F18734609: D8168.id.diff
Tue, Sep 30, 10:57 PM
F18659542: D8168.id.diff
Sep 23 2025, 1:14 PM
F18649539: D8168.diff
Sep 20 2025, 9:16 PM
F18610554: D8168.diff
Sep 14 2025, 4:49 AM
F18602419: D8168.diff
Sep 13 2025, 3:03 PM
F18589338: D8168.diff
Sep 12 2025, 3:08 AM
F18577491: D8168.id18518.diff
Sep 10 2025, 7:10 PM
F18106933: D8168.diff
Aug 10 2025, 11:32 PM
Subscribers

Details

Summary

Ref T4379. Perform all editing with modern transaction infrastructure. A few practical changes here:

  • Message for "project name required" should be a little nicer. I'll deal with this once more stuff gets straightened out. You get a reasonable message now, it's just not nicely handled as part of the form.
  • Message for "project name is not unique" should be a little nicer. Same as above.
  • Previously, we would automatically archive a project when the last member left or was removed. I'll probably restore this in a bit but am omitting it for the moment for simplicity.
  • Previously, we would create projects with goofy nonsensical permissions. Now we create them with reasonable permissions.
Test Plan
  • Created project.
  • Edited project.
  • Ran unit tests.
  • Viewed project edit history.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped