Page MenuHomePhabricator

Remove PhabricatorProjectEditor
ClosedPublic

Authored by epriestley on Feb 8 2014, 12:25 AM.
Tags
None
Referenced Files
F15493727: D8168.diff
Sat, Apr 12, 10:06 PM
F15477115: D8168.id18518.diff
Mon, Apr 7, 12:38 PM
F15473397: D8168.id.diff
Sat, Apr 5, 9:42 PM
F15469813: D8168.diff
Fri, Apr 4, 4:47 PM
F15390936: D8168.id18518.diff
Sat, Mar 15, 7:26 AM
F15293719: D8168.id18518.diff
Mar 5 2025, 4:35 AM
Unknown Object (File)
Feb 24 2025, 4:08 PM
Unknown Object (File)
Feb 23 2025, 5:14 AM
Subscribers

Details

Summary

Ref T4379. Perform all editing with modern transaction infrastructure. A few practical changes here:

  • Message for "project name required" should be a little nicer. I'll deal with this once more stuff gets straightened out. You get a reasonable message now, it's just not nicely handled as part of the form.
  • Message for "project name is not unique" should be a little nicer. Same as above.
  • Previously, we would automatically archive a project when the last member left or was removed. I'll probably restore this in a bit but am omitting it for the moment for simplicity.
  • Previously, we would create projects with goofy nonsensical permissions. Now we create them with reasonable permissions.
Test Plan
  • Created project.
  • Edited project.
  • Ran unit tests.
  • Viewed project edit history.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped