Page MenuHomePhabricator

Remove PhabricatorProjectEditor
ClosedPublic

Authored by epriestley on Feb 8 2014, 12:25 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, May 2, 12:29 AM
Unknown Object (File)
Sat, Apr 27, 11:29 PM
Unknown Object (File)
Sat, Apr 27, 11:29 PM
Unknown Object (File)
Sat, Apr 27, 11:28 PM
Unknown Object (File)
Thu, Apr 25, 2:30 AM
Unknown Object (File)
Mon, Apr 22, 12:45 AM
Unknown Object (File)
Sun, Apr 14, 9:02 AM
Unknown Object (File)
Thu, Apr 11, 10:33 AM
Subscribers

Details

Summary

Ref T4379. Perform all editing with modern transaction infrastructure. A few practical changes here:

  • Message for "project name required" should be a little nicer. I'll deal with this once more stuff gets straightened out. You get a reasonable message now, it's just not nicely handled as part of the form.
  • Message for "project name is not unique" should be a little nicer. Same as above.
  • Previously, we would automatically archive a project when the last member left or was removed. I'll probably restore this in a bit but am omitting it for the moment for simplicity.
  • Previously, we would create projects with goofy nonsensical permissions. Now we create them with reasonable permissions.
Test Plan
  • Created project.
  • Edited project.
  • Ran unit tests.
  • Viewed project edit history.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped