Paths

Table of Contentst

Encode username and password correctly in PhutilURI
ClosedPublic
Actions

Authored by epriestley on Feb 5 2014, 5:10 PM.

Tags

None

Referenced Files

	F13190761: D8144.diff
	Sat, May 11, 1:26 PM

	Unknown Object (File)
	Mon, Apr 29, 2:37 PM

	Unknown Object (File)
	Wed, Apr 24, 10:38 PM

	Unknown Object (File)
	Thu, Apr 18, 10:34 AM

	Unknown Object (File)
	Wed, Apr 17, 2:33 PM

	Unknown Object (File)
	Fri, Apr 12, 2:31 PM

	Unknown Object (File)
	Fri, Apr 12, 2:30 PM

	Unknown Object (File)
	Fri, Apr 12, 1:11 PM

View All Files

Subscribers

aran

Details

Reviewers

btrahan

Maniphest Tasks

T4374: Password strings do not seem to be escaped properly

Commits

rPHU9e85344d3ffb: Encode username and password correctly in PhutilURI

Summary

Fixes T4374. We do not encode passwords in URIs correctly, so passwords with, e.g., the @ character do not work correctly.

Test Plan

Added unit tests.

Diff Detail

Repository

rPHU libphutil

Branch

encode

Lint

Lint Passed

Unit

Tests Passed

Event Timeline

btrahan accepted this revision.Feb 5 2014, 10:13 PM

Closed by commit rPHU9e85344d3ffb (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

parser/

PhutilURI.php

13 lines

__tests__/

PhutilURITestCase.php

20 lines

Diff 18429

View Options

src/parser/PhutilURI.php

View Options

src/parser/tests/PhutilURITestCase.php

Encode username and password correctly in PhutilURIClosedPublicActions