Page MenuHomePhabricator

Password strings do not seem to be escaped properly
Closed, ResolvedPublic

Description

Hello, I was trying to import a git repository in Diffusion with the password: !@#4QWEr and it failed with the below backtrace, as soon as I changed my password to contain only anum characters the import was successful:

error: Couldn't resolve host '#4QWEr@domain.org' while accessing https://username:!@#4QWEr@domain.org/username/supporttools.git/info/refs
fatal: HTTP request failed
at [/opt/Phabricator/libphutil/src/future/exec/ExecFuture.php:398]
[04-Feb-2014 13:11:38 UTC] #0 ExecFuture::resolvex() called at [/opt/Phabricator/phabricator/src/applications/repository/storage/PhabricatorRepository.php:253]
[04-Feb-2014 13:11:38 UTC] #1 PhabricatorRepository::execxRemoteCommand(clone --bare -- %P %s, Object PhutilOpaqueEnvelope, /var/repo/SUPPORTTOOLS) called at [/opt/Phabricator/phabricator/src/applications/repository/engine/PhabricatorRepositoryPullEngine.php:211]
[04-Feb-2014 13:11:38 UTC] #2 PhabricatorRepositoryPullEngine::executeGitCreate() called at [/opt/Phabricator/phabricator/src/applications/repository/engine/PhabricatorRepositoryPullEngine.php:78]
[04-Feb-2014 13:11:38 UTC] #3 PhabricatorRepositoryPullEngine::pullRepository() called at [/opt/Phabricator/phabricator/src/applications/repository/daemon/PhabricatorRepositoryPullLocalDaemon.php:127]
[04-Feb-2014 13:11:38 UTC] #4 PhabricatorRepositoryPullLocalDaemon::run() called at [/opt/Phabricator/libphutil/src/daemon/PhutilDaemon.php:85]
[04-Feb-2014 13:11:38 UTC] #5 PhutilDaemon::execute() called at [/opt/Phabricator/libphutil/scripts/daemon/exec/exec_daemon.php:112]
[04-Feb-2014 13:11:38 UTC] [2014-02-04 15:11:38] EXCEPTION: (PhutilProxyException) Error while fetching changes to the 'SCC' repository. {>} (CommandException) Command failed with error #1!

Event Timeline

andrei.sasu42 raised the priority of this task from to Needs Triage.
andrei.sasu42 updated the task description. (Show Details)
andrei.sasu42 added a project: Phabricator.
epriestley triaged this task as Normal priority.
epriestley removed a project: Phabricator.

This should be fixed in HEAD. Thanks for the report! Let us know if you run into anything else.